Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index.{js,ts,jsx,tsx} always on top #128834

Closed
drpicox opened this issue Jul 16, 2021 · 3 comments
Closed

index.{js,ts,jsx,tsx} always on top #128834

drpicox opened this issue Jul 16, 2021 · 3 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) file-explorer Explorer widget issues

Comments

@drpicox
Copy link

drpicox commented Jul 16, 2021

When we work with JS or TS, we usually do:

import { symbol } from 'some/folder'

And in the some/folder there is a index.ts that does:

export * from './aThing';
export * from './bThing';
...
export * from './yThing';
export * from './zThing';

The problem, is that when we look at the folder in the Explorer we see the files like:

- some/folder
  - aThing.ts
  - bThing.ts
  - index.ts
  - yThing.ts
  - zThing.ts

It is difficult to spot and edit the index.ts. It is like it has camouflage.

The problem is:

  1. The file follows a different kind of naming (the one forced by node importing rules) from the rest files from the package
  2. It defines what the folder is itself, so it breaks apart the same single concept

The proposal is to reorder the contents of the folder so index.{js,ts,jsx,tsx} is always just below the folder name:

- some/folder
  - index.ts
  - aThing.ts
  - bThing.ts
  - yThing.ts
  - zThing.ts
@isidorn isidorn added *duplicate Issue identified as a duplicate of another issue(s) file-explorer Explorer widget issues labels Jul 26, 2021
@drpicox
Copy link
Author

drpicox commented Jul 26, 2021

I am not sure about it, I did some research before adding the issue, and looking one by one from suggested ones it seems that I cannot find an exact duplicated:

And also checking some of the most recent ones closed

But, it "looks like":

@SmartHypercube
Copy link

@isidorn I think it's a little strange to close an issue as dup without mentioning the original issue's number. The author has clearly put some effort in looking for possible dups. I cannot find the original issue either. This is unhelpful and will leave future people searching for the same problem a big mystery.

Could you please reopen this issue or give the original issue's number?

@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) file-explorer Explorer widget issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@isidorn @drpicox @SmartHypercube and others