-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use custom hover for activity bar tooltip #118077
Comments
Right, I think we've discussed this approach as Chrome does this on tabs as well, the first tooltip fades in and then as you move around the rest are instantly shown. I think @alexr00 looked into this? |
This was a more agreed upon proposal when last brought up at a UX sync, instead of having labels under activity bar icons: #104452 (comment) |
Right, Chrome tab hover cards even transitioning from one to the next tab. There are some animation best practices out there about this, but not sure if this one is too distracting, delightful, or actually a cognitive benefit. I personally am a fan of delightful animations that encourage exploration and don't get in the way of productivity. |
Isn't that pretty much standard hover behaviour even with native ones? When the hover appears and I move my mouse to another location with a hover, the hover should appear instantly and not require another delay. The delay is only useful to not bring up the hover too quickly when the user moves the mouse. |
@bpasero yes that is standard native behavior but our custom hover does not behave this way. |
@sandy081 thoughts on moving this to April? |
I am ready to help run this as experiment to learn how improving UI affordance enhances the experience for new users. |
Sure, will look at this in April. |
@sandy081 not sure if you're using it already, but there is a setting for the hover delay that should probably be used for the hovers you are changing |
I think the quick hover was intentional here. I love the activity bar but not so much the panel ones as it's mostly repeating information and getting in the way, |
Thoughts on using this to potentially rename the gear icon from "Manage" to "Settings" or "Preferences"? This is generally more common in apps like Edge, Slack, and Chrome as well. |
There is an ask to make this as an experiment and check and measure if this improves the experience. Any thoughts about making this default or change it to an experiment before making it default? |
Since we saw many users in the getting started user studies often hovering icons and clicking through menus, I think it could be useful to roll this out as an experiment to measure how much more engagement with the activity bar we see, and if it improves the new user experience specifically. |
Imo we should consistently show the hover near instantly for textless actions, and consistently use the workbench delay for actions with text. |
+1 on only showing the hover on a delay that is configurable. |
I mostly agree though I might make an exception for the panel headers because of the shortcut key visibility. Makes me also want this for all actionbar icons too. |
I like the instant hover. |
Reopening it for discussion as it seems some of us does not like it |
For me there are two problems with the custom hover
|
From #121354:
The native hover seems to work well so far: |
I really like the new hovers, though I would recommend a very short delay -- just to avoid them showing up while the mouse is moving, but still very quickly. Similar to Slack's workspace bar. I also really like that those hover go along with the theme now. Are we using a new theme color for the hover feedback? As I would like to theme that to look better. |
Will introduce or reuse the delay setting.
Right. We can make them position like native hovers. Personally I liked how it is currently and is also suggested as req. I will collect more feedback before getting to this.
Reason is mentioned in the summary of the issue - just mentioning it again here I think one of the areas that could benefit from quicker tooltips/custom hovers is the activity bar as it is a frequently used area and the native tooltip takes too long to load. We've seen this in user studies where new users are not sure what these items are and don't click on them.
I do not know if hovers can be theme-able - @Tyriar ?
Good suggestion - will take a look
Right - will check it out and fix |
Now that someone has mentioned slack: I think they do better job because their "button-hover" is so different from the native hover that you don't get the confused feeling that the "native, not-native hover" is wrong. |
Introduced slight delay for showing custom hovers on activity bar/panel. |
A similar "flicker" also happens in the explorer.
Not yet, though I think we should have 2 different styles, maybe with a little arrow and/or the fade in animation to differentiate it. Then center the hover and for the panel put them on the top like this: |
As requested by @digitarald and @sana-ajani I moved custom hovers behind an experimental flag. So they are off by default and you can enable it using the setting I liked the suggestions provided by @misolori and @Tyriar - will try to implement that in this milestone. |
@sandy081 the animation in #118077 (comment) (which also applies to native tooltips) does not fade in and out while hovering between aligned buttons: Would it be possible to not drop this affordance with custom tooltips, as we see a lot of users hovering across toolbars to quickly scan for specific features? |
@pixieaka Can you please file a separate issue for it? |
@pixieaka posting here as well, but the blue line is the focus state in the activity bar. If you tab into the activity bar you'll see the same thing so this is by design. |
Closing this issue and will track any feedback in separate issues. |
I think one of the areas that could benefit from quicker tooltips/custom hovers is the activity bar as it is a frequently used area and the native tooltip takes too long to load. We've seen this in user studies where new users are not sure what these items are and don't click on them.
cc @bpasero @alexr00
The text was updated successfully, but these errors were encountered: