Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use custom hover for activity bar tooltip #118077

Closed
miguelsolorio opened this issue Mar 3, 2021 · 39 comments · Fixed by #121291
Closed

Use custom hover for activity bar tooltip #118077

miguelsolorio opened this issue Mar 3, 2021 · 39 comments · Fixed by #121291
Assignees
Labels
feature-request Request for new features or functionality on-testplan ux User experience issues workbench-hover Hover issues in the workbench
Milestone

Comments

@miguelsolorio
Copy link
Contributor

Kapture 2021-03-03 at 13 31 26

I think one of the areas that could benefit from quicker tooltips/custom hovers is the activity bar as it is a frequently used area and the native tooltip takes too long to load. We've seen this in user studies where new users are not sure what these items are and don't click on them.

cc @bpasero @alexr00

@miguelsolorio miguelsolorio added ux User experience issues workbench-hover Hover issues in the workbench labels Mar 3, 2021
@digitarald
Copy link
Contributor

digitarald commented Mar 4, 2021

Love the direction. I could not if browser tooltips had UX revisions; and most web-based apps I use replaced tooltips with custom tooltips to make them feel well integrated.

It should probably hook into the theming colors; which I think your mockup considers. The result will

To make it feel snappier, a common pattern that can be found in the wild is to not fade the tooltip in/out when moving between buttons that are aligned next to each other (horizontal & vertical). Figma as an example (screen recording didn't capture the right mouse position):
recording(1)

Since they will be HTML, it's an opportunity to think about a multi-line layout that breaks out the shortcut on a new line. For prominent buttons, it could also leave room for an additional one-liner that explains the feature.

@miguelsolorio
Copy link
Contributor Author

Right, I think we've discussed this approach as Chrome does this on tabs as well, the first tooltip fades in and then as you move around the rest are instantly shown. I think @alexr00 looked into this?

@sana-ajani
Copy link
Contributor

sana-ajani commented Mar 4, 2021

This was a more agreed upon proposal when last brought up at a UX sync, instead of having labels under activity bar icons: #104452 (comment)

@digitarald
Copy link
Contributor

The first tooltip fades in and then as you move around the rest are instantly shown.

Right, Chrome tab hover cards even transitioning from one to the next tab.

recording(2)

There are some animation best practices out there about this, but not sure if this one is too distracting, delightful, or actually a cognitive benefit. I personally am a fan of delightful animations that encourage exploration and don't get in the way of productivity.

@bpasero
Copy link
Member

bpasero commented Mar 4, 2021

Right, I think we've discussed this approach as Chrome does this on tabs as well, the first tooltip fades in and then as you move around the rest are instantly shown.

Isn't that pretty much standard hover behaviour even with native ones? When the hover appears and I move my mouse to another location with a hover, the hover should appear instantly and not require another delay. The delay is only useful to not bring up the hover too quickly when the user moves the mouse.

@miguelsolorio
Copy link
Contributor Author

@bpasero yes that is standard native behavior but our custom hover does not behave this way.

@sandy081 sandy081 added the feature-request Request for new features or functionality label Mar 5, 2021
@sandy081 sandy081 added this to the On Deck milestone Mar 5, 2021
@miguelsolorio
Copy link
Contributor Author

@sandy081 thoughts on moving this to April?

@digitarald
Copy link
Contributor

I am ready to help run this as experiment to learn how improving UI affordance enhances the experience for new users.

@sandy081
Copy link
Member

Sure, will look at this in April.

@sandy081
Copy link
Member

Created the PR implementing this

Kapture 2021-04-14 at 15 56 39

@alexr00
Copy link
Member

alexr00 commented Apr 14, 2021

@sandy081 not sure if you're using it already, but there is a setting for the hover delay that should probably be used for the hovers you are changing workbench.hover.delay.

@Tyriar
Copy link
Member

Tyriar commented Apr 14, 2021

I think the quick hover was intentional here.

I love the activity bar but not so much the panel ones as it's mostly repeating information and getting in the way, workbench.hover.delay would make sense there?

@sandy081
Copy link
Member

@alexr00 Thanks for mentioning about it. I have seen its usage but went without using it for quick hover as @Tyriar mentioned.

Re using hover delay in panel, went with consistency in activity bar and panels.

@sana-ajani
Copy link
Contributor

Thoughts on using this to potentially rename the gear icon from "Manage" to "Settings" or "Preferences"? This is generally more common in apps like Edge, Slack, and Chrome as well.

@sandy081
Copy link
Member

There is an ask to make this as an experiment and check and measure if this improves the experience. Any thoughts about making this default or change it to an experiment before making it default?

@sana-ajani
Copy link
Contributor

Since we saw many users in the getting started user studies often hovering icons and clicking through menus, I think it could be useful to roll this out as an experiment to measure how much more engagement with the activity bar we see, and if it improves the new user experience specifically.

@Tyriar
Copy link
Member

Tyriar commented Apr 14, 2021

Re using hover delay in panel, went with consistency in activity bar and panels.

Imo we should consistently show the hover near instantly for textless actions, and consistently use the workbench delay for actions with text.

@bpasero
Copy link
Member

bpasero commented Apr 14, 2021

+1 on only showing the hover on a delay that is configurable.

@eamodio
Copy link
Contributor

eamodio commented Apr 14, 2021

Imo we should consistently show the hover near instantly for textless actions, and consistently use the workbench delay for actions with text.

I mostly agree though I might make an exception for the panel headers because of the shortcut key visibility.

Makes me also want this for all actionbar icons too.

@eamodio
Copy link
Contributor

eamodio commented Apr 14, 2021

I like the instant hover.

@sandy081
Copy link
Member

Reopening it for discussion as it seems some of us does not like it

@jrieken
Copy link
Member

jrieken commented Apr 15, 2021

For me there are two problems with the custom hover

  • it shows to quickly
  • it always shows at the same position, doesn't respect my relative mouse position, and that makes it very alien

@bpasero
Copy link
Member

bpasero commented Apr 15, 2021

From #121354:

  • it should not use the custom hover unless there is a good reason (e.g. do we show markdown in there?)
  • it should have a configurable color so that I have a way to disable it if I don't like it

The native hover seems to work well so far:

image

@eamodio
Copy link
Contributor

eamodio commented Apr 15, 2021

I really like the new hovers, though I would recommend a very short delay -- just to avoid them showing up while the mouse is moving, but still very quickly. Similar to Slack's workspace bar.

I also really like that those hover go along with the theme now. Are we using a new theme color for the hover feedback? As I would like to theme that to look better.

image

@eamodio
Copy link
Contributor

eamodio commented Apr 15, 2021

Also it would be great if we could render the shortcut keys better now, again maybe similar to Slack's
image

@eamodio
Copy link
Contributor

eamodio commented Apr 16, 2021

It seems like there is some unwanted flicker on the activity bar
flicker

@sandy081
Copy link
Member

sandy081 commented Apr 16, 2021

it shows to quickly

Will introduce or reuse the delay setting.

it always shows at the same position, doesn't respect my relative mouse position, and that makes it very alien

Right. We can make them position like native hovers. Personally I liked how it is currently and is also suggested as req. I will collect more feedback before getting to this.

it should not use the custom hover unless there is a good reason

Reason is mentioned in the summary of the issue - just mentioning it again here

I think one of the areas that could benefit from quicker tooltips/custom hovers is the activity bar as it is a frequently used area and the native tooltip takes too long to load. We've seen this in user studies where new users are not sure what these items are and don't click on them.

it should have a configurable color so that I have a way to disable it if I don't like it

I do not know if hovers can be theme-able - @Tyriar ?

Also it would be great if we could render the shortcut keys better now, again maybe similar to Slack's

Good suggestion - will take a look

It seems like there is some unwanted flicker on the activity bar

Right - will check it out and fix

@jrieken
Copy link
Member

jrieken commented Apr 16, 2021

Right. We can make them position like native hovers. Personally I liked how it is currently and is also suggested as req. I will collect more feedback before getting to this.

Now that someone has mentioned slack: I think they do better job because their "button-hover" is so different from the native hover that you don't get the confused feeling that the "native, not-native hover" is wrong.

@sandy081
Copy link
Member

Introduced slight delay for showing custom hovers on activity bar/panel.

@miguelsolorio
Copy link
Contributor Author

Trying this out after being gone for a week, I definitely like the hover feedback. However, it seems like there are a few things that could be improved for all hovers and not specific to the activity bar:

  • The hover text is really large, especially when there's extra text in the title
  • It can be hard to tell where the hover is coming from when there is no "arrow" that is common in tooltips like

Since this hover is inheriting the default styles from the editor hover, I'd like to propose a different styling for non-editor hovers (we can also move this feedback into a separate issue):

@Tyriar
Copy link
Member

Tyriar commented Apr 19, 2021

A similar "flicker" also happens in the explorer.

Now that someone has mentioned slack: I think they do better job because their "button-hover" is so different from the native hover that you don't get the confused feeling that the "native, not-native hover" is wrong.

I do not know if hovers can be theme-able

Not yet, though I think we should have 2 different styles, maybe with a little arrow and/or the fade in animation to differentiate it. Then center the hover and for the panel put them on the top like this:

image

@sandy081
Copy link
Member

As requested by @digitarald and @sana-ajani I moved custom hovers behind an experimental flag. So they are off by default and you can enable it using the setting workbench.experimental.useCustomHover.

I liked the suggestions provided by @misolori and @Tyriar - will try to implement that in this milestone.

sandy081 added a commit that referenced this issue Apr 20, 2021
@digitarald
Copy link
Contributor

@sandy081 the animation in #118077 (comment) (which also applies to native tooltips) does not fade in and out while hovering between aligned buttons:

recording(1)

Would it be possible to not drop this affordance with custom tooltips, as we see a lot of users hovering across toolbars to quickly scan for specific features?

@pixieaka
Copy link

@sandy081 I have noticed this blue line in the left when mouse down only in file icon and this doesn't shows in the other icons. (0310f02)

image

@sandy081
Copy link
Member

@pixieaka Can you please file a separate issue for it?

@miguelsolorio
Copy link
Contributor Author

miguelsolorio commented Apr 23, 2021

@pixieaka posting here as well, but the blue line is the focus state in the activity bar. If you tab into the activity bar you'll see the same thing so this is by design.

@sandy081
Copy link
Member

Did some improvements based on received feedback

Kapture 2021-04-26 at 15 13 55

@sandy081
Copy link
Member

Closing this issue and will track any feedback in separate issues.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality on-testplan ux User experience issues workbench-hover Hover issues in the workbench
Projects
None yet
Development

Successfully merging a pull request may close this issue.

11 participants