Update toolbar actions with hover feedback

[miguelsolorio]

Now that #120226 has added hover feedback, we should look at improving the other areas that use this to make them feel consistent. Here's an idea to update the notebook toolbar and status bar items to also have matching corners:

We'd need to account for when items in the status bar that have a bg color (like the remote indicator or error bg)

cc @bpasero for status bar, @rebornix for notebooks

[miguelsolorio]

Also worth looking at the activity bar as well, but that seems like it needs more consideration as we have the active indicator and active background color token cc @sandy081

[sandy081]

@misolori hover backgrounds in activity bar and panel are handled here - #118077 (comment)

[joaomoreno]

@misolori @sandy081 After playing around with it today, I'm not entirely convinced that the hover background color on activity actions and panel titles works as well as it does in tiny 16px actions. I would simply keep a foreground hover change on those, what do you think?

Statusbar looks good tho.

[sandy081]

Removed hover background until we come to a conclusion.

[sandy081]

I liked the hover background with custom hovers. I felt they go well along together.

[bpasero]

I like the hover feedback on toolbar actions a lot, but feel they are not so nice in activity bar and panel given we already have hover feedback there for a long time.

I would decouple the idea of custom hovers there from the hover feedback imho. You can do custom hovers but keep the current hover feedback.

[joaomoreno]

My opinion copied from Slack is almost @bpasero's verbatim:

there are two distinct UI features here that I wish we decouple asap:

• tooltips
• hover background color on activity and panel

the tooltips are great for discoverability: that should be behind a setting. but the hover background color on activity and panel gives a heaviness to the workbench: that should just be reverted. when I added hover background color to actions I tried activity bar and panel and did not push that on purpose, since it looks really odd. please consider just removing this @sandy081

[miguelsolorio]

Closing in favor of #118077