-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expose all options to packaging and publishing APIs #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@nhedger Still draft? |
I'll have a look this weekend. I don't remember from the top of my head if I had anything more to do. |
Alright, seems good to review. The |
joaomoreno
approved these changes
Aug 29, 2022
jrieken
approved these changes
Aug 29, 2022
🎉 This PR is included in version 2.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces modifications to allow the API methods to use all options currently supported by the CLI.
The following modifications have been made:
Packaging
createVSIX
function now accepts anIPackageOptions
instead ofICreateVSIXOptions
ICreateVSIXOptions
has been kept in the file and refactored to stay backward compatible.ICreateVSIXOptions
has been marked as deprecated to encourage usingIPackageOptions
instead.Publishing
publishVSIX
function still accepts anIPublishOptions
but it's currently an alias to theIPublishOptions
type declared inpublish.ts
IPublishVSIXOptions
has been refactored to extend fromIPublishOptions
and also includes the neededtarget
property.This should in theory be backward compatible because all existing types can still be imported and they were subsets of the types declared for the CLI.
Todo
Closes #754