Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Differences between the CLI and the API #754

Closed
nhedger opened this issue Jul 10, 2022 · 3 comments · Fixed by #759
Closed

Differences between the CLI and the API #754

nhedger opened this issue Jul 10, 2022 · 3 comments · Fixed by #759
Assignees
@joaomoreno
Labels
help wanted Issues identified as good community contribution opportunities released

Comments

@nhedger
Copy link
Contributor

nhedger commented Jul 10, 2022

Not sure if this is by design, but I noticed that a few options currently available on the CLI are not exposed on the API.

The packageCommand function accepts a IPackageOptions which seems to contain all the available options but the API's createVSIX function accepts a ICreateVSIXOptions which narrows the available options.

I guess what I'm asking is:

  1. Is there a good reason for this that I am missing ?
  2. Would you be willing to open all options to the API ?

I'd be willing to submit a PR.
@joaomoreno
Copy link
Member

I believe the current state is as is just 'cause no one asked for those API calls yet. PR welcome!

@joaomoreno joaomoreno added the help wanted Issues identified as good community contribution opportunities label Jul 15, 2022
@joaomoreno joaomoreno self-assigned this Jul 15, 2022
@nhedger
Copy link
Contributor Author

nhedger commented Jul 15, 2022

Good to hear, I'll PR something soon in that case.

@nhedger nhedger mentioned this issue Jul 23, 2022
Merged
1 task
@github-actions
Copy link

🎉 This issue has been resolved in version 2.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joaomoreno joaomoreno

Labels
help wanted Issues identified as good community contribution opportunities released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: expose all options to packaging and publishing APIs
2 participants
@joaomoreno @nhedger