Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pytest plugin cherrypick #20175

Closed
wants to merge 54 commits into from
Closed

Pytest plugin cherrypick #20175

wants to merge 54 commits into from

Conversation

eleanorjboyd
Copy link
Member

@eleanorjboyd eleanorjboyd commented Nov 7, 2022 •
edited
Loading

Fixes #20077

Eleanor Boyd and others added 30 commits November 7, 2022 13:36
@eleanorjboyd
setup file structure
2faab05
@eleanorjboyd
reverse dummy commit
68a6ff8
@eleanorjboyd
stash to isolate error
ac8b269
@eleanorjboyd
fixing merge issues
48cfa47
@eleanorjboyd
pushing changes in order to rebase
cfe1379
@eleanorjboyd
changes to discoverAdapter
27c6300
@eleanorjboyd
extension is calling plugin
72aad5a
@eleanorjboyd
comitting to rebase
f56157b
@eleanorjboyd
remove all files from pytest_adapter.py
bf89286
@eleanorjboyd
resolve conflicts accept all cur
7ec8c56
@eleanorjboyd
plugin args working, and tests collected in correct format
57b6bc6
@eleanorjboyd
attempting port
ecb2a2f
@eleanorjboyd
fixing settings
7fd8315
@eleanorjboyd
continue
3e2f1c9
@eleanorjboyd
Ensure interpreter quickpick is initialized synchronously (microsoft#…
92bc0e0 
…19828)

For microsoft#19101

Before the change item events start coming in, we have to ensure
quickpick is ready to receive those events.
@eleanorjboyd
Ensure we start watching environments when activating discovery compo…
c11c547 
…nent (microsoft#19827)

Ensure we start watchers and create workspace related objects when
activating discovery component
@eleanorjboyd
Ensure an environment is only reported after the final type of enviro…
d7eaa05 
…nment is known (microsoft#19821)

For microsoft#19101
@karthiknadig @eleanorjboyd
Simplify buffer decoder. (microsoft#19836)
60de7a1
@paulacamargo25 @eleanorjboyd
cherry pick cont
212d58a
@karthiknadig @eleanorjboyd
cherry pick
dcb0561
@eleanorjboyd
Temporarily expose PYTHONPATH for Pylance (microsoft#19899)
883dd85 
Done temporarily on request of Pylance so they can begin testing.
@eleanorjboyd
Only log deprecation warning once for each extension (microsoft#19901)
75bfc97 
For microsoft#19900
@luabud @eleanorjboyd
Improve keyword hover information displayed when using Jedi (microsof…
adac2f6 
…t#19926)

For microsoft/vscode#159247 (ref:
pappasam/jedi-language-server#227 (comment))
@karthiknadig @eleanorjboyd
cherry
69abfcd
@eleanorjboyd
formatting discovery
82abb1e
@eleanorjboyd
port posting working
0e96dae
@eleanorjboyd
stashing for testing
597c3f3
@eleanorjboyd
saving changes
8b1aeaf
@eleanorjboyd
tests showing in explorer panel
097c4e0
@eleanorjboyd
remove old code
33209e3
@eleanorjboyd eleanorjboyd marked this pull request as ready for review November 7, 2022 22:37
@eleanorjboyd eleanorjboyd self-assigned this Nov 7, 2022
@eleanorjboyd eleanorjboyd added the no-changelog No news entry required label Nov 7, 2022
karthiknadig
karthiknadig requested changes Nov 10, 2022
View reviewed changes
pythonFiles/pytest-vscode-integration/MANIFEST.in Outdated Show resolved Hide resolved
pythonFiles/pytest-vscode-integration/appveyor.yml Outdated Show resolved Hide resolved
pythonFiles/pytest-vscode-integration/setup.py Outdated Show resolved Hide resolved
pythonFiles/pytest-vscode-integration/tox.ini Outdated Show resolved Hide resolved
brettcannon
brettcannon suggested changes Nov 16, 2022
View reviewed changes
pythonFiles/pytest-vscode-integration/pytest_vscode_integration.egg-info/SOURCES.txt Outdated Show resolved Hide resolved
pythonFiles/pytest-vscode-integration/tests/test_vscode_integration.py Outdated Show resolved Hide resolved
pythonFiles/pytest-vscode-integration/tests/test_vscode_integration.py Outdated Show resolved Hide resolved
pythonFiles/pytest-vscode-integration/tests/test_vscode_integration.py Outdated Show resolved Hide resolved
pythonFiles/pytest-vscode-integration/tests/test_vscode_integration.py Outdated Show resolved Hide resolved
pythonFiles/pytest-vscode-integration/tests/test_vscode_integration.py Outdated Show resolved Hide resolved
pythonFiles/pytest-vscode-integration/tests/test_vscode_integration.py Outdated Show resolved Hide resolved
eleanorjboyd and others added 8 commits November 21, 2022 13:46
brettcannon
brettcannon suggested changes Jan 19, 2023
View reviewed changes
Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be no .egg-info directory in the repo (or anywhere). That's really old setuptools stuff. If we have to have an entry_points.txt file then it should be in a .dist-info directory for the code. In fact there should be no use of setuptools in our repo as it's too heavy-handed for what we need it for. We should be using flit_core or hatchling as a build back-end instead since we only have pure Python packages. I.e. no setup.py, only pyproject.toml.

Have you tried using the -p option with the directory containing the plug-in on PYTHONPATH (or some other way to get it on to sys.path)? The wording of https://docs.pytest.org/en/stable/how-to/writing_plugins.html#making-your-plugin-installable-by-others suggests it might not be necessary to define an entry point. It also has an example of how to use pyproject.toml and hatchling to package things up if it turns out we actually do have to provide an entry point.

@eleanorjboyd eleanorjboyd mentioned this pull request Jan 25, 2023
Merged
@eleanorjboyd
Copy link
Member Author

closing in favor of #20566

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettcannon brettcannon brettcannon requested changes

@karthiknadig karthiknadig Awaiting requested review from karthiknadig

Assignees

@eleanorjboyd eleanorjboyd

Labels
no-changelog No news entry required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review and Commit Pytest Plugin (without enabling)
5 participants
@eleanorjboyd @brettcannon @karthiknadig @paulacamargo25 @luabud