Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce amount of information shown in hovers #227

Closed
alexdima opened this issue Sep 30, 2022 · 5 comments
Closed

Reduce amount of information shown in hovers #227

alexdima opened this issue Sep 30, 2022 · 5 comments

Comments

@alexdima
Copy link

👋 Hi, coming here from microsoft/vscode#159247

It looks like the hovers returned by jedi are sometimes super verbose and detailed. VS Code users are now asking us to better handle very large hovers. The problem is that on our side, we can truncate the markdown after some amount of characters, but that would give IMHO also a bad user experience.

Would it please be possible to be more succint in the hovers (e.g. the language specification part might be omitted or shown only after enabling a setting).

@pappasam
Copy link
Owner

pappasam commented Sep 30, 2022

@alexdima this has been implemented for a while, the vscode team just hasn't used the existing feature. Please refer to the hover section in https://github.com/pappasam/jedi-language-server#configuration . Keyword hover can be disabled there. See #149 for when / how this feature was implemented

@luabud
Copy link

luabud commented Oct 1, 2022

Oh cool, thanks a lot for the info! I opened microsoft/vscode-python#19926 to fix it in the Python extension side.

@r3m0t
Copy link

r3m0t commented Oct 1, 2022

@pappasam could keyword hover be off by default? Advanced Python users know their keywords, beginner Python users won't understand these hovers.

@pappasam
Copy link
Owner

pappasam commented Oct 2, 2022

@r3m0t it can be, and this is certainly something an individual language client (eg, vscode-client) can configure as its default. Hence the initialization option we already provide; individual language clients are free to use that however they want. That said, for simplicity's sake in this codebase, I don't want to default it to off on the server side.

@alexdima
Copy link
Author

alexdima commented Oct 3, 2022

Thank you very much for pointing us in the right direction! I'll close this out since the setting already exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants