Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main branch changes #14203

Merged
merged 58 commits into from
Oct 1, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
58 commits
Select commit Hold shift + click to select a range
bc9cd8b
Add an optional onUpdated event to the iterator returned by ILocator.…
ericsnowcurrently Sep 16, 2020
f687921
fully bump raw kernel (#13941)
IanMatthewHuff Sep 16, 2020
64c8526
Virtualenvwrapper locator (#13895)
kimadeline Sep 16, 2020
a9b5603
Clean up eslint errors (#13951)
karthiknadig Sep 16, 2020
016cce8
Add a legacy DI adapter for the Python envs component. (#13858)
ericsnowcurrently Sep 16, 2020
7b3b541
Extension api for DataScience (#13923)
DonJayamanne Sep 17, 2020
a7c3b7f
Fix installing ipykernel into interpreters for raw kernel (#13959)
IanMatthewHuff Sep 17, 2020
89b47a0
Fix kernel and server name missing in certain situations (#13974)
rchiodo Sep 17, 2020
7a86cf0
Extension API to return path to debugpy for DS (#13973)
DonJayamanne Sep 17, 2020
6b94c8b
Use the component adapter in the extension. (#13869)
ericsnowcurrently Sep 17, 2020
10b8965
Disable split views of custom editors (#13985)
DonJayamanne Sep 17, 2020
245f393
Fix backup storage by looking at the options correctly (#13983)
rchiodo Sep 18, 2020
8ec292e
update test plan for ipykernel (python repo) (#13993)
IanMatthewHuff Sep 18, 2020
da38997
Find interpreter based on hash in kernelspec of nb metadata (#13856)
DonJayamanne Sep 21, 2020
2cc2c93
Pyenv locator (#13996)
kimadeline Sep 21, 2020
ee0cad9
merge
gramster Sep 21, 2020
889375b
Revert "merge"
rchiodo Sep 22, 2020
8c0d3aa
Remove cwd while running using isolate script (#14014)
karthiknadig Sep 22, 2020
a7176fc
Upgrade isort to 5.5.3 (#14035)
Sep 22, 2020
ec568ca
Modify environment info worker to support new type and to work with r…
Sep 22, 2020
68e127a
Remove cross process lock (#14036)
joyceerhl Sep 22, 2020
352d9a5
Add API to get language server from external extensions (#14021)
rchiodo Sep 22, 2020
a531cba
Fix failing virtualenvwrapper Windows unit tests (#14012)
kimadeline Sep 22, 2020
221c0d5
make sure that we run our show code when a custom editor is shown (#1…
IanMatthewHuff Sep 22, 2020
367e002
Rely on AppInsights API for exceptions (#13878)
Sep 22, 2020
ed0e2a7
Fix HTML escaping to match what Jupyter does (#14038)
rchiodo Sep 22, 2020
f60eeaf
Have dependabot ignore pytest and py (#14039)
brettcannon Sep 23, 2020
5f09a26
Added environments reducer (#13953)
Sep 23, 2020
fd5abc1
Merge release back to master (#14059)
Sep 23, 2020
e31046b
Fix object sort order in tools tests (#14050)
karthiknadig Sep 23, 2020
66a4cb1
Update ubuntu images for GPU issue fix (#14064)
karthiknadig Sep 23, 2020
1a0c790
Added environments resolver (#14019)
Sep 25, 2020
6abde6b
Add Windows unit tests to the PR pipeline (#14106)
kimadeline Sep 25, 2020
d498e85
Do not opt users out of the insiders program if they have a stable ve…
Sep 25, 2020
12de21d
Do not quote isolated in exec module (#14108)
karthiknadig Sep 25, 2020
94da334
Update cell output and metadata using Edit API (#13737)
DonJayamanne Sep 25, 2020
57fedbd
Fix unit test broken by recent revert (#14122)
karthiknadig Sep 28, 2020
d9d4265
revert VSC_PYTHON_CI_TEST_VSC_CHANNEL changes (#14109)
karthiknadig Sep 28, 2020
bb2ed7a
Merge environment and compare environments (#14026)
karthiknadig Sep 28, 2020
218dd8d
Add PythonEnvInfo-related helpers. (#14051)
ericsnowcurrently Sep 29, 2020
b517aa0
Escaping fix broke a number of things (#14145)
rchiodo Sep 29, 2020
d24bfc5
Auto assign datascience issues (#14147)
DonJayamanne Sep 29, 2020
b685ef3
Change name of event used to activate extension (#14153)
DonJayamanne Sep 29, 2020
8e0e622
Fixes to streamed output in native notebooks (#14158)
DonJayamanne Sep 29, 2020
50c3fd3
Fixes to for escaping of output in native notebooks (#14159)
DonJayamanne Sep 29, 2020
6332b81
Look for `data science` labels when auto assigning issues (#14161)
DonJayamanne Sep 29, 2020
81b6d8f
Environment info cache class (#14065)
kimadeline Sep 30, 2020
411d1d4
Update Component Governance notes in the release plan
brettcannon Sep 30, 2020
5bc4eab
Merge point release back into main (#14171)
Sep 30, 2020
cc093b0
NB Convert 6.0 support for export (#14177)
IanMatthewHuff Sep 30, 2020
cfe12a7
Windows store locator (#14162)
karthiknadig Oct 1, 2020
afc155b
A different way of fixing escaping (#14186)
rchiodo Oct 1, 2020
146dae0
Fixes to escaping of output in native notebooks (#14199)
DonJayamanne Oct 1, 2020
716e61c
Display description in kernel picker (#14196)
DonJayamanne Oct 1, 2020
0a36df0
Bump node-fetch to 2.6.1 (#14181)
brettcannon Oct 1, 2020
a83c93d
Bump pytest from 6.0.1 to 6.1.0 in /news (#14190)
dependabot[bot] Oct 1, 2020
7b392ca
Merge remote-tracking branch 'origin/main' into rchiodo/merge_main
rchiodo Oct 1, 2020
3164678
Messed up merge commits
rchiodo Oct 1, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/release_plan.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
- [ ] Touch up news entries (e.g. add missing periods)
- [ ] Check the Markdown rendering to make sure everything looks good
- [ ] Add any relevant news entries for `debugpy` and the language server if they were updated
- [ ] Update [`ThirdPartyNotices-Distribution.txt`](https://github.com/Microsoft/vscode-python/blob/main/ThirdPartyNotices-Distribution.txt) by using https://tools.opensource.microsoft.com/notice (Notes for this process are in the Team OneNote under Python VS Code -> Dev Process -> Third-Party Notices / TPN file)
- [ ] Update [`ThirdPartyNotices-Distribution.txt`](https://github.com/Microsoft/vscode-python/blob/main/ThirdPartyNotices-Distribution.txt) by using https://tools.opensource.microsoft.com/notice (Notes for this process are in the Team OneNote under Python VS Code Dev Process Third-Party Notices / TPN file)
- [ ] Update [`ThirdPartyNotices-Repository.txt`](https://github.com/Microsoft/vscode-python/blob/main/ThirdPartyNotices-Repository.txt) as appropriate. This file is manually edited so you can check with the teams if anything needs to be added here.
- [ ] Create a pull request against `main` (🤖)
- [ ] Merge pull request into `main`
Expand All @@ -33,10 +33,10 @@
- [ ] Create a pull request against `main`
- [ ] Merge pull request into `main`
- [ ] Announce the code freeze is over on the same channels
- [ ] Update [Component Governance](https://dev.azure.com/ms/vscode-python/_componentGovernance) (Click on "microsoft/vscode-python" on that page). Notes are in the OneNote under Python VS Code -> Dev Process -> Component Governance.
- [ ] Provide details for any automatically detected npm dependencies
- [ ] Manually add any repository dependencies
- [ ] GDPR bookkeeping (@brettcannon) (🤖; Notes in OneNote under Python VS Code -> Dev Process -> GDPR)
- [ ] Update Component Governance (Notes are in the team OneNote under Python VS Code Dev Process Component Governance).
- [ ] Make sure there are no active alerts
- [ ] Manually add any repository/embedded/CG-incompatible dependencies
- [ ] GDPR bookkeeping (@brettcannon) (🤖; Notes in OneNote under Python VS Code Dev Process GDPR)
- [ ] Open appropriate [documentation issues](https://github.com/microsoft/vscode-docs/issues?q=is%3Aissue+is%3Aopen+label%3Apython)
- new features
- settings changes
Expand Down
123 changes: 123 additions & 0 deletions .github/workflows/assignIssue.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,123 @@
name: Assign DS issue to someone
on:
issues:
types: [opened]
jobs:
assignIssue:
name: Assign Issue to Someone
runs-on: ubuntu-latest
if: github.repository == 'microsoft/vscode-python'
steps:
- name: Created internally
id: internal
env:
ISSUE_OWNER: ${{github.event.issue.owner.login}}
run: |
echo ::set-output name=result::$(node -p -e "['rchiodo', 'greazer', 'joyceerhl', 'DavidKutu', 'claudiaregio', 'IanMatthewHuff', 'DonJayamanne'].filter(item => process.env.ISSUE_OWNER.toLowerCase() === item.toLowerCase()).length > 0 ? 1 : 0")
shell: bash
- name: Should we proceed
id: proceed
env:
ISSUE_LABELS: ${{toJson(github.event.issue.labels)}}
ISSUE_ASSIGNEES: ${{toJson(github.event.issue.assignees)}}
ISSUE_IS_INTERNAL: ${{steps.internal.outputs.result}}
run: |
echo ::set-output name=result::$(node -p -e "process.env.ISSUE_IS_INTERNAL === '0' && JSON.parse(process.env.ISSUE_ASSIGNEES).length === 0 && JSON.parse(process.env.ISSUE_LABELS).filter(item => item.name.indexOf('data science') >= 0).length === 1 ? 1 : 0")
shell: bash
- uses: actions/checkout@v2
if: steps.proceed.outputs.result == 1
- name: Day of week
if: steps.proceed.outputs.result == 1
id: day
run: |
echo ::set-output name=number::$(node -p -e "new Date().getDay()")
shell: bash
- name: Hour of day
if: steps.proceed.outputs.result == 1
id: hour
run: |
echo ::set-output name=hour::$(node -p -e "(new Date().getUTCHours() - 7)%24")
shell: bash
- name: Week Number
if: steps.proceed.outputs.result == 1
id: week
run: |
echo ::set-output name=odd::$(node .github/workflows/week.js)
shell: bash
- name: Print day and week
if: steps.proceed.outputs.result == 1
run: |
echo ${{steps.day.outputs.number}}
echo ${{steps.week.outputs.odd}}
echo ${{steps.hour.outputs.hour}}
shell: bash
- name: Even late friday (David)
if: steps.proceed.outputs.result == 1 && steps.week.outputs.odd == 0 && steps.day.outputs.number == 5 && steps.hour.outputs.hour >= 16
uses: actions/github@v1.0.0
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
args: assign DavidKutu
- name: Odd late friday (Joyce)
if: steps.proceed.outputs.result == 1 && steps.week.outputs.odd == 1 && steps.day.outputs.number == 5 && steps.hour.outputs.hour >= 16
uses: actions/github@v1.0.0
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
args: assign joyceerhl
- name: Odd weekends (David)
if: steps.proceed.outputs.result == 1 && steps.week.outputs.odd == 1 && (steps.day.outputs.number == 6 || steps.day.outputs.number == 0)
uses: actions/github@v1.0.0
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
args: assign DavidKutu
- name: Even weekends (Joyce)
if: steps.proceed.outputs.result == 1 && steps.week.outputs.odd == 0 && (steps.day.outputs.number == 6 || steps.day.outputs.number == 0)
uses: actions/github@v1.0.0
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
args: assign joyceerhl
- name: Odd Monday (David)
if: steps.proceed.outputs.result == 1 && steps.week.outputs.odd == 1 && steps.day.outputs.number == 1 && steps.hour.outputs.hour < 16
uses: actions/github@v1.0.0
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
args: assign DavidKutu
- name: Even Monday (Joyce)
if: steps.proceed.outputs.result == 1 && steps.week.outputs.odd == 0 && steps.day.outputs.number == 1 && steps.hour.outputs.hour < 16
uses: actions/github@v1.0.0
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
args: assign joyceerhl
- name: Tuesday (Ian)
if: steps.proceed.outputs.result == 1 && (steps.day.outputs.number == 1 && steps.hour.outputs.hour >= 16) || (steps.day.outputs.number == 2 && steps.hour.outputs.hour < 16)
uses: actions/github@v1.0.0
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
args: assign IanMatthewHuff
- name: Wednesday (Rich)
if: steps.proceed.outputs.result == 1 && (steps.day.outputs.number == 2 && steps.hour.outputs.hour >= 16) || (steps.day.outputs.number == 3 && steps.hour.outputs.hour < 16)
uses: actions/github@v1.0.0
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
args: assign rchiodo
- name: Thursday (Don)
if: steps.proceed.outputs.result == 1 && (steps.day.outputs.number == 3 && steps.hour.outputs.hour >= 16) || (steps.day.outputs.number == 4 && steps.hour.outputs.hour < 16)
uses: actions/github@v1.0.0
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
args: assign DonJayamanne
- name: Friday (Claudia)
if: steps.proceed.outputs.result == 1 && (steps.day.outputs.number == 4 && steps.hour.outputs.hour >= 16) || (steps.day.outputs.number == 5 && steps.hour.outputs.hour < 16)
uses: actions/github@v1.0.0
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
with:
args: assign claudiaregio
29 changes: 29 additions & 0 deletions .github/workflows/week.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
/* For a given date, get the ISO week number
*
* Based on information at:
*
* http://www.merlyn.demon.co.uk/weekcalc.htm#WNR
*
* Algorithm is to find nearest thursday, it's year
* is the year of the week number. Then get weeks
* between that date and the first day of that year.
*
* Note that dates in one year can be weeks of previous
* or next year, overlap is up to 3 days.
*
* e.g. 2014/12/29 is Monday in week 1 of 2015
* 2012/1/1 is Sunday in week 52 of 2011
*/
function getWeekNumber(d) {
// Copy date so don't modify original
d = new Date(Date.UTC(d.getFullYear(), d.getMonth(), d.getDate()));
// Set to nearest Thursday: current date + 4 - current day number
// Make Sunday's day number 7
d.setUTCDate(d.getUTCDate() + 4 - (d.getUTCDay() || 7));
// Get first day of year
var yearStart = new Date(Date.UTC(d.getUTCFullYear(), 0, 1));
// Calculate full weeks to nearest Thursday
return Math.ceil(((d - yearStart) / 86400000 + 1) / 7);
}
// Whether it is an odd or event week.
console.log(getWeekNumber(new Date()) % 2);
1 change: 1 addition & 0 deletions .vscode/launch.json
Original file line number Diff line number Diff line change
Expand Up @@ -152,6 +152,7 @@
"skipFiles": ["<node_internals>/**"]
},
{

"name": "Tests (Multiroot, VS Code, *.test.ts)",
"type": "extensionHost",
"request": "launch",
Expand Down
63 changes: 63 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,68 @@
# Changelog

## 2020.9.1 (29 September 2020)

### Fixes

1. Fix IPyKernel install issue with windows paths.
([#13493](https://github.com/microsoft/vscode-python/issues/13493))
1. Fix escaping of output to encode HTML chars correctly.
([#5678](https://github.com/Microsoft/vscode-python/issues/5678))

### Thanks

Thanks to the following projects which we fully rely on to provide some of
our features:

- [debugpy](https://pypi.org/project/debugpy/)
- [isort](https://pypi.org/project/isort/)
- [jedi](https://pypi.org/project/jedi/)
and [parso](https://pypi.org/project/parso/)
- [Microsoft Python Language Server](https://github.com/microsoft/python-language-server)
- [Pylance](https://github.com/microsoft/pylance-release)
- [exuberant ctags](http://ctags.sourceforge.net/) (user-installed)
- [rope](https://pypi.org/project/rope/) (user-installed)

Also thanks to the various projects we provide integrations with which help
make this extension useful:

- Debugging support:
[Django](https://pypi.org/project/Django/),
[Flask](https://pypi.org/project/Flask/),
[gevent](https://pypi.org/project/gevent/),
[Jinja](https://pypi.org/project/Jinja/),
[Pyramid](https://pypi.org/project/pyramid/),
[PySpark](https://pypi.org/project/pyspark/),
[Scrapy](https://pypi.org/project/Scrapy/),
[Watson](https://pypi.org/project/Watson/)
- Formatting:
[autopep8](https://pypi.org/project/autopep8/),
[black](https://pypi.org/project/black/),
[yapf](https://pypi.org/project/yapf/)
- Interpreter support:
[conda](https://conda.io/),
[direnv](https://direnv.net/),
[pipenv](https://pypi.org/project/pipenv/),
[pyenv](https://github.com/pyenv/pyenv),
[venv](https://docs.python.org/3/library/venv.html#module-venv),
[virtualenv](https://pypi.org/project/virtualenv/)
- Linting:
[bandit](https://pypi.org/project/bandit/),
[flake8](https://pypi.org/project/flake8/),
[mypy](https://pypi.org/project/mypy/),
[prospector](https://pypi.org/project/prospector/),
[pylint](https://pypi.org/project/pylint/),
[pydocstyle](https://pypi.org/project/pydocstyle/),
[pylama](https://pypi.org/project/pylama/)
- Testing:
[nose](https://pypi.org/project/nose/),
[pytest](https://pypi.org/project/pytest/),
[unittest](https://docs.python.org/3/library/unittest.html#module-unittest)

And finally thanks to the [Python](https://www.python.org/) development team and
community for creating a fantastic programming language and community to be a
part of!

## 2020.9.0 (23 September 2020)

### Enhancements
Expand Down
1 change: 1 addition & 0 deletions news/2 Fixes/14169.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Support nbconvert version 6+ for exporting notebooks to python code.
1 change: 1 addition & 0 deletions news/2 Fixes/14182.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Do not escape output in the actual ipynb file.
5 changes: 2 additions & 3 deletions news/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,12 @@
# pip-compile
#
attrs==19.3.0 # via pytest
docopt==0.6.2 # via -r news/requirements.in
docopt==0.6.2 # via -r requirements.in
iniconfig==1.0.1 # via pytest
more-itertools==8.0.0 # via pytest
packaging==20.4 # via pytest
pluggy==0.13.1 # via pytest
py==1.9.0 # via pytest
pyparsing==2.4.5 # via packaging
pytest==6.0.1 # via -r news/requirements.in
pytest==6.1.0 # via -r requirements.in
six==1.13.0 # via packaging
toml==0.10.1 # via pytest
30 changes: 15 additions & 15 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@
"onCommand:python.resetInterpreterSecurityStorage",
"onCommand:python.startPage.open",
"onCommand:python.enableSourceMapSupport",
"onNotebookEditor:jupyter-notebook",
"onNotebook:jupyter-notebook",
"workspaceContains:mspythonconfig.json",
"workspaceContains:pyproject.toml",
"onCustomEditor:ms-python.python.notebook.ipynb"
Expand Down Expand Up @@ -2007,7 +2007,7 @@
"md5": "^2.2.1",
"minimatch": "^3.0.4",
"named-js-regexp": "^1.3.3",
"node-fetch": "^2.6.0",
"node-fetch": "^2.6.1",
"node-stream-zip": "^1.6.0",
"onigasm": "^2.2.2",
"pdfkit": "^0.11.0",
Expand Down
Loading