-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge main branch changes #14203
Merge main branch changes #14203
Commits on Sep 16, 2020
-
Add an optional onUpdated event to the iterator returned by ILocator.…
…iterEnvs(). (#13950) In order to ensure that ILocator.iterEnvs() can finish as fast as possible, we add a side-channel event for each iteration. This event fires any time an already-yielded env info object is updated (e.g. reduced/merged or resolved/completed). The update only relates to operations triggered by that particular iteration. ILocator.onChanged remains separate and only relates to when the locators finds a new env, notices one was removed, or that one was otherwise fundamentally changed. There are two similar approaches we could take for this update event. Either we added the event as a property of IPythonEnvsIterator or we change the return value of ILocator.iterEnvs() to be a 2-tuple ([PythonEnvsIterator, Event<PythonEnvUpdatedEvent>]). We took the property approach since most of the time callers won't need to worry about the update events.
Configuration menu - View commit details
-
Copy full SHA for bc9cd8b - Browse repository at this point
Copy the full SHA bc9cd8bView commit details -
fully bump raw kernel (#13941)
Co-authored-by: Ian Huff <ianhuff@CEIDCCEVIPSVC01.redmond.corp.microsoft.com>
Configuration menu - View commit details
-
Copy full SHA for f687921 - Browse repository at this point
Copy the full SHA f687921View commit details -
Virtualenvwrapper locator (#13895)
* virtualenvwrapper locator * skip os-specific tests * Test getDefaultVirtualenvwrapperDir * Update src/client/pythonEnvironments/discovery/locators/services/virtualenvwrapperLocator.ts Co-authored-by: Karthik Nadig <kanadig@microsoft.com> * add pathExists check to WORKON_HOME dir * Change how the locator works + move util func out * Fix functional tests * utils unit tests * Update locator tests * Stub getUserHomeDir instead of getDefaultetc Co-authored-by: Karthik Nadig <kanadig@microsoft.com>
Configuration menu - View commit details
-
Copy full SHA for 64c8526 - Browse repository at this point
Copy the full SHA 64c8526View commit details -
Clean up eslint errors (#13951)
* Clean up eslint errors * Fix linting and address comments.
Configuration menu - View commit details
-
Copy full SHA for a9b5603 - Browse repository at this point
Copy the full SHA a9b5603View commit details -
Add a legacy DI adapter for the Python envs component. (#13858)
This allows us to start using the new discovery code in the extension.
Configuration menu - View commit details
-
Copy full SHA for 016cce8 - Browse repository at this point
Copy the full SHA 016cce8View commit details
Commits on Sep 17, 2020
-
Extension api for DataScience (#13923)
* Extension API * Api for DS
Configuration menu - View commit details
-
Copy full SHA for 7b3b541 - Browse repository at this point
Copy the full SHA 7b3b541View commit details -
Configuration menu - View commit details
-
Copy full SHA for a7c3b7f - Browse repository at this point
Copy the full SHA a7c3b7fView commit details -
Fix kernel and server name missing in certain situations (#13974)
* Fix kernel name and server name * Fixup server name for remote situations * Add some functional tests * Add news entry
Configuration menu - View commit details
-
Copy full SHA for 89b47a0 - Browse repository at this point
Copy the full SHA 89b47a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a86cf0 - Browse repository at this point
Copy the full SHA 7a86cf0View commit details -
Use the component adapter in the extension. (#13869)
This allows us to start using the new discovery code in the extension. The key thing is to be careful not to regress in the available functionality. So for now we have disabled use of the component. When we feel comfortable with it we can enable it by setting the default for `ComponentAdapter.enabled` to `true`. This PR involves small fixes to a large number of files due to API changes. The adapter is actually used (injected) in the following files: src/client/interpreter/interpreterService.ts src/client/interpreter/helpers.ts src/client/pythonEnvironments/discovery/locators/index.ts src/client/pythonEnvironments/discovery/locators/services/condaService.ts src/client/pythonEnvironments/discovery/locators/services/windowsStoreInterpreter.ts
Configuration menu - View commit details
-
Copy full SHA for 6b94c8b - Browse repository at this point
Copy the full SHA 6b94c8bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 10b8965 - Browse repository at this point
Copy the full SHA 10b8965View commit details
Commits on Sep 18, 2020
-
Fix backup storage by looking at the options correctly (#13983)
* Fix backup storage by looking at the options correctly * Fix backup by being more explicit * Only linux tests are failing. Hopefully fix them
Configuration menu - View commit details
-
Copy full SHA for 245f393 - Browse repository at this point
Copy the full SHA 245f393View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ec292e - Browse repository at this point
Copy the full SHA 8ec292eView commit details
Commits on Sep 21, 2020
-
Configuration menu - View commit details
-
Copy full SHA for da38997 - Browse repository at this point
Copy the full SHA da38997View commit details -
* Pyenv locator * Skip tests per platform * Wrong pyenv path order in ternary * Add description * Autoformat venv locator * Revert "Autoformat venv locator" This reverts commit 5c8c4ab. * Add links * Windows-specific fixes * Typo
Configuration menu - View commit details
-
Copy full SHA for 2cc2c93 - Browse repository at this point
Copy the full SHA 2cc2c93View commit details -
Configuration menu - View commit details
-
Copy full SHA for ee0cad9 - Browse repository at this point
Copy the full SHA ee0cad9View commit details
Commits on Sep 22, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 889375b - Browse repository at this point
Copy the full SHA 889375bView commit details -
Remove cwd while running using isolate script (#14014)
* Remove cwd while running using isolate script * Run inplace. * Fix formatting
Configuration menu - View commit details
-
Copy full SHA for 8c0d3aa - Browse repository at this point
Copy the full SHA 8c0d3aaView commit details -
Upgrade isort to 5.5.3 (#14035)
Kartik Raj authoredSep 22, 2020 Configuration menu - View commit details
-
Copy full SHA for a7176fc - Browse repository at this point
Copy the full SHA a7176fcView commit details -
Modify environment info worker to support new type and to work with r…
…esolver (#13997) * Modify environment info worker to support new environment type * Do not replace existing fields and return a new object * Modify cache to carry deferred instead * Change worker to return interpreter information instead * Handle error and rename * Fix bug with interpreterInfo.py * Code reviews * Rename old PythonEnvInfo type to InterpreterInfoJson
Kartik Raj authoredSep 22, 2020 Configuration menu - View commit details
-
Copy full SHA for ec568ca - Browse repository at this point
Copy the full SHA ec568caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 68e127a - Browse repository at this point
Copy the full SHA 68e127aView commit details -
Add API to get language server from external extensions (#14021)
* Ideas for lang server API with python extension * Working with new API * Minimize API surface * Fix up tests for intellisense * Fix unit tests * Put back custom editor service * Remove unnecessary changes for service registry * Code review feedback * Move connection type to types file
Configuration menu - View commit details
-
Copy full SHA for 352d9a5 - Browse repository at this point
Copy the full SHA 352d9a5View commit details -
Fix failing virtualenvwrapper Windows unit tests (#14012)
* Fix tests * Typo Co-authored-by: Karthik Nadig <kanadig@microsoft.com> Co-authored-by: Karthik Nadig <kanadig@microsoft.com>
Configuration menu - View commit details
-
Copy full SHA for a531cba - Browse repository at this point
Copy the full SHA a531cbaView commit details -
make sure that we run our show code when a custom editor is shown (#1…
…4022) * make sure that we run our show code when a custom editor is shown * Trigger notebook load in the constructor, not show Co-authored-by: Ian Huff <ianhuff@CEIDCCEVIPSVC01.redmond.corp.microsoft.com>
Configuration menu - View commit details
-
Copy full SHA for 221c0d5 - Browse repository at this point
Copy the full SHA 221c0d5View commit details -
Rely on AppInsights API for exceptions (#13878)
* Fix path * Actually fix settings * Add news * Add test * Format * Suppress 'jediEnabled' removal * Drop survey first launch threshold * Telemetry for exceptions * Remove custom exception telemetry * Remove unused
Mikhail Arkhipov authoredSep 22, 2020 Configuration menu - View commit details
-
Copy full SHA for 367e002 - Browse repository at this point
Copy the full SHA 367e002View commit details -
Fix HTML escaping to match what Jupyter does (#14038)
* Basic idea * add some functional tests * Add news entry * Fix functional tests
Configuration menu - View commit details
-
Copy full SHA for ed0e2a7 - Browse repository at this point
Copy the full SHA ed0e2a7View commit details
Commits on Sep 23, 2020
-
Have dependabot ignore pytest and py (#14039)
Otherwise it doesn't understand the Python 2.7 restrictions for those dependencies.
Configuration menu - View commit details
-
Copy full SHA for f60eeaf - Browse repository at this point
Copy the full SHA f60eeafView commit details -
Added environments reducer (#13953)
* Add environments reducer * Added tests * Use path.join to construct paths * Code reviews * Correct dummy implementations and adjust tests * Modify resolveEnv() * Rename to a general parentLocator
Kartik Raj authoredSep 23, 2020 Configuration menu - View commit details
-
Copy full SHA for 5f09a26 - Browse repository at this point
Copy the full SHA 5f09a26View commit details -
Merge release back to master (#14059)
* Port ipykernel install fix to release (#13975) * Fix installing ipykernel into interpreters for raw kernel (#13959) * update news Co-authored-by: Ian Huff <ianhuff@CEIDCCEVIPSVC01.redmond.corp.microsoft.com> * Merge in changes to release (#13976) * Up release version for new release (#13928) * Up release version * Update changelog * Update changelog * Workaround test issue (#13930) * Try different version of VS code in release * Change to make it use the actual variable * Use a real version * More tests failing with gpu error (#13935) * Try different version of VS code in release * Change to make it use the actual variable * Use a real version * Two more version changes * Fix kernel and server name missing in certain situations (#13974) * Fix kernel name and server name * Fixup server name for remote situations * Add some functional tests * Add news entry * Delete news file * Port two fixes to the release branch (#13995) * Disable split views of custom editors (#13985) * Fix backup storage by looking at the options correctly (#13983) * Fix backup storage by looking at the options correctly * Fix backup by being more explicit * Only linux tests are failing. Hopefully fix them * Fixup changelog Co-authored-by: Don Jayamanne <don.jayamanne@yahoo.com> * add jedi-language-server to 3rd party notices (#13977) * add jedi-language-server to 3rd party notices * move license from distribution to repository file * disable test_discover_complex_default and (#14024) test_discover_complex_doctest * Upgrade isort to 5.5.3 (#14035) (#14037) * prepare release (#14042) * fixed annoying warnings (#14049) * update version Co-authored-by: Ian Huff <ianhu@microsoft.com> Co-authored-by: Ian Huff <ianhuff@CEIDCCEVIPSVC01.redmond.corp.microsoft.com> Co-authored-by: Rich Chiodo <rchiodo@users.noreply.github.com> Co-authored-by: Don Jayamanne <don.jayamanne@yahoo.com> Co-authored-by: Kartik Raj <karraj@microsoft.com>
Configuration menu - View commit details
-
Copy full SHA for fd5abc1 - Browse repository at this point
Copy the full SHA fd5abc1View commit details -
Fix object sort order in tools tests (#14050)
* Fix object sort order in tools tests * rebase with main * Fix formatting
Configuration menu - View commit details
-
Copy full SHA for e31046b - Browse repository at this point
Copy the full SHA e31046bView commit details -
Update ubuntu images for GPU issue fix (#14064)
* Update ubuntu images for GPU issue fix * Try with ubuntu-20.04
Configuration menu - View commit details
-
Copy full SHA for 66a4cb1 - Browse repository at this point
Copy the full SHA 66a4cb1View commit details
Commits on Sep 25, 2020
-
Added environments resolver (#14019)
* Modify environment info worker to support new environment type * Change worker to return interpreter information instead * Modify resolveEnv() * Code reviews * Code reviews * Move stuff
Kartik Raj authoredSep 25, 2020 Configuration menu - View commit details
-
Copy full SHA for 1a0c790 - Browse repository at this point
Copy the full SHA 1a0c790View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6abde6b - Browse repository at this point
Copy the full SHA 6abde6bView commit details -
Do not opt users out of the insiders program if they have a stable ve…
…rsion installed (#14091) * Remove code that opts users out of the insiders program * News entry * Code reviews
Kartik Raj authoredSep 25, 2020 Configuration menu - View commit details
-
Copy full SHA for d498e85 - Browse repository at this point
Copy the full SHA d498e85View commit details -
Configuration menu - View commit details
-
Copy full SHA for 12de21d - Browse repository at this point
Copy the full SHA 12de21dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 94da334 - Browse repository at this point
Copy the full SHA 94da334View commit details
Commits on Sep 28, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 57fedbd - Browse repository at this point
Copy the full SHA 57fedbdView commit details -
revert VSC_PYTHON_CI_TEST_VSC_CHANNEL changes (#14109)
* revert VSC_PYTHON_CI_TEST_VSC_CHANNEL changes * Revert "revert VSC_PYTHON_CI_TEST_VSC_CHANNEL changes" This reverts commit 6ed8f61. * Remove force 1.48 on Test VSC channel
Configuration menu - View commit details
-
Copy full SHA for d9d4265 - Browse repository at this point
Copy the full SHA d9d4265View commit details -
Merge environment and compare environments (#14026)
* Add some heuristic functions * Support merging. * Clean up identifier code * Tweaks and fixes * More clean up. * versions tweak * Address comments * more comments * Fix merge issues. * Fix more merge issues.
Configuration menu - View commit details
-
Copy full SHA for bb2ed7a - Browse repository at this point
Copy the full SHA bb2ed7aView commit details
Commits on Sep 29, 2020
-
Add PythonEnvInfo-related helpers. (#14051)
This PR adds some basic helpers that we use in a subsequent PR. The following small drive-by changes are also included: * drop PythonEnvInfo.id property * make some internal helpers public
Configuration menu - View commit details
-
Copy full SHA for 218dd8d - Browse repository at this point
Copy the full SHA 218dd8dView commit details -
Escaping fix broke a number of things (#14145)
* Fixes for escaping * Push a comment ot start PR again * Cache task is failing * Remove cache task * Not fixing so just put back cache task
Configuration menu - View commit details
-
Copy full SHA for b517aa0 - Browse repository at this point
Copy the full SHA b517aa0View commit details -
Configuration menu - View commit details
-
Copy full SHA for d24bfc5 - Browse repository at this point
Copy the full SHA d24bfc5View commit details -
Configuration menu - View commit details
-
Copy full SHA for b685ef3 - Browse repository at this point
Copy the full SHA b685ef3View commit details -
Fixes to streamed output in native notebooks (#14158)
For #13611 * Fixes to streamed output * added tests
Configuration menu - View commit details
-
Copy full SHA for 8e0e622 - Browse repository at this point
Copy the full SHA 8e0e622View commit details -
Configuration menu - View commit details
-
Copy full SHA for 50c3fd3 - Browse repository at this point
Copy the full SHA 50c3fd3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6332b81 - Browse repository at this point
Copy the full SHA 6332b81View commit details
Commits on Sep 30, 2020
-
Environment info cache class (#14065)
* Add persistent storage external deps * PythonEnvInfoCache class + tests * Instantiate & initialize cache class in createAPI * Add extra test for flush() and initialize() * Env cache fixes: storage key + find() result check * Update src/client/pythonEnvironments/common/externalDependencies.ts Co-authored-by: Kartik Raj <karraj@microsoft.com> * Use areSameEnvironment in getEnv * Don't ping persistent storage for every initialize * No need to export CompleteEnvInfoFunction * PythonEnvInfoCache doc comment * Rename createGlobalPersistentStoreStub to get... * Preemptively drop id key (#14051) * Return deep copies * IPersistentStore wrapper around IPersistentState * Use correct areSameEnvironment + fix stub * Remove obsolete comment * getEnv -> filterEnvs * Remove stubbing of areSameEnvironment * Update areSameEnv * Move IPersistentStateFactory registration to registerForIOC * Revert "Move IPersistentStateFactory registration to registerForIOC" This reverts commit edc6ce5. * Don't instantiate nor initialize cache for now Co-authored-by: Kartik Raj <karraj@microsoft.com>
Configuration menu - View commit details
-
Copy full SHA for 81b6d8f - Browse repository at this point
Copy the full SHA 81b6d8fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 411d1d4 - Browse repository at this point
Copy the full SHA 411d1d4View commit details -
Merge point release back into main (#14171)
* Port ipykernel install fix to release (#13975) * Fix installing ipykernel into interpreters for raw kernel (#13959) * update news Co-authored-by: Ian Huff <ianhuff@CEIDCCEVIPSVC01.redmond.corp.microsoft.com> * Merge in changes to release (#13976) * Up release version for new release (#13928) * Up release version * Update changelog * Update changelog * Workaround test issue (#13930) * Try different version of VS code in release * Change to make it use the actual variable * Use a real version * More tests failing with gpu error (#13935) * Try different version of VS code in release * Change to make it use the actual variable * Use a real version * Two more version changes * Fix kernel and server name missing in certain situations (#13974) * Fix kernel name and server name * Fixup server name for remote situations * Add some functional tests * Add news entry * Delete news file * Port two fixes to the release branch (#13995) * Disable split views of custom editors (#13985) * Fix backup storage by looking at the options correctly (#13983) * Fix backup storage by looking at the options correctly * Fix backup by being more explicit * Only linux tests are failing. Hopefully fix them * Fixup changelog Co-authored-by: Don Jayamanne <don.jayamanne@yahoo.com> * add jedi-language-server to 3rd party notices (#13977) * add jedi-language-server to 3rd party notices * move license from distribution to repository file * disable test_discover_complex_default and (#14024) test_discover_complex_doctest * Upgrade isort to 5.5.3 (#14035) (#14037) * prepare release (#14042) * fixed annoying warnings (#14049) * Cherry pick to address path issues. (#14125) * Do not quote isolated in exec module (#14108) * Do not quote isolated in exec module * Revert "Do not quote isolated in exec module" This reverts commit b9fa04c. * Revert "IPyKernel install issue with windows paths (#13667)" This reverts commit 23725ab. * Fix unit test broken by recent revert (#14122) * Port escape fix to release branch (#14133) * Fix HTML escaping to match what Jupyter does (#14038) * Basic idea * add some functional tests * Add news entry * Fix functional tests * Update changelog * update version and changelog (#14139) * Escaping fix broke a number of things (#14145) (#14154) * Fixes for escaping * Push a comment ot start PR again * Cache task is failing * Remove cache task * Not fixing so just put back cache task * remove leftovers * import pytest * stop skipping python tests Co-authored-by: Ian Huff <ianhu@microsoft.com> Co-authored-by: Ian Huff <ianhuff@CEIDCCEVIPSVC01.redmond.corp.microsoft.com> Co-authored-by: Rich Chiodo <rchiodo@users.noreply.github.com> Co-authored-by: Don Jayamanne <don.jayamanne@yahoo.com> Co-authored-by: Kartik Raj <karraj@microsoft.com> Co-authored-by: Karthik Nadig <kanadig@microsoft.com>
Configuration menu - View commit details
-
Copy full SHA for 5bc4eab - Browse repository at this point
Copy the full SHA 5bc4eabView commit details -
Configuration menu - View commit details
-
Copy full SHA for cc093b0 - Browse repository at this point
Copy the full SHA cc093b0View commit details
Commits on Oct 1, 2020
-
Windows store locator (#14162)
* Initial commit for windows store locator * More tests * Simplify locator * Tweaks * Test fixes * Fix tests
Configuration menu - View commit details
-
Copy full SHA for cfe12a7 - Browse repository at this point
Copy the full SHA cfe12a7View commit details -
A different way of fixing escaping (#14186)
* Move escaping to just output * Add some tests to verify round tripping * Fixup test for rountrip and make roundtripping actually work * Add news entry * Add to manual test file * Fix streaming problem and add more to the test * Fix traceback unit test * Fix problem caught by functional tests :) * Another functional test catch
Configuration menu - View commit details
-
Copy full SHA for afc155b - Browse repository at this point
Copy the full SHA afc155bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 146dae0 - Browse repository at this point
Copy the full SHA 146dae0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 716e61c - Browse repository at this point
Copy the full SHA 716e61cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a36df0 - Browse repository at this point
Copy the full SHA 0a36df0View commit details -
Bump pytest from 6.0.1 to 6.1.0 in /news (#14190)
Bumps [pytest](https://github.com/pytest-dev/pytest) from 6.0.1 to 6.1.0. - [Release notes](https://github.com/pytest-dev/pytest/releases) - [Changelog](https://github.com/pytest-dev/pytest/blob/master/CHANGELOG.rst) - [Commits](pytest-dev/pytest@6.0.1...6.1.0) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for a83c93d - Browse repository at this point
Copy the full SHA a83c93dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b392ca - Browse repository at this point
Copy the full SHA 7b392caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3164678 - Browse repository at this point
Copy the full SHA 3164678View commit details