Fix typos + minor doc tweaks #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbaeumer
previously approved these changes
May 17, 2022
aeschli
previously approved these changes
May 17, 2022
|
@dbaeumer I didn't re-gen the meta model json here as I wasn't sure if it was also being worked on in other branches (and would generate lots of conflicts), but let me know if I should. |
|
I can regenerate the meta model |
dbaeumer
approved these changes
May 19, 2022
|
@dbaeumer are you planning to merge this soon? It helps reduce the size of the review I'll be opening soon to switch from TS to JSON model :-) (if it helps, I can rebase and re-gen the model on this PR) |
aeschli
approved these changes
May 30, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly typos and tweaks I noticed when diffing code generated from parsing the TypeScript spec to the new meta model, but also some additional things I spotted along the way.
Some of the changes are quite trivial like trailing full stops.. I mostly added these where they existed in the LSP spec (in an attempt to reduce the size of my diff to help me review the TS -> meta model migration), I didn't try to fix these in all places.
@dbaeumer