-
Notifications
You must be signed in to change notification settings - Fork 327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing features in MetaModel #946
Comments
The following
|
@dbaeumer I created a PR for one of the issues above because it's one that's blocking me: If you've already started this, feel free to ditch it. The other issues are less important for me (although fixing the docs would be good, it would reduce my diff quite a lot - if it doesn't require a lot of knowledge about how the model is built, I could take a look at that too). Edit: I was curious so had a look at enum docs too -> #949 |
@KamasamaK thanks. I need to remove those form the meta model since they are error code implementation specific to vscode-jsonrpc. |
|
@dbaeumer not sure if here is a good place for questions like this, but in the meta model, "name": "range",
"type": {
"kind": "or",
"items": [
{
"kind": "base",
"name": "boolean"
},
{
"kind": "literal",
"value": {
"properties": []
}
}
]
},
"optional": true It's not clear what the literal here is intended to be (in the web spec, it's |
@DanTup no it is not LSP any. It is basically an object literal with no properties. We did this sine we expect properties to be added which is easier if a object literal is already specified. |
See #954 |
@dbaeumer {
"name": "experimental",
"type": {
"kind": "reference",
"name": "T"
},
"optional": true,
"documentation": "Experimental server capabilities."
} With a definition for {
"name": "T",
"properties": []
}, Is this intended? ( |
Done. Is now LSPAny. |
@dbaeumer great, thanks! FWIW the definition of |
Let me have a look then. |
Fixed here: #987 |
…o `bool option` specs: ```typescript /** * The client will send the `textDocument/semanticTokens/range` request * if the server provides a corresponding handler. */ range?: boolean | { }; /** * Server supports providing semantic tokens for a specific range * of a document. */ range?: boolean | { }; ``` Empty Object because: [[source](microsoft/vscode-languageserver-node#946 (comment))] > no it is not LSP any. It is basically an object literal with no properties. We did this sine we expect properties to be added which is easier if a object literal is already specified. -> `{}` not used -> omit `obj`
From microsoft/language-server-protocol#67 (comment)
TraceValue
has "compact" in meta model but not in published specNotebookDocumentSyncClientCapabilities
hasexecutionSummarySupport
in meta model but not in published specPrepareRenameParams
might be missingWorkDoneProgressParams
as a base in published spec? (it's in meta model)InitializeParams
extendsWorkspaceFoldersInitializeParams
which does not markworkspaceFolders
asoptional
(only nullable), but in the TS spec, it's both optional (?
) and nullable:workspaceFolders?: WorkspaceFolder[] | null;
CodeAction.disabled.reason
("Human readable description of why the code action is currently disabled.")completionItem.commitCharactersSupport
("Client supports commit characters on a completion item.")CompletionTriggerKind
("How a completion was triggered")CodeActionKind.Empty
,CodeActionTriggerKind.Automatic
)I opened #945 to address some of the typos and truncated docs (I don't believe it addresses any of the above though).
The text was updated successfully, but these errors were encountered: