Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't "restart" notebook debug session #7670

Closed
Tracked by #1652
roblourens opened this issue Sep 27, 2021 · 5 comments · Fixed by #11739
Closed
Tracked by #1652

Can't "restart" notebook debug session #7670

roblourens opened this issue Sep 27, 2021 · 5 comments · Fixed by #11739
Assignees
@roblourens
Labels
bug Issue identified by VS Code Team member as probable bug notebook-debugging on-testplan
Milestone
October 2022

Comments

@roblourens
Copy link
Member

  • Start debugging a cell
  • Click "restart"
  • Get an error about a missing debug adapter descriptor

Need to handle debugging being started this way too, not just through the command
@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug notebook-debugging labels Sep 27, 2021
@roblourens roblourens self-assigned this Sep 27, 2021
@roblourens roblourens added this to the September 2021 milestone Sep 27, 2021
@DavidKutu
Copy link

image
Is this it? this is the only error I get

@DavidKutu DavidKutu mentioned this issue Sep 27, 2021
Closed
19 tasks
@roblourens
Copy link
Member Author

That's not it - it will fail to start because it calls our debug adapter descriptor factory without doing the setup that we do when the command is run.

@greazer greazer removed this from the October 2021 milestone Oct 7, 2021
@DonJayamanne
Copy link
Contributor

Feels like a duplicate of #1289

@roblourens
Copy link
Member Author

Why wouldn't it be supported?

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Oct 21, 2021 •
edited
Loading

Its not supported today in Interactive window, hence I'm assuming its the same reason its not supported in run by line as well.
Either we fix it (which we haven't for over 2 years the bug has been around) or we notify users via a message.

I'm up for fixing it, thats better than some hacky warning about not supporting something (when it works in traditional Python).

I believe it was never fixed because it wasn't deemed important enough, no idea.

@roblourens roblourens mentioned this issue Aug 24, 2022
Closed
@roblourens roblourens added this to the September 2022 milestone Aug 24, 2022
@roblourens roblourens mentioned this issue Sep 26, 2022
Open
@kieferrm kieferrm mentioned this issue Oct 10, 2022
Closed
17 tasks
roblourens added a commit that referenced this issue Oct 14, 2022
@roblourens
Support debug "restart" #7670
362fe5f
@roblourens roblourens mentioned this issue Oct 14, 2022
Merged
roblourens added a commit that referenced this issue Oct 14, 2022
@roblourens
Support debug "restart" #7670
2feb642
roblourens added a commit that referenced this issue Oct 21, 2022
@roblourens
Implement restart (#11668)
251bcc7 
* Support debug "restart" #7670

* More debug refactoring, set up IW for restart

* Hook up Restart for rbl, via a custom Restart request implementation.
Move commands out of DebuggingManager, and expose methods on that class for use by the rbl controller

* Hook up restart for "debug cell"

* Clean up dumped cell files in disconnect, so it can be awaited

* Fix comments in controller

* formatting

* Fix PR comments

* Wait for debugger to be totally set up before executing cell in IW

* Add test for restarting debug.
Also fix the restart request handler to avoid cancelling the restart request on accident.
roblourens added a commit that referenced this issue Oct 21, 2022
@roblourens
Show error message when trying to restart an IW debug session
39722c2 
Fix #7670
@roblourens roblourens mentioned this issue Oct 21, 2022
Merged
roblourens added a commit that referenced this issue Oct 21, 2022
@roblourens
Show error message when trying to restart an IW debug session (#11739)
5c5f1a2 
Fix #7670
@roblourens roblourens mentioned this issue Oct 25, 2022
Closed
4 tasks
@kieferrm kieferrm mentioned this issue Nov 6, 2022
Closed
23 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
bug Issue identified by VS Code Team member as probable bug notebook-debugging on-testplan
Projects
None yet
Milestone
October 2022
Development

Successfully merging a pull request may close this issue.

Show error message when trying to restart an IW debug session microsoft/vscode-jupyter
4 participants
@roblourens @DonJayamanne @greazer @DavidKutu