Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run by line test is not stopping at end of cell #7611

Open
Tracked by #5607
rchiodo opened this issue Sep 21, 2021 · 4 comments
Open
Tracked by #5607

Run by line test is not stopping at end of cell #7611

rchiodo opened this issue Sep 21, 2021 · 4 comments
Assignees
Labels
debt Code quality issues flaky test Test that is intermittently failing notebook-run-by-line
Milestone

Comments

@rchiodo
Copy link
Contributor

rchiodo commented Sep 21, 2021

This test:

'Stops at end of cell'

is failing because run by line is running without stopping. After the first run by line command this happens:

image

This breaks the rest of the test.

@rchiodo rchiodo added the bug Issue identified by VS Code Team member as probable bug label Sep 21, 2021
@rchiodo
Copy link
Contributor Author

rchiodo commented Sep 21, 2021

Test should probably be rewritten to have second line change the value of A to verify it's stepping one line at a time.

@greazer greazer added notebook-run-by-line debt Code quality issues and removed needs-triage labels Sep 23, 2021
@amunger amunger added the flaky test Test that is intermittently failing label Aug 9, 2022
@amunger amunger self-assigned this Aug 9, 2022
@amunger
Copy link
Contributor

amunger commented Aug 9, 2022

Still one of our flakiest tests, but possibly a different issue. In failure cases, we can see in the logs a disconnect message is sent, but we no longer hear anything on the debug channel as it waits for 60 seconds:

2022-08-08T18:21:12.1770280Z info 18:21:12.125:  willSendRequest: disconnect
2022-08-08T18:21:12.1784097Z verbose 18:21:12.125:  [Debug] to kernel: {"command":"disconnect","arguments":{"restart":false},"type":"request","seq":40}
2022-08-08T18:21:12.1991226Z info 18:21:12.147:  �[32mWidget Coordinator received IPyWidgets_iopub_msg_handled
2022-08-08T18:21:12.1997064Z info 18:21:12.149:  �[32mWidget Coordinator received IPyWidgets_msg_received
2022-08-08T18:21:12.2001149Z info 18:21:12.160:  �[32mWidget Coordinator received IPyWidgets_msg_received
2022-08-08T18:21:12.2010255Z info 18:21:12.165:  �[32mWidget Coordinator received IPyWidgets_iopub_msg_handled
2022-08-08T18:21:12.2161233Z info 18:21:12.177:  Getting active debug session, emptyPython3299d122-8ea8-4fcb-9dda-e47f1a722c90..ipynb
2022-08-08T18:21:12.2165045Z info 18:21:12.177:  Getting active debug session, emptyPython3299d122-8ea8-4fcb-9dda-e47f1a722c90..ipynb
2022-08-08T18:21:12.3698778Z [3878:0808/182112.369305:ERROR:bus.cc(398)] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
2022-08-08T18:21:12.3714601Z [3878:0808/182112.371084:ERROR:bus.cc(398)] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
2022-08-08T18:22:11.9537515Z Test failing --- DebugSession should end

whereas successful runs will have a response indicating success

2022-08-08T18:20:27.7675780Z info 18:20:27.740:  willSendRequest: disconnect
2022-08-08T18:20:27.7676540Z verbose 18:20:27.740:  [Debug] to kernel: {"command":"disconnect","arguments":{"restart":false},"type":"request","seq":38}
2022-08-08T18:20:27.7718296Z info 18:20:27.744:  RawSession status changed to busy
2022-08-08T18:20:27.7718908Z info 18:20:27.744:  Server Status = busy
2022-08-08T18:20:27.7719684Z verbose 18:20:27.744:  IKernel Status change to busy
2022-08-08T18:20:27.7756869Z info 18:20:27.744:  Debug IO Pub message: {"header":{"msg_id":"eac18432-4d09823b5395a6cbb32cdd37_4790_171","msg_type":"status",...
2022-08-08T18:20:27.7789006Z info 18:20:27.745:  Debug IO Pub message: {"header":{"msg_id":"eac18432-4d09823b5395a6cbb32cdd37_4790_172","msg_type":"debug_event",...
2022-08-08T18:20:27.7793394Z verbose 18:20:27.745:  [Debug] event: {"header":{"msg_id":"eac18432-4d09823b5395a6cbb32cdd37_4790_172","msg_type":"debug_event",...
2022-08-08T18:20:27.7794853Z info 18:20:27.746:  Getting active debug session, emptyPython5df68b73-71c6-445a-9728-77af758824fd..ipynb
2022-08-08T18:20:27.7822046Z info 18:20:27.747:  �[32mWidget Coordinator sent IPyWidgets_msg
2022-08-08T18:20:27.7829570Z info 18:20:27.747:  �[32mPosting message to Notebook UI 
2022-08-08T18:20:27.7830837Z verbose 18:20:27.747:  [Debug] response: {"seq":65,"type":"response","request_seq":38,"success":true,"command":"disconnect"}

@roblourens
Copy link
Member

This is possibly what I filed on debugpy: microsoft/debugpy#1051

@roblourens
Copy link
Member

A restart issue got mixed up with flaky tests, that's why the iteration plan points at this item, but I think the root issue is that restart does not work right, so I'm fixing #7670 to fulfill this iteration plan item.

@roblourens roblourens added this to the February 2023 milestone Jan 25, 2023
@roblourens roblourens modified the milestones: February 2023, March 2023 Feb 21, 2023
@roblourens roblourens modified the milestones: March 2023, April 2023 Mar 21, 2023
@roblourens roblourens modified the milestones: April 2023, May 2023 Apr 26, 2023
@roblourens roblourens modified the milestones: May 2023, On Deck May 31, 2023
@DonJayamanne DonJayamanne removed the bug Issue identified by VS Code Team member as probable bug label Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Code quality issues flaky test Test that is intermittently failing notebook-run-by-line
Projects
None yet
Development

No branches or pull requests

6 participants