Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libsndfile] Update to 1.1.0 #23800

Merged
merged 8 commits into from
Apr 7, 2022
Merged

Conversation

evpobr
Copy link
Contributor

@evpobr evpobr commented Mar 27, 2022

  • Update to 1.1.0
  • Add mpeg and regtest features to sync with upstream.

* Update to 1.1.0
* Add `mpeg` and `regtest` features to sync with upstream.
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/libsndfile/portfile.cmake

@JonLiu1993 JonLiu1993 self-assigned this Mar 28, 2022
@JonLiu1993 JonLiu1993 added category:port-update The issue is with a library, which is requesting update new revision category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist labels Mar 28, 2022
@JonLiu1993
Copy link
Member

@evpobr ,Thanks for your pr, Looks the ci tested failed on many triplet,
This is error log, could you please take a look:
https://dev.azure.com/vcpkg/public/_build/results?buildId=69470&view=artifacts&pathAsName=false&type=publishedArtifacts

@evpobr
Copy link
Contributor Author

evpobr commented Apr 2, 2022

@JonLiu1993 , i guess it is bug in upstream, fixing libsndfile/libsndfile#821.

@JonLiu1993 JonLiu1993 added depends:upstream-changes Waiting on a change to the upstream project and removed requires:author-response labels Apr 2, 2022
@evpobr
Copy link
Contributor Author

evpobr commented Apr 3, 2022

@JonLiu1993 , fixed.

@JonLiu1993 JonLiu1993 added requires:author-response and removed depends:upstream-changes Waiting on a change to the upstream project requires:author-response labels Apr 6, 2022
@JonLiu1993
Copy link
Member

All features are tested successfully in the following triplet:

  • x86-windows
  • x64-windows
  • x64-windows-static

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Apr 7, 2022
@strega-nil-ms
Copy link
Contributor

Thanks so much!

@strega-nil-ms strega-nil-ms merged commit d0f5e56 into microsoft:master Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants