Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: automatically build libsndfile 1.1.0 on the CI with MP3 support #11

Merged
merged 21 commits into from
Sep 27, 2022

Conversation

bastibe
Copy link
Owner

@bastibe bastibe commented Apr 12, 2022

This pull request updates build scripts and dependencies to build version 1.1.0 of libsndfile.

Working:

  • macOS intel builds
  • Windows builds (32/64)

Workaround:

  • macOS arm builds provided by @faroit (not automated, since no arm runners available)

The windows builds rely on VCPKG to build libsndfile. VCPKG has been updated to libsndfile 1.1.0.

The macOS builder builds libsndfile on an Intel machine, and as far as I know, there aren't any macOS/arm runners available. Presumably, it should be possible to cross-compile arm binaries from an Intel machine, but I do not know how.

If you know how to cross-compile libsndfile and its dependencies from the macOS/Intel runners, please let me know! Providing a hand-built arm binary is also an option.

bastibe and others added 12 commits February 9, 2022 09:29
Build and upload Windows libs.
According to the libsndfile documentation, the function
sf_open_fd only works on Windows, if the libsndfile DLL
is linked against the same version of the Microsoft C
runtime DLL as python is. For Python 3.5+, this is Visual
Studio 14.x, which is what this commit provides.
this seems to correctly build mpg123 and liblame, but none of the
custom-built libraries are picked up by the libsndfile configure
script. Possibly due to changes in libsndfile's build scripts?
because 2016 is deprecated and no longer builds
These are the latest CI builds for libsndfile 1.1.0 with MP3 support
The default still seems to be 1.0.31
Maybe that will make libsndfile 1.1.0 available?
@faroit
Copy link
Contributor

faroit commented May 16, 2022

@bastibe i was trying to build a macOS arm build on my m1. I had to remove --enable-werror to make it compile (minor warning) but now it runs fine and I was able to built sndfile 1.1.0

file libsndfile.dylib
libsndfile.dylib: Mach-O 64-bit dynamically linked shared library arm64

let me know if this helps and how if you want me to upload the lib somewhere
Added in #12

@faroit
Copy link
Contributor

faroit commented Jul 11, 2022

@bastibe
Copy link
Owner Author

bastibe commented Jul 11, 2022

That looks promising! As far as I can tell, some people have managed to somehow get M1 runners working in the Github CI! To be honest, I don't fully understand how, though.

@bastibe bastibe merged commit 4bd2073 into master Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants