Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable ARM64X Builds by Default #14

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Disable ARM64X Builds by Default #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions vs/windows.undocked.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,10 @@
<UndockedOfficial Condition="'$(UndockedOfficial)' == ''">false</UndockedOfficial>
<UndockedUseDriverToolset Condition="'$(UndockedUseDriverToolset)' == ''">false</UndockedUseDriverToolset>
<UndockedKernelModeBuild>false</UndockedKernelModeBuild>
<!-- Disable ARM64X unless explicitly enabled -->
<UndockdedBuildArm64x Condition="'$(UndockdedBuildArm64x)' == '' OR $(ARM64X_DISABLED) == '1'">false</UndockdedBuildArm64x>
<!-- Use the official LKG complier when available -->
<UseInternalMSUniCrtPackage>true</UseInternalMSUniCrtPackage>
<!-- Enable ARM64X unless explicitly disabled -->
<EnableArm64x Condition="$(ARM64X_DISABLED) != '1'">true</EnableArm64x>
</PropertyGroup>
<!-- The set of supported user mode configurations (x86,x64,arm,arm64) -->
<ItemGroup Label="ProjectConfigurations" Condition="'$(UndockedType)' != 'sys'">
Expand Down Expand Up @@ -226,7 +226,7 @@
</Link>
</ItemDefinitionGroup>
<!-- Enable ARM64X compilation -->
<PropertyGroup Condition="'$(Platform)'=='ARM64' AND '$(UndockedType)' != 'sys' AND '$(UndockedType)' != 'drvlib' AND '$(UndockedType)' != 'exe' AND '$(EnableArm64x)' == 'true'">
<PropertyGroup Condition="'$(Platform)'=='ARM64' AND '$(UndockedType)' != 'sys' AND '$(UndockedType)' != 'drvlib' AND '$(UndockedType)' != 'exe' AND '$(UndockdedBuildArm64x)' == 'true'">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we get rid of the exclusion Conditions since this is now opt-in?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to leave them in for now. We can simplify later if we find they are unnecessary.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They're still needed to prevent targets that don't support ARM64X from being built that way.

<BuildAsX>true</BuildAsX>
</PropertyGroup>
<!-- Unofficial build flags, but close enough for local testing -->
Expand Down