Disable ARM64X Builds by Default #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nigriMSFT
reviewed
Jan 5, 2024
| @@ -226,7 +226,7 @@ | |||
| </Link> | |||
| </ItemDefinitionGroup> | |||
| <!-- Enable ARM64X compilation --> | |||
| <PropertyGroup Condition="'$(Platform)'=='ARM64' AND '$(UndockedType)' != 'sys' AND '$(UndockedType)' != 'drvlib' AND '$(UndockedType)' != 'exe' AND '$(EnableArm64x)' == 'true'"> | |||
| <PropertyGroup Condition="'$(Platform)'=='ARM64' AND '$(UndockedType)' != 'sys' AND '$(UndockedType)' != 'drvlib' AND '$(UndockedType)' != 'exe' AND '$(UndockdedBuildArm64x)' == 'true'"> | |||
There was a problem hiding this comment.
Should we get rid of the exclusion Conditions since this is now opt-in?
There was a problem hiding this comment.
I'd prefer to leave them in for now. We can simplify later if we find they are unnecessary.
There was a problem hiding this comment.
They're still needed to prevent targets that don't support ARM64X from being built that way.
nigriMSFT
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OneBranch seems to be having issues with ARM64X builds and generally most projects don't seem to need it, so let's disable it by default, and those projects who really need it can enable it.