Add property to control dropdown speed of global summon #9977

zadjii-msft · 2021-04-28T14:15:37Z

Summary of the Pull Request

Adds the dropdownDuration property to globalSummon. This controls how fast the window appears on the screen when summoned from minimized. It similarly controls the speed for sliding out of view when the window is dismissed with "toggleVisibility": true.

dropdownDuration specifies the duration in milliseconds. This defaults to 0 for globalSummon, and defaults to 200 for quakeMode. 200 was picked because, according to AnimateWindow:

Typically, an animation takes 200 milliseconds to play.

Do note that you won't be able to interact with the window during the animation! Input sent during the dropdown will arrive at the end of the animation, but input sent during the slide-up won't. Avoid setting this to large values!

The gifs are in Teams.

References

Original thread: Feature request: hot key drop down ala quake/guake/tilda #653
Spec: Spec for Quake Mode #9274
megathread: [MEGATHREAD] Quake Mode & Global Summon #8888

PR Checklist

Closes https://github.com/microsoft/terminal/projects/5#card-59030824
I work here
Tests added/passed
[n/a] Requires documentation to be updated

Detailed Description of the Pull Request / Additional comments

I had the following previously in the doc comments, but it feels better in the PR body:

This was chosen because it was easier to implement and generally nicer than:
- AnimateWindow, which would show the window borders for the duration of
  the animation, and occasionally just plain not work. Additionally, for
  AnimateWindow to work, the window much not be visible, so we'd need to
  first restore the window, then hide it, then animate it. That would flash
  the taskbar.
- SetWindowRgn on the root HWND, which caused the xaml content to shift to
  the left, and caused a black bar to be drawn on the right of the window.
  Presumably, SetWindowRgn and DwmExtendFrameIntoClientArea did not play
  well with each other.
- SetWindowPos(..., SWP_NOSENDCHANGING), which worked the absolute best for
  longer animations, and is the closest to the actual implementation of
  AnimateWindow. This would resize the ROOT window, without sending resizes
  to the XAML island, allowing the content to not reflow. but for a
  duration of 200ms, would only ever display ~2 frames. That's basically
  not even animation anymore, it's now just an "appear". Since that's how
  long the default animation is, if felt silly to have it basically not
  work by default.
If a future reader would like to implement this better, they should feel
free to, and not mistake my notes here as expertise. These are research
notes into the dark and terrible land that is Win32 programming. I'm no expert.

Validation Steps Performed

This is the blob of json I'm testing with these days:

        { "keys": "ctrl+`", "command": { "action": "quakeMode" } },
        { "keys": "ctrl+1", "command": { "action": "globalSummon" } },
        // { "keys": "ctrl+2", "command": { "action": "globalSummon", "desktop": "toCurrent" } },
        // { "keys": "ctrl+2", "command": { "action": "globalSummon", "toggleVisibility": false } },
        { "keys": "ctrl+2", "command": { "action": "globalSummon", "dropdownDuration": 2000 } },
        { "keys": "ctrl+3", "command": { "action": "globalSummon", "desktop": "onCurrent" } },
        { "keys": "ctrl+4", "command": { "action": "globalSummon", "desktop": "any" } },

ctrl+` will summon the quake window with a quick animation
ctrl+2 will summon the window with a s l o w animation

…ompile a String[]

…then back!

…!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

…safely tear it down. It _seems_ like it.

….dll

…galactic-empire

…ndow should be. It just always says 0 for now, but in the future it could actually give us useful info.

…/quake-toggleVisibility

…quake-dropdown-final

…opdown-final

carlos-zamora

You know what, the two "issues" I had are minor and can just be fixed in post if we even want it. At this point, you've implemented everything according to the agreed upon spec, and any small design changes can be done before/during v1.9. Good work :)

carlos-zamora · 2021-05-03T17:23:10Z

@zadjii-msft Is it time to update the docs/schema now? haha

…opdown-final

DHowett

Signing off with changes requested because you have to do a conflict resolution anyway. The WINDOWPLACEMENT one can cause really weird behavior in the future depending on how the compiler is feeling.

DHowett · 2021-05-17T02:43:31Z

src/cascadia/TerminalSettingsModel/ActionArgs.h

@@ -1045,10 +1045,12 @@ namespace winrt::Microsoft::Terminal::Settings::Model::implementation
        WINRT_PROPERTY(winrt::hstring, Name, L"");
        WINRT_PROPERTY(Model::DesktopBehavior, Desktop, Model::DesktopBehavior::ToCurrent);
        WINRT_PROPERTY(bool, ToggleVisibility, true);
+        WINRT_PROPERTY(uint32_t, DropdownDuration, 0);


it's always you three

lol

DHowett · 2021-05-17T02:44:08Z

src/cascadia/WindowsTerminal/AppHost.cpp

@@ -757,7 +758,7 @@ bool AppHost::_LazyLoadDesktopManager()
 void AppHost::_HandleSummon(const winrt::Windows::Foundation::IInspectable& /*sender*/,
                            const Remoting::SummonWindowBehavior& args)
 {
-    _window->SummonWindow(args.ToggleVisibility());
+    _window->SummonWindow(args.ToggleVisibility(), args.DropdownDuration());


Please do not make IslandWindow more specific to Terminal. I'd prefer it to be less specific to Terminal IMO 😄

src/cascadia/WindowsTerminal/IslandWindow.cpp

…opdown-final

…10092) #### ⚠️ this pr targets #9977 ## Summary of the Pull Request This adds support for part of the `monitor` property for `globalSummon`. It also goes a little off-spec: ```json "monitor": "any"|"toCurrent"|"toMouse" ``` * `monitor`: This controls the monitor that the window will be summoned from/to - `"any"`: Summon the MRU window, regardless of which monitor it's currently on. - `"toCurrent"`/omitted: (_default_): Summon the MRU window **TO** the monitor with the current **foreground** window. - [**NEW**] `"toMouse"`: Summon the MRU window **TO** the monitor where the **mouse** cursor is. When I was playing with this, It felt like `toMouse` was always what I wanted, not `toCurrent`. We can always just comment that out if we think that's contentious - I'm aware I didn't originally spec that. ## References * Original thread: #653 * Spec: #9274 * megathread: #8888 ## PR Checklist * [x] Closes https://github.com/microsoft/terminal/projects/5#card-60325291 * [x] I work here * [ ] Tests added/passed * [ ] Requires documentation to be updated 😢 ## Detailed Description of the Pull Request / Additional comments I made `toMouse` the default because it felt better. fite-me.jpg ## Validation Steps Performed my ever evolving blob: ```jsonc { "keys": "ctrl+`", "command": { "action": "quakeMode" } }, { "keys": "ctrl+1", "command": { "action": "globalSummon" } }, // { "keys": "ctrl+2", "command": { "action": "globalSummon", "desktop": "toCurrent" } }, // { "keys": "ctrl+2", "command": { "action": "globalSummon", "toggleVisibility": false } }, // { "keys": "ctrl+2", "command": { "action": "globalSummon", "dropdownDuration": 2000 } }, { "keys": "ctrl+2", "command": { "action": "globalSummon", "monitor": "any" } }, // { "keys": "ctrl+3", "command": { "action": "globalSummon", "desktop": "onCurrent" } }, { "keys": "ctrl+3", "command": { "action": "globalSummon", "monitor": "toMouse" } }, // { "keys": "ctrl+4", "command": { "action": "globalSummon", "desktop": "any" } }, { "keys": "ctrl+4", "command": { "action": "globalSummon", "monitor": "toMouse", "dropdownDuration": 500 } }, { "keys": "ctrl+5", "command": { "action": "globalSummon", "dropdownDuration": 500 } }, ```

ghost · 2021-05-25T19:11:42Z

🎉Windows Terminal Preview v1.9.1445.0 has been released which incorporates this pull request.:tada:

Handy links:

ghost · 2021-07-14T17:04:02Z

🎉Windows Terminal v1.9.1942.0 has been released which incorporates this pull request.:tada:

Handy links:

zadjii-msft added 30 commits December 16, 2020 07:59

Get all the projects created and hooked up to the sln

3bef7bb

Yank all the M/P files, this builds?!

1f52d35

Shockingly, this works, it works elevated, and it works unpackaged

5a9cdc8

This won't work, but I'm committing this becaus I finally got it to c…

36539cf

…ompile a String[]

whoop, we pass the commandline from the peasant, to the monarch, and …

27ace16

…then back!

HOLY SHIT I GOT THE COMANDLINE TO EXECUTE IN THE CURRENT WINDOW!!!!!!…

9a41647

…!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

add a note to future me

5cabcfb

This works as a unittest, but not a local test. That's batty

03bfc6e

this macro makes me feel dirty

590b9ff

LocalTests_Remoting -> UnitTests_Remoting

0579b24

finish renaming this test

a3faed6

Clean up a lot for review

9c6eac4

cleanup Peasant for review

0103331

Final cleanup for review

b4fe1bf

_final_ final cleanup for review

d08e65c

pr nits

e101efd

This seems to work to create a thread listening for the monarch, and …

e1402d8

…safely tear it down. It _seems_ like it.

it's hard to believe he's gone / were it so easy

f978a9c

Oh yea actually remove the thing

5939636

last commit before the holidays

c088895

Merge remote-tracking branch 'origin/main' into dev/migrie/f/remoting…

fa2df47

….dll

Enable audit mode

0f5c24f

nits

921d915

Merge branch 'dev/migrie/f/remoting.dll' into dev/migrie/f/the-first-…

00184e7

…galactic-empire

Ask the TerminalApp to parse the commandline, and tell us what the wi…

658db6b

…ndow should be. It just always says 0 for now, but in the future it could actually give us useful info.

Holy bajesus, this works like a charm

977db46

Add a note about commiting suicide

bcbef34

notes, comments, cleanup

813dbc6

activate windows

0f0df5e

add some tracelogging

9fc2f0e

zadjii-msft added 2 commits April 28, 2021 16:54

Merge branch 'dev/migrie/f/quake-toCurrent-desktop' into dev/migrie/f…

387d675

…/quake-toggleVisibility

Merge branch 'dev/migrie/f/quake-toggleVisibility' into dev/migrie/f/…

f190576

…quake-dropdown-final

DHowett force-pushed the dev/migrie/f/quake-toggleVisibility branch 2 times, most recently from 04752e5 to 1032dbb Compare April 28, 2021 22:26

Base automatically changed from dev/migrie/f/quake-toggleVisibility to main April 28, 2021 23:57

Merge remote-tracking branch 'origin/main' into dev/migrie/f/quake-dr…

960e1fa

…opdown-final

carlos-zamora assigned DHowett and cinnamon-msft Apr 30, 2021

carlos-zamora approved these changes May 3, 2021

View reviewed changes

Merge remote-tracking branch 'origin/main' into dev/migrie/f/quake-dr…

caeb17f

…opdown-final

zadjii-msft added the Needs-Second It's a PR that needs another sign-off label May 13, 2021

ghost requested review from miniksa, DHowett, leonMSFT, PankajBhojwani and lhecker May 13, 2021 14:58

zadjii-msft mentioned this pull request May 13, 2021

Add "monitor": "any"|"toCurrent"|"toMouse" setting to globalSummon #10092

Merged

4 tasks

zadjii-msft added the Area-Remoting Communication layer between windows. Often for windowing behavior, quake mode, etc. label May 14, 2021

DHowett approved these changes May 17, 2021

View reviewed changes

zadjii-msft added 2 commits May 17, 2021 06:41

Merge remote-tracking branch 'origin/main' into dev/migrie/f/quake-dr…

2d7ed8d

…opdown-final

Do the windowplacement thing

f4c9993

zadjii-msft merged commit 6e11780 into main May 17, 2021

zadjii-msft deleted the dev/migrie/f/quake-dropdown-final branch May 17, 2021 12:28

zadjii-msft mentioned this pull request Oct 18, 2021

Quake mode has rounded corners in Windows 11 #10534

Open

This was referenced Mar 1, 2023

Quake Mode: Open top/right corner of desktop #14924

Closed

Quake Mode reveal animation tears/flickers #12293

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add property to control dropdown speed of global summon #9977

Add property to control dropdown speed of global summon #9977

zadjii-msft commented Apr 28, 2021 •

edited

Loading

carlos-zamora left a comment

carlos-zamora commented May 3, 2021

DHowett left a comment

DHowett May 17, 2021

DHowett May 17, 2021

ghost commented May 25, 2021

ghost commented Jul 14, 2021

Add property to control dropdown speed of global summon #9977

Add property to control dropdown speed of global summon #9977

Conversation

zadjii-msft commented Apr 28, 2021 • edited Loading

Summary of the Pull Request

References

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

carlos-zamora left a comment

Choose a reason for hiding this comment

carlos-zamora commented May 3, 2021

DHowett left a comment

Choose a reason for hiding this comment

DHowett May 17, 2021

Choose a reason for hiding this comment

DHowett May 17, 2021

Choose a reason for hiding this comment

ghost commented May 25, 2021

ghost commented Jul 14, 2021

zadjii-msft commented Apr 28, 2021 •

edited

Loading