-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "monitor": "any"|"toCurrent"|"toMouse"
setting to globalSummon
#10092
Conversation
…ompile a String[]
…!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
…safely tear it down. It _seems_ like it.
…ndow should be. It just always says 0 for now, but in the future it could actually give us useful info.
…/quake-toggleVisibility
…quake-dropdown-final
This comment has been minimized.
This comment has been minimized.
Man I make one comment in bug bash and here it is! Nice! |
// Summon the window whenever we dispatch a commandline to it. This will | ||
// make it obvious when a new tab/pane is created in a window. | ||
_window->SummonWindow(false, 0); | ||
_window->SummonWindow(summonArgs); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i know i asked you not to but also I don't care that much 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sure you don't automerge the base! 😄
…tor-toCurrent-with-dropdown
Hello @zadjii-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
🎉 Handy links: |
Summary of the Pull Request
This adds support for part of the
monitor
property forglobalSummon
. It also goes a little off-spec:monitor
: This controls the monitor that the window will be summoned from/to"any"
: Summon the MRU window, regardless of which monitor it's currently on."toCurrent"
/omitted: (default): Summon the MRU window TO the monitor with the current foreground window."toMouse"
: Summon the MRU window TO the monitor where the mouse cursor is.When I was playing with this, It felt like
toMouse
was always what I wanted, nottoCurrent
. We can always just comment that out if we think that's contentious - I'm aware I didn't originally spec that.References
PR Checklist
Detailed Description of the Pull Request / Additional comments
I made
toMouse
the default because it felt better. fite-me.jpgValidation Steps Performed
my ever evolving blob: