Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing settings to Settings UI #8116

Merged
merged 4 commits into from
Oct 30, 2020

Conversation

carlos-zamora
Copy link
Member

Summary of the Pull Request

Since we've started working on the Settings UI, a few settings have been added on main. This adds those missing settings over.

References

Missing settings include...

Validation Steps Performed

Verified that those settings appear properly in the Settings UI.

@cinnamon-msft
Copy link
Contributor

Pics or it didn't happen

@carlos-zamora
Copy link
Member Author

Pics or it didn't happen

LaunchMode:
image

Bell style (under advanced):
image

Visual animations:
image

@cinnamon-msft
Copy link
Contributor

cinnamon-msft commented Oct 30, 2020

I'm wondering if the BEL setting should just be a checkbox? Unless we're planning to add additional styles?

@zadjii-msft
Copy link
Member

I'm wondering if the BEL setting should just be a checkbox? Unless we're planning to add additional styles?

Other things we've considered:

  • visual bells
  • providing the path you your own audio file to play as the BEL sound

@cinnamon-msft
Copy link
Contributor

I'm wondering if the BEL setting should just be a checkbox? Unless we're planning to add additional styles?

Other things we've considered:

  • visual bells
  • providing the path you your own audio file to play as the BEL sound

Ah okay, lgtm then :)

Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com>
@carlos-zamora carlos-zamora merged commit c0bca31 into feature/settings-ui Oct 30, 2020
@carlos-zamora carlos-zamora deleted the dev/cazamor/sui/missing-settings branch October 30, 2020 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants