-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing settings to Settings UI #8116
Add missing settings to Settings UI #8116
Conversation
Pics or it didn't happen |
I'm wondering if the BEL setting should just be a checkbox? Unless we're planning to add additional styles? |
Other things we've considered:
|
Ah okay, lgtm then :) |
src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw
Outdated
Show resolved
Hide resolved
Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com>
Summary of the Pull Request
Since we've started working on the Settings UI, a few settings have been added on
main
. This adds those missing settings over.References
Missing settings include...
disableAnimations
launchMode
focus
andmaximizedFocus
bellStyle
Validation Steps Performed
Verified that those settings appear properly in the Settings UI.