Apply Enum Mappings to most enum settings #8090
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DHowett
reviewed
Oct 29, 2020
Comment on lines
+81
to
+114
| auto entry = winrt::make<EnumEntry>(enumName, winrt::box_value<TextAntialiasingMode>(value)); | ||
| _AntialiasingModes.Append(entry); | ||
|
|
||
| // Initialize the selected item to be our current setting | ||
| if (value == Profile().AntialiasingMode()) | ||
| { | ||
| AntialiasingModeButtons().SelectedItem(entry); | ||
| } | ||
| } | ||
|
|
||
| auto closeOnExitModesMap = EnumMappings::CloseOnExit(); | ||
| for (auto [key, value] : closeOnExitModesMap) | ||
| { | ||
| auto enumName = LocalizedNameForEnumName(L"Profile_CloseOnExit", key, L"Content"); | ||
| auto entry = winrt::make<EnumEntry>(enumName, winrt::box_value<CloseOnExitMode>(value)); | ||
| _CloseOnExitModes.Append(entry); | ||
|
|
||
| // Initialize the selected item to be our current setting | ||
| if (value == Profile().CloseOnExit()) | ||
| { | ||
| CloseOnExitModeButtons().SelectedItem(entry); | ||
| } | ||
| } | ||
|
|
||
| auto bellStyleMap = EnumMappings::BellStyle(); | ||
| for (auto [key, value] : bellStyleMap) | ||
| { | ||
| auto enumName = LocalizedNameForEnumName(L"Profile_BellStyle", key, L"Content"); | ||
| auto entry = winrt::make<EnumEntry>(enumName, winrt::box_value<BellStyle>(value)); | ||
| _BellStyles.Append(entry); | ||
|
|
||
| // Initialize the selected item to be our current setting | ||
| if (value == Profile().BellStyle()) | ||
| { |
DHowett
reviewed
Oct 29, 2020
| @@ -251,7 +251,8 @@ | |||
| <value>Launch size</value> | |||
| </data> | |||
| <data name="Globals_LaunchSize.[using:Windows.UI.Xaml.Controls]ToolTipService.ToolTip" xml:space="preserve"> | |||
| <value>Defines whether the terminal will launch in a window, maximized, or full screen.</value> | |||
| <value>Defines whether the terminal will launch as maximized, full screen, or in a window. Setting this to "Focus" is equivalent to launching the terminal in the "Default" mode, but with the focus mode enabled. Similar, setting this to "MaximizedFocus" will result in launching the terminal in a maximized window with the focus mode enabled.</value> | |||
There was a problem hiding this comment.
THE LOC FREEZE WAS THREE WEEKS AGO COME ON LOL
There was a problem hiding this comment.
also, the wording is wrong. Maximized Focus should be two words.
I don't think we're doing it right if we just copy the entire json schema field description into a freakin' tooltip, but it's what we've got today.
There was a problem hiding this comment.
My bad. #7873 went in and I had no clue. I'll pull all the resw changes into a separate PR to get enough time for localization.
There was a problem hiding this comment.
Moved all the localization stuff over to #8116. Removing this stuff from this PR.
|
I'm actually going to close this PR.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Builds off of #8086 to introduce enum mappings for most of the remaining enum settings. This excludes the following two settings:
This also removes "Globals" files, a relic from the hackathon. We decided to split this up into all the other pages, and forgot to remove this at some point.
References
#1564 - Settings UI Epic
Validation Steps Performed
These become validated when we load the page with setting on it. Since there's a known issue right now that we can't load every available page (yet), I've only been able to validate that this works on the loadable pages.
If a setting was added, but we didn't update the resw properly, we get an error at runtime. So this helps a ton with debugging!