Remove a heap of legacy settings deserialization #5190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zadjii-msft
approved these changes
Mar 31, 2020
ghost
added
Needs-Author-Feedback
carlos-zamora
approved these changes
Mar 31, 2020
DHowett-MSFT
changed the title
|
🎉 Handy links: |
This was referenced Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes support for:
colorScheme.colors, as an arrayglobalsobject in the root of the settings fileprofile.colorTableandprofile.colorscheme(the rare v0.1 all-lowercase variety)c637a67 - Settings: delete all legacy keybinding deserializers
fc0d22e - Settings: remove support for colorScheme.colors (array)
e3bc5a9 - Settings: remove legacy colorscheme key and colorTable
bba1d65 - Settings: Remove support for /globals
Fixes #4091.
Fixes #1069.