Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deserialization of legacy json keys #1069

Closed
zadjii-msft opened this issue May 30, 2019 · 4 comments · Fixed by #5190
Closed

Remove deserialization of legacy json keys #1069

zadjii-msft opened this issue May 30, 2019 · 4 comments · Fixed by #5190
Assignees
@DHowett-MSFT
Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Area-Settings Issues related to settings and customizability, for console or terminal Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.0

Comments

@zadjii-msft
Copy link
Member

zadjii-msft commented May 30, 2019 •
edited by DHowett-MSFT
Loading

I'm thinking primarily of:
@zadjii-msft zadjii-msft added Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. labels May 30, 2019
@zadjii-msft zadjii-msft added this to the Terminal v1.0 milestone May 30, 2019
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label May 30, 2019
@DHowett-MSFT DHowett-MSFT added Area-Settings Issues related to settings and customizability, for console or terminal and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels May 30, 2019
@zadjii-msft zadjii-msft self-assigned this Aug 22, 2019
@bitcrazed
Copy link
Contributor

No longer required.

@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Sep 24, 2019
@zadjii-msft
Copy link
Member Author

Hey so I'm re-activating this to make sure we pull the old keybindings that we're not going to support in >=1.0. These were changed in #3391

@zadjii-msft zadjii-msft reopened this Nov 11, 2019
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Nov 11, 2019
@DHowett-MSFT DHowett-MSFT mentioned this issue Dec 31, 2019
Closed
DHowett-MSFT pushed a commit that referenced this issue Jan 30, 2020
@DHowett
Settings: Remove support for /globals
f6cc792 
Refs #1069.
DHowett-MSFT pushed a commit that referenced this issue Jan 30, 2020
@DHowett
Settings: Stop resurrecting dead roaming profiles
46aae81 
Fixes #3291.
Refs #1069.
DHowett-MSFT pushed a commit that referenced this issue Jan 30, 2020
@DHowett
Settings: remove legacy colorscheme key and colorTable
1b45119 
Fixes #4091.
Refs #1069.
DHowett-MSFT pushed a commit that referenced this issue Jan 30, 2020
@DHowett
Settings: remove support for colorScheme.colors (array)
f0bc152 
Refs #1069.
@DHowett-MSFT DHowett-MSFT self-assigned this Jan 30, 2020
@DHowett-MSFT
Copy link
Contributor

I've begun work on a bunch of facets of this (i guess as indicated by the commits above!)

DHowett-MSFT pushed a commit that referenced this issue Mar 30, 2020
@DHowett
Settings: Remove support for /globals
bba1d65 
Refs #1069.
DHowett-MSFT pushed a commit that referenced this issue Mar 30, 2020
@DHowett
Settings: Stop resurrecting dead roaming profiles
1be9feb 
Fixes #3291.
Refs #1069.
DHowett-MSFT pushed a commit that referenced this issue Mar 30, 2020
@DHowett
Settings: remove legacy colorscheme key and colorTable
e3bc5a9 
Fixes #4091.
Refs #1069.
DHowett-MSFT pushed a commit that referenced this issue Mar 30, 2020
@DHowett
Settings: remove support for colorScheme.colors (array)
fc0d22e 
Refs #1069.
DHowett-MSFT pushed a commit that referenced this issue Mar 30, 2020
@DHowett
Settings: delete all legacy keybinding deserializers
1d224bb 
Fixes #1069.
DHowett-MSFT pushed a commit that referenced this issue Mar 30, 2020
@DHowett
Settings: delete all legacy keybinding deserializers
c637a67 
Fixes #1069.
DHowett-MSFT pushed a commit that referenced this issue Mar 30, 2020
@DHowett
Settings: remove legacy colorscheme key and colorTable
4a25554 
Fixes #4091.
Refs #1069.
DHowett-MSFT pushed a commit that referenced this issue Mar 30, 2020
@DHowett
Settings: remove support for colorScheme.colors (array)
deef5e4 
Refs #1069.
DHowett-MSFT pushed a commit that referenced this issue Mar 30, 2020
@DHowett
Settings: delete all legacy keybinding deserializers
735c1f6 
Fixes #1069.
@DHowett-MSFT DHowett-MSFT mentioned this issue Mar 30, 2020
Merged
@ghost ghost added the In-PR This issue has a related PR label Mar 30, 2020
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label Mar 31, 2020
DHowett-MSFT pushed a commit that referenced this issue Mar 31, 2020
@DHowett
Remove a heap of legacy settings deserialization (#5190)
cd9e854 
This commit removes support for:

* legacy keybindings of all types
* `colorScheme.colors`, as an array
* A `globals` object in the root of the settings file
* `profile.colorTable` and `profile.colorscheme` (the rare v0.1 all-lowercase variety)

Fixes #4091.
Fixes #1069.
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Mar 31, 2020
DHowett-MSFT pushed a commit that referenced this issue Mar 31, 2020
@DHowett
Settings: Stop resurrecting dead roaming profiles
961793f 
Fixes #3291.
Refs #1069.
@ghost
Copy link

ghost commented Apr 22, 2020

🎉This issue was addressed in #5190, which has now been successfully released as Windows Terminal Preview v0.11.1121.0.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DHowett-MSFT DHowett-MSFT

Labels
Area-CodeHealth Issues related to code cleanliness, linting, rules, warnings, errors, static analysis, etc. Area-Settings Issues related to settings and customizability, for console or terminal Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.0
Development

Successfully merging a pull request may close this issue.

Remove a heap of legacy settings deserialization microsoft/terminal
4 participants
@bitcrazed @DHowett-MSFT @zadjii-msft @cinnamon-msft