Collect all known PowerShell Core installations for dynamic profiles

[DHowett-MSFT]

This pull request teaches the PowerShell Core generator about a bunch of different locations in which it might find a PowerShell.

These instances will be sorted, a leader will be elected, and that leader will be promoted and given the vaunted title of "PowerShell".

Names will be generated for the rest.

The sort order is documented in the comments, but that comment will be replicated here:

// <-- Less Valued .................................... More Valued -->
// |                 All instances of PS 6                 | All PS7  |
// |          Preview          |          Stable           | ~~~      |
// |  Non-Native | Native      |  Non-Native | Native      | ~~~      |
// | Trd  | Pack | Trd  | Pack | Trd  | Pack | Trd  | Pack | ~~~      |
// (where Pack is a stand-in for store, scoop, dotnet, though they have their own orders,
// and Trd is a stand-in for "Traditional" (Program Files))

Closes #2300

[DHowett-MSFT]

I'm fixing the guid to the legacy pscore guid so that users who have it set as their default profiles will not be disappointed. I'm fixing the name to PowerShell because otherwise we would hardcode a versioned name in profiles.json and then when that version moved on we wouldn't be able to override the name!

[DHowett-MSFT]

scoop, dotnet global, x86, ARM and msix are not localizable.

"Preview" - we need to discuss that.

[DHowett-MSFT]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[ejsmith]

"Preview" - we need to discuss that.

Yes, please discover and setup any preview releases I have installed.

[DHowett-MSFT]

@ejsmith oh absolutely! This is about whether the word preview is localizable. Sorry, that context was from the previous sentence and fairly sparse. :)

[miniksa]

Looks good. My comments are not high importance.

[DHowett-MSFT]

Here's a question: should 7 preview actually fall below 6 GA? Or should we always prefer the higher version numbered one

[zadjii-msft]

I think I only have nits, but I might want to see how the discussion plays out before I sign off. Or Carlos could sign off too, I don't really care

[zadjii-msft]

I mean I get it, but this should probably be in the cpp

[zadjii-msft]

Seems fine to me - I'll leave the merge to you to re-run CI, maybe push a commit, idc.

[miniksa]

Here's a question: should 7 preview actually fall below 6 GA? Or should we always prefer the higher version numbered one

No, in my opinion. If you're the kind of person to install previews, you want the leading edge version number even if it's not ready yet. And if you're a person who wants 6 GA as your default... you could just... not install the previews. Or make some of your own profiles.

[ghost]

Hello @DHowett-MSFT!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[ghost]

🎉Windows Terminal Preview v0.9.433.0 has been released which incorporates this pull request.:tada:

Handy links:

• Release Notes
• Store Download

[bys1123]

Maybe should add powershell core 7 stable profile now?

[DHowett-MSFT]

@bys1123 that’s the point, it is automatic.

[bys1123]

@DHowett-MSFT Thanks for explains. But, powershell core 7 stable didn't show up on my Terminal list. Is Windows Terminal Preview v0.9.433.0 included this PR?

[DHowett-MSFT]

Yes. Can you share a copy of your profiles.json?

[bys1123]

Here you are:

// To view the default settings, hold "alt" while clicking on the "Settings" button.
// For documentation on these settings, see: https://aka.ms/terminal-documentation

{
    "$schema": "https://aka.ms/terminal-profiles-schema",

    "defaultProfile": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",

    "profiles":
    {
        "defaults":
        {
            // Put settings here that you want to apply to all profiles
        },
        "list":
        [
            {
                // Make changes here to the powershell.exe profile
                "guid": "{61c54bbd-c2c6-5271-96e7-009a87ff44bf}",
                "name": "Windows PowerShell",
                "commandline": "powershell.exe",
                "hidden": false
            },
            {
                // Make changes here to the cmd.exe profile
                "guid": "{0caa0dad-35be-5f56-a8ff-afceeeaa6101}",
                "name": "cmd",
                "commandline": "cmd.exe",
                "hidden": false
            },
            {
                "guid": "{c6eaf9f4-32a7-5fdc-b5cf-066e8a4b1e40}",
                "hidden": false,
                "name": "Ubuntu-18.04",
                "source": "Windows.Terminal.Wsl"
            },
            {
                "guid": "{b453ae62-4e3d-5e58-b989-0a998ec441b8}",
                "hidden": false,
                "name": "Azure Cloud Shell",
                "source": "Windows.Terminal.Azure"
            }
        ]
    },

    // Add custom color schemes to this array
    "schemes": [],

    // Add any keybinding overrides to this array.
    // To unbind a default keybinding, set the command to "unbound"
    "keybindings": []
}

[DHowett-MSFT]

And where did you install powershell core 7?

[bys1123]

E:\Program Files\PowerShell\7

[DHowett-MSFT]

Sorry, Terminal only checks normal places. It uses your system’s official “Program Files” directory to determine where to look.

Anybody installing autodetectable shells to weird locations will need to make their own profiles for them.

[bys1123]

But vscode detect it automatically.

[Krantz-XRF]

@bys1123 I have a workaround for this: make a symlink from where you installed PowerShell to C:\Program Files\PowerShell and let Windows Terminal regenerate the profile.