Add additional PowerShell Core paths (preview, scoop, etc.) to dynamic profile generator #2300

MaximoTrinidad · 2019-08-06T19:58:17Z

depends on #754

Description of the new feature/enhancement

To include PowerShell 7 Preview.2 in the list of consoles if is already installed in the system.

I got both PowerShell Core GA and Preview installed for some time. And, the last few updates of Windows Terminal, is not automatically showing in the console list.

DHowett-MSFT · 2019-08-08T00:36:01Z

We should handle this as part of a powershell core dynamic profile generator!

DHowett-MSFT · 2019-08-08T00:36:18Z

Therefore, I am converting this issue to be the master task for "Switch PSCore to a dynamic profile generator".

DHowett-MSFT · 2019-09-19T16:52:56Z

@zadjii-msft - thoughts:

Should this stay open? If so:
- Move out from 1909
- Make it generate a bunch of different PSCore profiles
- Add support for scoop?
- integrate the preview icon, detect preview versions
- make pscore {latest} the default version

zadjii-msft · 2019-09-19T18:12:29Z

Eh, yea this should probably be re-purposed for those things.

Frankly I don't know enough about PSCore to implement preview, scoop, etc. support myself, but I'm sure that an enterprising community member could always update the PowershellCoreProfileGenerator if they wanted to add additional search locations 😜

DHowett-MSFT · 2019-09-24T06:19:21Z

I'm taking a crack at this!

DHowett-MSFT · 2019-09-24T06:20:39Z

The "latest good" (determined by a sorting algorithm ;P) one gets the legacy "Powershell Core" GUID :)

        // Total sort order:
        // 6-preview (wow) < 6-preview (native) < 7-preview (native) < 6 (wow) < 6 (native) < 7 (native)
        uint8_t Radix() const
        {
            return (preview ? 0b00000000 : 0b10000000) | ((majorVersion - 6) << 4) | (nativeArchitecture ? 0b1000 : 0x0000);
        }

DHowett-MSFT · 2019-09-24T15:52:34Z

@SteveL-MSFT quick questions I wanted to run by you, all related to powershell branding.

When we're generating automatic profiles for Powershell instances:

Should we include any version numbers past the first? (6, 6.2, 6.2.3)
Should we use the casing PowerShell or Powershell?
Should we use the name PowerShell or PowerShell Core?
- I've implemented it as follows:
  - 6.x = "PowerShell Core"
  - 7+ = "PowerShell"
Is it safe for us to assume that assets\ will always be present in the powershell distribution directory?
If the user has installed pwsh as a dotnet global tool, should we prefer that over or under the Program Files one?

Right now, my total global sort order is this:

7 (x64/arm64 native)
6 (x64/arm64 native)
6 (x86)
7-preview (x64/arm64 native)
6-preview (x64/arm64 native)
6-preview (x86)

I'm not sure where to slot "program files", "dotnet global" and "windows store" to the sort order. 😄

shanselman · 2019-09-30T18:47:53Z

@DHowett-MSFT Casing is "PowerShell" always. I wouldn't show version numbers. You're saying "Core" is dropped after 7 is released? I'd prefer the pwsh.exe that is first in the path.

SteveL-MSFT · 2019-10-02T18:14:35Z

From a branding perspective, I would suggest differentiating:

PowerShell Core 6.1
PowerShell Core 6.2
PowerShell 7
PowerShell 7-Preview

(6.0 is out of support already)

I don't think 6.x-Preview is needed since we have stable releases of those and no more previews for 6.x ever.

…4273) This pull request teaches the PowerShell Core generator about a bunch of different locations in which it might find a PowerShell. These instances will be sorted, a leader will be elected, and that leader will be promoted and given the vaunted title of "PowerShell". Names will be generated for the rest. The sort order is documented in the comments, but that comment will be replicated here: ``` // <-- Less Valued .................................... More Valued --> // | All instances of PS 6 | All PS7 | // | Preview | Stable | ~~~ | // | Non-Native | Native | Non-Native | Native | ~~~ | // | Trd | Pack | Trd | Pack | Trd | Pack | Trd | Pack | ~~~ | // (where Pack is a stand-in for store, scoop, dotnet, though they have their own orders, // and Trd is a stand-in for "Traditional" (Program Files)) ``` Closes #2300

davidfowl · 2020-01-31T11:32:14Z

After doing this it doesn't appear in the list of profiles... Am I missing something?

DHowett-MSFT · 2020-01-31T16:03:03Z

Unless you’re running the latest internal-to-microsoft build that was released last night around midnight, you’re missing a version of Windows Terminal that actually has this feature in it 😅

DHowett-MSFT · 2020-01-31T16:04:00Z

(If you aren’t: check the store for updates, then hit me back!)

MaximoTrinidad · 2020-02-01T20:37:08Z

Windows Terminal version 0.8.10261.0

My dilemma has been that I want to use Windows Terminal with both PowerShell GA and Preview versions. But it seems that I can't, as it only pick one of the installed version.

If I remove the GA version, then it grabs the Preview:

DHowett-MSFT · 2020-02-01T20:48:45Z

Well yes, again, this is because you’re using a released version of Terminal that predates this feature being added and this bug being closed. That is how we handle all bugs in this repository: they are closed when the code change is made, and an announcement is posted when a release is available that contains the change.

MaximoTrinidad · 2020-02-01T20:52:41Z

Thank You All for your hard work! I love Windows Terminal.

ghost · 2020-02-13T18:03:32Z

🎉This issue was addressed in #4273, which has now been successfully released as Windows Terminal Preview v0.9.433.0.:tada:

Handy links:

MaximoTrinidad added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Aug 6, 2019

ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Aug 6, 2019

DHowett-MSFT changed the title ~~Feature Request to include PowerShell Preview in the list of consoles.~~ Switch PowerShell Core to a dynamic profile generator Aug 8, 2019

ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Aug 8, 2019

DHowett-MSFT added Needs-Tag-Fix Doesn't match tag requirements and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Aug 8, 2019

ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Aug 8, 2019

zadjii-msft self-assigned this Aug 22, 2019

zadjii-msft added this to the Terminal 1909 milestone Aug 22, 2019

zadjii-msft removed their assignment Sep 19, 2019

zadjii-msft modified the milestones: Terminal-1909, Terminal Backlog Sep 19, 2019

zadjii-msft added the Help Wanted We encourage anyone to jump in on these. label Sep 19, 2019

zadjii-msft changed the title ~~Switch PowerShell Core to a dynamic profile generator~~ Add additional PowerShell Core paths (preview, scoop, etc.) to dynamic profile generator Sep 19, 2019

zadjii-msft assigned DHowett-MSFT Sep 24, 2019

DHowett-MSFT removed the Help Wanted We encourage anyone to jump in on these. label Sep 24, 2019

zadjii-msft mentioned this issue Sep 24, 2019

Feature Request: Support the new cross-platform PowerShell #2868

Closed

DHowett-MSFT mentioned this issue Sep 30, 2019

Windows Terminal does not create a Profile for PowerShell Core when install via MSIX or Global Tool #2982

Closed

DHowett-MSFT mentioned this issue Oct 6, 2019

Pwsh not found if installed as .NET Core global tool #3096

Closed

DHowett-MSFT mentioned this issue Oct 17, 2019

Azure Cloud Shell is readded to the profiles.json file after I remove it and restart terminal. #3231

Closed

billwert mentioned this issue Dec 2, 2019

Bug Report: defaultProfile in profiles.json is ignored #2893

Closed

DHowett-MSFT mentioned this issue Jan 17, 2020

Collect all known PowerShell Core installations for dynamic profiles #4273

Merged

ghost added the In-PR This issue has a related PR label Jan 17, 2020

ghost closed this as completed in #4273 Jan 31, 2020

ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Jan 31, 2020

This issue was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add additional PowerShell Core paths (preview, scoop, etc.) to dynamic profile generator #2300

Add additional PowerShell Core paths (preview, scoop, etc.) to dynamic profile generator #2300

MaximoTrinidad commented Aug 6, 2019 •

edited by DHowett-MSFT

Loading

DHowett-MSFT commented Aug 8, 2019

DHowett-MSFT commented Aug 8, 2019

DHowett-MSFT commented Sep 19, 2019

zadjii-msft commented Sep 19, 2019

DHowett-MSFT commented Sep 24, 2019

DHowett-MSFT commented Sep 24, 2019

DHowett-MSFT commented Sep 24, 2019

shanselman commented Sep 30, 2019

SteveL-MSFT commented Oct 2, 2019

davidfowl commented Jan 31, 2020

DHowett-MSFT commented Jan 31, 2020

DHowett-MSFT commented Jan 31, 2020

MaximoTrinidad commented Feb 1, 2020

DHowett-MSFT commented Feb 1, 2020

MaximoTrinidad commented Feb 1, 2020

ghost commented Feb 13, 2020

Add additional PowerShell Core paths (preview, scoop, etc.) to dynamic profile generator #2300

Add additional PowerShell Core paths (preview, scoop, etc.) to dynamic profile generator #2300

Comments

MaximoTrinidad commented Aug 6, 2019 • edited by DHowett-MSFT Loading

Description of the new feature/enhancement

DHowett-MSFT commented Aug 8, 2019

DHowett-MSFT commented Aug 8, 2019

DHowett-MSFT commented Sep 19, 2019

zadjii-msft commented Sep 19, 2019

DHowett-MSFT commented Sep 24, 2019

DHowett-MSFT commented Sep 24, 2019

DHowett-MSFT commented Sep 24, 2019

shanselman commented Sep 30, 2019

SteveL-MSFT commented Oct 2, 2019

davidfowl commented Jan 31, 2020

DHowett-MSFT commented Jan 31, 2020

DHowett-MSFT commented Jan 31, 2020

MaximoTrinidad commented Feb 1, 2020

DHowett-MSFT commented Feb 1, 2020

MaximoTrinidad commented Feb 1, 2020

ghost commented Feb 13, 2020

MaximoTrinidad commented Aug 6, 2019 •

edited by DHowett-MSFT

Loading