Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the setting "confirmCloseAllTabs" to SUI #14419

Merged
2 commits merged into from
Nov 21, 2022
Merged

Add the setting "confirmCloseAllTabs" to SUI #14419

2 commits merged into from
Nov 21, 2022

Conversation

leejy12
Copy link
Contributor

@leejy12 leejy12 commented Nov 21, 2022 •
edited by zadjii-msft
Loading

This commit adds the setting "confirmCloseAllTabs" to SUI.
The setting was added to the Interactions pane of Global Settings.

Closes #14413
Closes #14033

@ghost ghost added Area-SettingsUI Anything specific to the SUI Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels Nov 21, 2022
@leejy12
Copy link
Contributor Author

leejy12 commented Nov 21, 2022

I think a better Header for the settings container is needed. Maybe a HelpText also.

@carlos-zamora
Copy link
Member

FYI to reviewer, here's what it looks like:
Toggle switch displaying "Confirm close all tabs"

carlos-zamora
carlos-zamora approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified this works with screen readers.

Long-term, we need...

  1. "don't show this again" checkboxes on the warning dialogs. When checked, we suppress the dialog and save the selection to state.json.
  2. Migration (aka legacy support): if user has any warning settings set in settings.json, update state.json appropriately.
  3. SUI updates:
    • add a UI for each warning so that the user can reset it.
    • add a "reset all warnings" button?

I'm saying all of this because adding these warnings to the SUI in the meantime shouldn't conflict with any of it. At the end of the day, if 1 and 2 is done, we just update the view model in SUI to update state.json instead of settings.json.

tl;dr: Thanks for doing this :). If you want to add all of the other warnings, go for it. Should be pretty much the same.

src/cascadia/TerminalSettingsEditor/Resources/en-US/Resources.resw Outdated Show resolved Hide resolved
@zadjii-msft
Copy link
Member

FWIW, Carlos's comment is largely musing and not indicative of work that NEEDS to be done in this PR. Small, incremental changes are always easier to review and ingest.

See also #6641

@ghost ghost added the Area-UserInterface Issues pertaining to the user interface of the Console or Terminal label Nov 21, 2022
@zadjii-msft zadjii-msft mentioned this pull request Nov 21, 2022
Closed
@carlos-zamora
Copy link
Member

FWIW, Carlos's comment is largely musing and not indicative of work that NEEDS to be done in this PR. Small, incremental changes are always easier to review and ingest.

See also #6641

Sorry! Yes! Should've made that more clear haha. Just trying to be encouraging and give you (or anybody else) the direction we're thinking of going as a whole.

@carlos-zamora carlos-zamora added the AutoMerge Marked for automatic merge by the bot when requirements are met label Nov 21, 2022
@ghost
Copy link

ghost commented Nov 21, 2022

Hello @carlos-zamora!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 437b5ac into microsoft:main Nov 21, 2022
@leejy12 leejy12 deleted the jyl/confirm-close-all-tabs branch November 22, 2022 04:32
@DHowett
Copy link
Member

DHowett commented Nov 22, 2022 •
edited
Loading

For clarity this might be better stated as, "Confirm when closing more than one tab". We cannot always translate the JSON names directly to sentences 😄

EDIT: or even, "Prompt for confirmation before closing more than one tab"?

@DHowett DHowett mentioned this pull request Nov 23, 2022
Closed
DHowett pushed a commit that referenced this pull request Dec 12, 2022
@leejy12 @DHowett
Add the setting "confirmCloseAllTabs" to SUI (#14419)
b73718a 
This commit adds the setting "confirmCloseAllTabs" to SUI.
The setting was added to the Interactions pane of Global Settings.

Closes #14413
Closes #14033

(cherry picked from commit 437b5ac)
Service-Card-Id: 87207138
Service-Version: 1.16
@ghost
Copy link

ghost commented Dec 14, 2022

🎉Windows Terminal Preview v1.16.3463.0 and v1.16.3464.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Dec 14, 2022
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@lhecker lhecker lhecker approved these changes

Assignees
No one assigned
Labels
Area-SettingsUI Anything specific to the SUI Area-UserInterface Issues pertaining to the user interface of the Console or Terminal AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
5 participants
@leejy12 @carlos-zamora @zadjii-msft @DHowett @lhecker