Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a "remember my decision" checkbox to our confirmation dialogs #6641

Open
Chips1234 opened this issue Jun 23, 2020 · 5 comments
Open

Add a "remember my decision" checkbox to our confirmation dialogs #6641

Chips1234 opened this issue Jun 23, 2020 · 5 comments
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Priority-2 A description (P2) Product-Terminal The new Windows Terminal.
Milestone
Backlog

Comments

@Chips1234
Copy link
Contributor

Description of the new feature/enhancement

Apart from the setting, it will be easier to have a checkbox at the bottom of the CloseAll dialog with the option "Don't ask again" (it will work alongside settings JSON and later GUI)

Proposed technical implementation details (optional)

Checkbox for dialog
@Chips1234 Chips1234 added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Jun 23, 2020
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jun 23, 2020
@gdevacc12 gdevacc12 mentioned this issue Jun 25, 2020
Open
1 task
@DHowett
Copy link
Member

DHowett commented Jun 25, 2020

I've got some plans here -- I proposed an alternate settings storage location for runtime-generated settings like this that wouldn't show up in the user's JSON file.

Here's a diagram I drew up a couple months ago. It depicts the behavior of different configuration values for confirmCloseAllTabs:

image

@DHowett DHowett added Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Issue-Task It's a feature request, but it doesn't really need a major design. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. labels Jun 25, 2020
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Jun 25, 2020
@DHowett DHowett added this to the Terminal Backlog milestone Jun 25, 2020
@DHowett DHowett removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Jun 25, 2020
@Chips1234

This comment was marked as outdated.

Sign in to view
@DHowett DHowett changed the title Checkbox on dialogs Add a "remember my decision" checkbox to our confirmation dialogs Jun 25, 2020
@Chips1234

This comment was marked as outdated.

Sign in to view
@DHowett

This comment was marked as outdated.

Sign in to view
@Chips1234

This comment was marked as outdated.

Sign in to view
@DHowett DHowett mentioned this issue Nov 18, 2020
Closed
5 tasks
@zadjii-msft zadjii-msft modified the milestones: Terminal v2.0, 22H2 Jan 4, 2022
@zadjii-msft zadjii-msft mentioned this issue May 26, 2022
Closed
@zadjii-msft zadjii-msft added the Help Wanted We encourage anyone to jump in on these. label May 26, 2022
This was referenced Nov 21, 2022
Merged
Closed
@zadjii-msft zadjii-msft modified the milestones: 22H2, Backlog Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-UserInterface Issues pertaining to the user interface of the Console or Terminal Help Wanted We encourage anyone to jump in on these. Issue-Task It's a feature request, but it doesn't really need a major design. Priority-2 A description (P2) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@DHowett @zadjii-msft @Chips1234