Fix font size rounding in the settings UI #14040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DHowett
reviewed
Sep 19, 2022
| // issues when displaying 32-bit floats, because WinUI is unaware about their existence. | ||
| SignificantDigitsNumberRounder rounder; | ||
| rounder.SignificantDigits(6); | ||
| _fontSizeBox().NumberFormatter().as<DecimalFormatter>().NumberRounder(rounder); |
There was a problem hiding this comment.
yikes. This is an implementation detail, but i no longer care :D
DHowett
approved these changes
Sep 19, 2022
| // issues when displaying 32-bit floats, because WinUI is unaware about their existence. | ||
| SignificantDigitsNumberRounder rounder; | ||
| rounder.SignificantDigits(6); | ||
| _fontSizeBox().NumberFormatter().as<DecimalFormatter>().NumberRounder(rounder); |
ghost
added
Area-SettingsUI
DHowett
approved these changes
Sep 19, 2022
DHowett
approved these changes
Sep 20, 2022
DHowett
pushed a commit
that referenced
this pull request
Sep 21, 2022
This fixes an issue with c51bb3a, where some fractional font sizes are displayed as something like 13.600000000001. Closes #14024 ## Validation Steps Performed * Enter a font size of 13.6 and save * NumberBox displays "13.6" ✅ (cherry picked from commit f79276b) Service-Card-Id: 85740785 Service-Version: 1.16
|
🎉 Handy links: |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue with c51bb3a, where some fractional font
sizes are displayed as something like 13.600000000001.
Closes #14024
Validation Steps Performed