Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Odd behavior when using fractional font size in SUI #14024

Closed
elsaco opened this issue Sep 17, 2022 · 1 comment · Fixed by #14040
Closed

Odd behavior when using fractional font size in SUI #14024

elsaco opened this issue Sep 17, 2022 · 1 comment · Fixed by #14040
Assignees
@lhecker
Labels
Area-SettingsUI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@elsaco
Copy link

elsaco commented Sep 17, 2022

Windows Terminal version

main c51bb3a

Windows build number

10.0.19044.0

Other Software

No response

Steps to reproduce

build terminal with Add support for fractional font size commit included

Expected Behavior

consistent fractional part

Actual Behavior

when using any other fractional beside .5 the font size is being expanded to 10 decimal places, overlapping the controls:

fractional_font_size

when incrementing/decrementing with the up/down arrows only the integer part is being changed, i.e. 13.5 , 14.5, 15.5
@elsaco elsaco added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Sep 17, 2022
@ghost ghost added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Sep 17, 2022
@lhecker lhecker self-assigned this Sep 18, 2022
@lhecker lhecker added Product-Terminal The new Windows Terminal. Priority-2 A description (P2) Area-SettingsUI Anything specific to the SUI labels Sep 19, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Sep 19, 2022
@lhecker lhecker mentioned this issue Sep 19, 2022
Merged
@ghost ghost added the In-PR This issue has a related PR label Sep 19, 2022
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Sep 20, 2022
DHowett pushed a commit that referenced this issue Sep 20, 2022
@lhecker
Fix font size rounding in the settings UI (#14040)
f79276b 
This fixes an issue with c51bb3a, where some fractional font
sizes are displayed as something like 13.600000000001.

Closes #14024

## Validation Steps Performed
* Enter a font size of 13.6 and save
* NumberBox displays "13.6" ✅
DHowett pushed a commit that referenced this issue Sep 21, 2022
@lhecker @DHowett
Fix font size rounding in the settings UI (#14040)
8876417 
This fixes an issue with c51bb3a, where some fractional font
sizes are displayed as something like 13.600000000001.

Closes #14024

## Validation Steps Performed
* Enter a font size of 13.6 and save
* NumberBox displays "13.6" ✅

(cherry picked from commit f79276b)
Service-Card-Id: 85740785
Service-Version: 1.16
@ghost
Copy link

ghost commented Sep 23, 2022

🎉This issue was addressed in #14040, which has now been successfully released as Windows Terminal Preview v1.16.2641.0.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lhecker lhecker

Labels
Area-SettingsUI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix font size rounding in the settings UI microsoft/terminal
2 participants
@lhecker @elsaco