Fix crash on save in rejuv'd Color Schemes page #13902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlos-zamora
added
the
Severity-Blocking
|
FYI @DHowett as the 1.16 release guru |
DHowett
reviewed
Sep 1, 2022
src/cascadia/TerminalSettingsEditor/ColorSchemesPageViewModel.cpp
Outdated
Show resolved
Hide resolved
DHowett
reviewed
Sep 1, 2022
src/cascadia/TerminalSettingsEditor/ColorSchemesPageViewModel.cpp
Outdated
Show resolved
Hide resolved
DHowett
approved these changes
Sep 1, 2022
|
aw frick, i lied to you check for |
carlos-zamora
commented
Sep 1, 2022
src/cascadia/TerminalSettingsEditor/ColorSchemesPageViewModel.cpp
Outdated
Show resolved
Hide resolved
zadjii-msft
approved these changes
Sep 1, 2022
|
@msftbot merge this in 1 minute |
ghost
added
the
AutoMerge
|
Hello @DHowett! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
ghost
merged commit
ghost
added
Area-SettingsUI
|
🎉 Handy links: |
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Fix a bug where if you pressed the "Save" button, WT would crash. This was caused by adding the possibility that no color scheme is selected in the main page. With no "current scheme", attempting to get its "name" would cause a null ptr exception.
The fix is simple: just check if we actually have a current scheme.
Bonus points: if we don't have a current scheme, don't bother looking throught the color schemes for a match because we'll never find one.
References
#13269 - Color Schemes Rejuv