Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.16 - Crash in SUI when hot-reloading SUI #13900

Closed
zadjii-msft opened this issue Sep 1, 2022 · 1 comment · Fixed by #13902
Closed

1.16 - Crash in SUI when hot-reloading SUI #13900

zadjii-msft opened this issue Sep 1, 2022 · 1 comment · Fixed by #13902
Labels
Area-SettingsUI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Blocking We won't ship a release like this! No-siree. Severity-Crash Crashes are real bad news.
Milestone
Terminal v1.16

Comments

@zadjii-msft
Copy link
Member

Unsure if it's just my settings blob or not.

  1. Open a SUI tab
  2. save the settings.json file
  3. 💥

Crash is in

stack 
>	Microsoft.Terminal.Settings.Editor.dll!winrt::impl::consume_Microsoft_Terminal_Settings_Editor_IColorSchemeViewModel<winrt::Microsoft::Terminal::Settings::Editor::IColorSchemeViewModel>::Name() Line 688	C++
 	Microsoft.Terminal.Settings.Editor.dll!winrt::Microsoft::Terminal::Settings::Editor::implementation::ColorSchemesPageViewModel::UpdateSettings(const winrt::Microsoft::Terminal::Settings::Model::CascadiaSettings & settings) Line 37	C++
 	Microsoft.Terminal.Settings.Editor.dll!winrt::impl::produce<winrt::Microsoft::Terminal::Settings::Editor::implementation::ColorSchemesPageViewModel,winrt::Microsoft::Terminal::Settings::Editor::IColorSchemesPageViewModel>::UpdateSettings(void * settings) Line 4015	C++
 	Microsoft.Terminal.Settings.Editor.dll!winrt::impl::consume_Microsoft_Terminal_Settings_Editor_IColorSchemesPageViewModel<winrt::Microsoft::Terminal::Settings::Editor::IColorSchemesPageViewModel>::UpdateSettings(const winrt::Microsoft::Terminal::Settings::Model::CascadiaSettings & settings) Line 791	C++
 	Microsoft.Terminal.Settings.Editor.dll!winrt::Microsoft::Terminal::Settings::Editor::implementation::MainPage::UpdateSettings(const winrt::Microsoft::Terminal::Settings::Model::CascadiaSettings & settings) Line 159	C++
 	Microsoft.Terminal.Settings.Editor.dll!winrt::impl::produce<winrt::Microsoft::Terminal::Settings::Editor::implementation::MainPage,winrt::Microsoft::Terminal::Settings::Editor::IMainPage>::UpdateSettings(void * settings) Line 5371	C++
 	TerminalApp.dll!winrt::impl::consume_Microsoft_Terminal_Settings_Editor_IMainPage<winrt::Microsoft::Terminal::Settings::Editor::IMainPage>::UpdateSettings(const winrt::Microsoft::Terminal::Settings::Model::CascadiaSettings & settings) Line 1721	C++
 	TerminalApp.dll!winrt::TerminalApp::implementation::SettingsTab::UpdateSettings(winrt::Microsoft::Terminal::Settings::Model::CascadiaSettings settings) Line 44	C++

_CurrentScheme is nullptr.

<conjecture>I bet it's cause _CurrentScheme doesn't get set until the first _UpdateSettings call, which doesn't happen until a settings reload.
@zadjii-msft zadjii-msft added Issue-Bug It either shouldn't be doing this or needs an investigation. Severity-Crash Crashes are real bad news. Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. Area-SettingsUI Anything specific to the SUI labels Sep 1, 2022
@zadjii-msft zadjii-msft added this to the Terminal v1.16 milestone Sep 1, 2022
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Sep 1, 2022
@zadjii-msft zadjii-msft mentioned this issue Sep 2, 2022
Merged
1 task
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Sep 2, 2022
@ghost
Copy link

ghost commented Sep 13, 2022

🎉This issue was addressed in #13902, which has now been successfully released as Windows Terminal Preview v1.16.252.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-SettingsUI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Blocking We won't ship a release like this! No-siree. Severity-Crash Crashes are real bad news.
Projects
None yet
Milestone
Terminal v1.16
Development

Successfully merging a pull request may close this issue.

Fix crash on save in rejuv'd Color Schemes page microsoft/terminal
1 participant
@zadjii-msft