Update the default themes for 1.16 #13743

zadjii-msft · 2022-08-15T18:28:28Z

More or less, as in #13554

Dark theme by default (was system)
- Justification:
  
  I think the interesting thing that we have today is that the color
  scheme is dark by default, but our window theme is set to system.
  System theme in Windows 11 is defaulted to light unless changed by
  the user. Now, we have a conflict between the theme and color scheme
  in Terminal.
  
  I think our options become, make the color scheme match "default"
  and set it to a light color scheme if the system theme is light, or
  manually match the theme to the color scheme by setting it to dark.
  
  Given that Terminal has historically had a black background with
  its Campbell color scheme, for a consistent UI experience, I'm
  voting to change the window theme to be dark by default as well.
tab.background: terminalBackground
Change the tab row colors back to "what they were pre-Controlsv2" more
or less
- The ramp is based off of "Light tab row background from Edge's
  unfocused titlebar color, inactive tab row color BG from the
  controlsv1 colors"
tabRow.unfocusedBackground set Transparent

Closes #13554

…activeTabBg

… FG color, works sanely now

…/13684-inactiveTabBg

…activeTabBg

…54-new-default-theme

This reverts commit 48deba0.

zadjii-msft · 2022-08-15T18:28:33Z

Dark

Light

DHowett · 2022-08-15T21:12:10Z

src/cascadia/TerminalSettingsModel/defaults.json

+            },
+            "tabRow":
+            {
+                "unfocusedBackground": "#FFFFFFFF"


this is very white

aye, it is. There's not a lot of room to go lighter from #e8e8e8. I suppose we could wholesale copy Edge for light mode. That would be

#cdcdcd for focused

#e8e8e8 for unfocused

instead. With light mode we don't really have a "black tab on dark background" contrast issue we need to worry about. @cinnamon-msft thoughts?

Are there light colors that are defined for the tab row control? I'd assume we'd want to align with XAML recommendations?

... yes? The default WinUI colors are pretty terrible contrast-wise: #f9f9f9 on #f3f3f3

Which is part of the reason we had to change the colors in the first place 😐

if Edge has good enough contrast, I vote we do that.

DHowett · 2022-08-15T22:18:40Z

src/cascadia/TerminalSettingsModel/defaults.json

@@ -26,7 +26,7 @@
    // Miscellaneous
    "confirmCloseAllTabs": true,
    "startOnUserLogin": false,
-    "theme": "system",
+    "theme": "dark",


This may cause some people to snap

it was definitely a 🌶️ take, for sure. @cinnamon-msft suggested it originally.

I think it's much better to simply leave system as default. If a user wants dark (or light) no matter what, they'll set it explicitly. It's the same thing with Edge. It's system by default as well. Since we're following Edge's example for the theme, this should probably also match.

I think the interesting thing that we have today is that the color scheme is dark by default, but our window theme is set to system. System theme in Windows 11 is defaulted to light unless changed by the user. Now, we have a conflict between the theme and color scheme in Terminal.

I think our options become, make the color scheme match "default" and set it to a light color scheme if the system theme is light, or manually match the theme to the color scheme by setting it to dark.

Given that Terminal has historically had a black background with its Campbell color scheme, for a consistent UI experience, I'm voting to change the window theme to be dark by default as well.

I agree. People who don't like it can switch it back -- they are likely accustomed to applications acting strange in light theme ;P

lmao wassup reddit 😜

DHowett · 2022-08-15T22:19:38Z

src/cascadia/TerminalSettingsModel/defaults.json

+            "tab":
+            {
+                "background": "terminalBackground",
+                "unfocusedBackground": "#00000000"


Just alpha 0 so it blends in with the rest of the tab bar?

yeppers. Basically cause our tabs RN are already "transparent when unfocused". This gives them "terminalBG" when focused, but retains "transparent when unfocused", so that the black of campbell doesn't show up semi-transparent on unfocused tabs even in light mode.

src/cascadia/TerminalSettingsModel/defaults.json

DHowett · 2022-08-15T22:23:39Z

Closes #1375

zadjii-msft · 2022-08-16T11:37:20Z

Closes #1375

you're goddamn right it does

…activeTabBg

lhecker · 2022-08-22T17:37:35Z

src/cascadia/TerminalSettingsModel/defaults.json

+            "window":
+            {


Can you reformat this file in VS Code with default formatting settings before we merge this? By default braces are attached to the line with the colon.

…activeTabBg

…54-new-default-theme

…activeTabBg

…54-new-default-theme

carlos-zamora

Comment-ing instead of approving because I want the JSON file formatted nicely and some resolution on the Edge colors thread.

carlos-zamora · 2022-08-30T21:31:11Z

src/cascadia/TerminalSettingsModel/defaults.json

+            },
+            "tabRow":
+            {
+                "unfocusedBackground": "#FFFFFFFF"


if Edge has good enough contrast, I vote we do that.

Co-authored-by: Leonard Hecker <lhecker@microsoft.com>

[11:48 AM] Leonard Hecker of course not - it's "alpha A inversed" [11:49 AM] Leonard Hecker why is that so hard to understand /s lmao

…54-new-default-theme

ghost · 2022-09-13T17:08:35Z

🎉Windows Terminal Preview v1.16.252 has been released which incorporates this pull request.:tada:

Handy links:

zadjii-msft added 15 commits August 5, 2022 09:58

sometimes I do the code good

57e02b8

Merge remote-tracking branch 'origin/main' into dev/migrie/b/13684-in…

fe5a86d

…activeTabBg

Allow the settings tab to also have a color set by the theme

bdfb015

default settings changes

4146d71

transparent inactive tabs on light tab row, when the tabs have a dark…

f911929

… FG color, works sanely now

comments

2964ebe

I can't tell you how much I hate this

37ce107

comments galore

25e09d6

Merge branch 'dev/migrie/b/13554-new-default-theme' into dev/migrie/b…

b38b704

…/13684-inactiveTabBg

Revert the changes I made to the default themes

48deba0

runformat

ff90631

Merge remote-tracking branch 'origin/main' into dev/migrie/b/13684-in…

dfe40fa

…activeTabBg

Thanks austin mode

b040192

Merge branch 'dev/migrie/b/13684-inactiveTabBg' into dev/migrie/b/135…

eae495c

…54-new-default-theme

Revert "Revert the changes I made to the default themes"

dd218d1

This reverts commit 48deba0.

ghost added Area-Theming Anything related to the theming of elements of the window Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels Aug 15, 2022

DHowett reviewed Aug 15, 2022

View reviewed changes

zadjii-msft linked an issue Aug 16, 2022 that may be closed by this pull request

[1.16] Default theme updates #13554

Closed

4 tasks

Merge remote-tracking branch 'origin/main' into dev/migrie/b/13684-in…

17262f7

…activeTabBg

lhecker approved these changes Aug 22, 2022

View reviewed changes

DHowett added a commit that referenced this pull request Aug 23, 2022

PRE-MERGE #13743 Update the default themes for 1.16

c1df08e

zadjii-msft added 3 commits August 24, 2022 12:44

Merge remote-tracking branch 'origin/main' into dev/migrie/b/13684-in…

60d28f3

…activeTabBg

Merge branch 'main' into dev/migrie/b/13684-inactiveTabBg

4c7cfee

Merge branch 'dev/migrie/b/13684-inactiveTabBg' into dev/migrie/b/135…

250ca8c

…54-new-default-theme

zadjii-msft added 5 commits August 26, 2022 11:19

fixes the settings tab getting initialized with the wrong theme

6727b5f

This fixes the unfocused tab color weirdness

8ecbc6e

fixes the settings tab getting initialized with the wrong theme

9f7cbdc

This fixes the unfocused tab color weirdness

c5e0445

Merge branch 'dev/migrie/b/13684-inactiveTabBg' into dev/migrie/b/135…

27e826e

…54-new-default-theme

zadjii-msft mentioned this pull request Aug 29, 2022

Fixes the color of the dropdown arrow in weird themes #13871

Merged

zadjii-msft added 5 commits August 29, 2022 16:35

Merge remote-tracking branch 'origin/main' into dev/migrie/b/13684-in…

2e8e802

…activeTabBg

Merge remote-tracking branch 'origin/main' into dev/migrie/b/13684-in…

da56d48

…activeTabBg

nits from review

951ab2c

okay

b92da58

Merge branch 'dev/migrie/b/13684-inactiveTabBg' into dev/migrie/b/135…

8cafe8a

…54-new-default-theme

carlos-zamora reviewed Aug 30, 2022

View reviewed changes

zadjii-msft and others added 4 commits August 31, 2022 11:40

Update src/inc/til/color.h

81ef597

Co-authored-by: Leonard Hecker <lhecker@microsoft.com>

ugh "aai is not a word"

ec3ebb9

[11:48 AM] Leonard Hecker of course not - it's "alpha A inversed" [11:49 AM] Leonard Hecker why is that so hard to understand /s lmao

Merge branch 'dev/migrie/b/13684-inactiveTabBg' into dev/migrie/b/135…

707ea09

…54-new-default-theme

I think this is the format they wanted?

2b54363

Base automatically changed from dev/migrie/b/13684-inactiveTabBg to main August 31, 2022 17:48

carlos-zamora approved these changes Aug 31, 2022

View reviewed changes

zadjii-msft merged commit 0b1b7e6 into main Aug 31, 2022

zadjii-msft deleted the dev/migrie/b/13554-new-default-theme branch August 31, 2022 18:32

ghost mentioned this pull request Sep 13, 2022

[1.16] Default theme updates #13554

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update the default themes for 1.16 #13743

Update the default themes for 1.16 #13743

zadjii-msft commented Aug 15, 2022 •

edited by DHowett

Loading

zadjii-msft commented Aug 15, 2022

DHowett Aug 15, 2022

zadjii-msft Aug 16, 2022

cinnamon-msft Aug 17, 2022

zadjii-msft Aug 18, 2022

carlos-zamora Aug 30, 2022

DHowett Aug 15, 2022

zadjii-msft Aug 16, 2022

WSLUser Aug 17, 2022 •

edited

Loading

cinnamon-msft Aug 17, 2022

DHowett Aug 22, 2022

zadjii-msft Aug 25, 2022

DHowett Aug 15, 2022

zadjii-msft Aug 16, 2022

DHowett commented Aug 15, 2022

zadjii-msft commented Aug 16, 2022

lhecker Aug 22, 2022 •

edited

Loading

carlos-zamora left a comment

carlos-zamora Aug 30, 2022

ghost commented Sep 13, 2022

Update the default themes for 1.16 #13743

Update the default themes for 1.16 #13743

Conversation

zadjii-msft commented Aug 15, 2022 • edited by DHowett Loading

zadjii-msft commented Aug 15, 2022

Dark

Light

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

WSLUser Aug 17, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DHowett commented Aug 15, 2022

zadjii-msft commented Aug 16, 2022

lhecker Aug 22, 2022 • edited Loading

Choose a reason for hiding this comment

carlos-zamora left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghost commented Sep 13, 2022

zadjii-msft commented Aug 15, 2022 •

edited by DHowett

Loading

WSLUser Aug 17, 2022 •

edited

Loading

lhecker Aug 22, 2022 •

edited

Loading