Fixes the color of the dropdown arrow in weird themes #13871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… FG color, works sanely now
…/13684-inactiveTabBg
…54-new-default-theme
This reverts commit 48deba0.
…54-new-default-theme
…54-new-default-theme
8 tasks
…54-new-default-theme
…/13725-dropdown-color
Co-authored-by: Leonard Hecker <lhecker@microsoft.com>
[11:48 AM] Leonard Hecker of course not - it's "alpha A inversed" [11:49 AM] Leonard Hecker why is that so hard to understand /s lmao
…54-new-default-theme
…/13725-dropdown-color
|
I am quite scared that this changes fifteen files for what sounds like it shouldn't be too hard! |
|
Oh, I think you need to merge |
|
(diff should be better now) |
|
Moved from body of PR (so it didn't clutter up the git commit history with HTML/JSON things): Tested with these two themes: json {
"name": "horrible",
"tab":
{
"background": "#00FF00FF",
"showCloseButton": "never"
},
"tabRow":
{
"background": "accent",
"unfocusedBackground": "#008888FF"
},
"window":
{
"applicationTheme": "light",
"useMica": false
}
},
{
"name": "horrible dark",
"tab":
{
"background": "#00FF00FF",
"showCloseButton": "never"
},
"tabRow":
{
"background": "accent",
"unfocusedBackground": "#008888FF"
},
"window":
{
"applicationTheme": "dark",
"useMica": false
}
}, |
DHowett
approved these changes
Aug 31, 2022
| @@ -3092,12 +3092,24 @@ namespace winrt::TerminalApp::implementation | |||
| _newTabButton.Resources().Insert(winrt::box_value(L"SplitButtonBackgroundPointerOver"), backgroundHoverBrush); | |||
| _newTabButton.Resources().Insert(winrt::box_value(L"SplitButtonBackgroundPressed"), backgroundPressedBrush); | |||
|
|
|||
| // Load bearing: The SplitButton uses SplitButtonForegroundSecondary for | |||
| // the secondary button, but {TemplateBinding Foreground} for the | |||
carlos-zamora
approved these changes
Aug 31, 2022
|
@msftbot merge this in 10 minutes |
DHowett
added
the
AutoMerge
|
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
|
🎉 Handy links: |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also:
https://github.com/microsoft/microsoft-ui-xaml/blob/33732458ede38166f9127675898e4760c82b89bb/dev/SplitButton/SplitButton.xaml#L290-L293
We need to
SplitButtonForegroundSecondarycause SplitButton's use that resource separately from theForeground()propertyThis is one of the bullet points in #13725