Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing breaks #12926

Merged
merged 1 commit into from
Apr 18, 2022
Merged

add missing breaks #12926

merged 1 commit into from
Apr 18, 2022

Conversation

jmelas
Copy link
Contributor

@jmelas jmelas commented Apr 18, 2022 •
edited
Loading

Summary of the Pull Request

This PR adds some missing break commands in IslandWindow::MessageHandler switch statement.

PR Checklist

@ghost ghost added Area-Windowing Window frame, quake mode, tearout Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Apr 18, 2022
@zadjii-msft zadjii-msft added the Needs-Second It's a PR that needs another sign-off label Apr 18, 2022
carlos-zamora
carlos-zamora approved these changes Apr 18, 2022
View reviewed changes
Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, surprised it wasn't caught by audit mode. Nice!

@DHowett
Copy link
Member

DHowett commented Apr 18, 2022

Thanks for doing this!

@DHowett DHowett merged commit b7e4701 into microsoft:main Apr 18, 2022
@ghost
Copy link

ghost commented May 24, 2022

🎉Windows Terminal Preview v1.14.143 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request May 24, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@miniksa miniksa Awaiting requested review from miniksa

@DHowett DHowett Awaiting requested review from DHowett

@lhecker lhecker Awaiting requested review from lhecker

@PankajBhojwani PankajBhojwani Awaiting requested review from PankajBhojwani

Assignees
No one assigned
Labels
Area-Windowing Window frame, quake mode, tearout Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Second It's a PR that needs another sign-off Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

break is missing here?
4 participants
@jmelas @DHowett @carlos-zamora @zadjii-msft