Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

break is missing here? #12923

Closed
jmelas opened this issue Apr 18, 2022 · 3 comments · Fixed by #12926
Closed

break is missing here? #12923

jmelas opened this issue Apr 18, 2022 · 3 comments · Fixed by #12926
Labels
Area-Windowing Window frame, quake mode, tearout good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Backlog

Comments

@jmelas
Copy link
Contributor

jmelas commented Apr 18, 2022

terminal/src/cascadia/WindowsTerminal/IslandWindow.cpp

Line 597 in 41ef555

}

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 18, 2022
@zadjii-msft
Copy link
Member

Yes, there absolutely is. Good eye! would you like to open a PR for that?

@zadjii-msft zadjii-msft added Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Priority-3 A description (P3) Area-Windowing Window frame, quake mode, tearout labels Apr 18, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Apr 18, 2022
@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. Needs-Tag-Fix Doesn't match tag requirements good first issue This is a fix that might be easier for someone to do as a first contribution labels Apr 18, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Apr 18, 2022
@zadjii-msft zadjii-msft added this to the Backlog milestone Apr 18, 2022
@jmelas
Copy link
Contributor Author

jmelas commented Apr 18, 2022

Yes, there absolutely is. Good eye! would you like to open a PR for that?

OK I will do!

@jmelas jmelas mentioned this issue Apr 18, 2022
Merged
3 tasks
@ghost ghost added the In-PR This issue has a related PR label Apr 18, 2022
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Apr 18, 2022
DHowett pushed a commit that referenced this issue Apr 18, 2022
@jmelas
Add some missing breaks to cases in IslandWindow (#12926)
b7e4701 
Closes #12923
@ghost
Copy link

ghost commented May 24, 2022

🎉This issue was addressed in #12926, which has now been successfully released as Windows Terminal Preview v1.14.143.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Windowing Window frame, quake mode, tearout good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

add missing breaks jmelas/terminal
2 participants
@jmelas @zadjii-msft