Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hush a garrulous event from TerminalControl #12723

Merged
1 commit merged into from
Mar 18, 2022
Merged

Hush a garrulous event from TerminalControl #12723

1 commit merged into from
Mar 18, 2022

Conversation

DHowett
Copy link
Member

@DHowett DHowett commented Mar 18, 2022

lhecker
lhecker approved these changes Mar 18, 2022
View reviewed changes
Copy link
Member

@lhecker lhecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exception
/ɪkˈsɛpʃ(ə)n,ɛkˈsɛpʃ(ə)n/
noun
a person or thing that is excluded from a general statement or does not follow a rule.

Love it. 😎

zadjii-msft
zadjii-msft approved these changes Mar 18, 2022
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

our toolchain is 👌

@DHowett
Copy link
Member Author

DHowett commented Mar 18, 2022

@msftbot merge this in 1 minute

@ghost ghost added the AutoMerge Marked for automatic merge by the bot when requirements are met label Mar 18, 2022
@ghost
Copy link

ghost commented Mar 18, 2022

Hello @DHowett!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Fri, 18 Mar 2022 21:54:21 GMT, which is in 1 minute

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost merged commit 2de2ae2 into main Mar 18, 2022
@ghost ghost deleted the dev/duhowett/hush_little_baby_now_dont_you_TRACELOG branch March 18, 2022 21:54
DHowett added a commit that referenced this pull request Mar 28, 2022
@DHowett
Hush a garrulous event from TerminalControl (#12723)
875d7ac 
Fixes MSFT-36708760

(cherry picked from commit 2de2ae2)
DHowett added a commit that referenced this pull request Mar 28, 2022
@DHowett
Hush a garrulous event from TerminalControl (#12723)
1762564 
Fixes MSFT-36708760

(cherry picked from commit 2de2ae2)
@ghost
Copy link

ghost commented Apr 19, 2022

🎉Windows Terminal v1.12.1098 has been released which incorporates this pull request.:tada:

Handy links:

@ghost
Copy link

ghost commented Apr 19, 2022

🎉Windows Terminal Preview v1.13.1098 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@lhecker lhecker lhecker approved these changes

@miniksa miniksa Awaiting requested review from miniksa

Assignees
No one assigned
Labels
AutoMerge Marked for automatic merge by the bot when requirements are met
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DHowett @lhecker @zadjii-msft