Skip to content

Commit

Permalink
Hush a garrulous event from TerminalControl (#12723)
Browse files Browse the repository at this point in the history
  • Loading branch information
DHowett authored Mar 18, 2022
1 parent 830a422 commit 2de2ae2
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions src/inc/WilErrorReporting.h
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,16 @@ namespace Microsoft::Console::ErrorReporting
__declspec(noinline) inline void WINAPI ReportFailureToFallbackProvider(bool alreadyReported, const wil::FailureInfo& failure) noexcept
try
{
if (failure.hr == 0x80131515L)
{
// XAML requires that we reply with this HR for the accessibility code in XamlUiaTextRange to work.
// Unfortunately, due to C++/WinRT, we have to _throw_ it. That results in us ending up here,
// trying to report the error to telemetry. It's not an actual error, per se, so we don't
// want to log it. It's also incredibly noisy, which results in bugs getting filed on us.
// See https://github.com/microsoft/cppwinrt/issues/798 for more discussion about throwing HRESULTs.
return;
}

if (!alreadyReported && FallbackProvider)
{
#pragma warning(suppress : 26477) // Use 'nullptr' rather than 0 or NULL
Expand Down

0 comments on commit 2de2ae2

Please sign in to comment.