Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop making settings.json backups #12652

Merged
1 commit merged into from
Mar 9, 2022
Merged

Stop making settings.json backups #12652

1 commit merged into from
Mar 9, 2022

Conversation

carlos-zamora
Copy link
Member

Summary of the Pull Request

This makes it so that the settings.json backups are no longer created when the user saves their settings via the Settings UI.

Closes #11703

@carlos-zamora carlos-zamora requested a review from lhecker March 9, 2022 22:14
@ghost ghost added Area-SettingsUI Anything specific to the SUI Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels Mar 9, 2022
@DHowett DHowett added zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. zStable-Service-Queued-1.12 A floating label that tracks the current Stable version for servicing purposes. labels Mar 9, 2022
@DHowett
Copy link
Member

DHowett commented Mar 9, 2022

@msftbot merge this in 1 minute

@ghost ghost added the AutoMerge Marked for automatic merge by the bot when requirements are met label Mar 9, 2022
@ghost
Copy link

ghost commented Mar 9, 2022

Hello @DHowett!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Wed, 09 Mar 2022 22:27:06 GMT, which is in 1 minute

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost merged commit 91f5648 into main Mar 9, 2022
@ghost ghost deleted the dev/cazamor/no-more-settings-backups branch March 9, 2022 22:49
DHowett pushed a commit that referenced this pull request Mar 10, 2022
@carlos-zamora @DHowett
Stop making settings.json backups (#12652)
4a73d47 
## Summary of the Pull Request
This makes it so that the settings.json backups are no longer created when the user saves their settings via the Settings UI.

Closes #11703

(cherry picked from commit 91f5648)
DHowett pushed a commit that referenced this pull request Mar 10, 2022
@carlos-zamora @DHowett
Stop making settings.json backups (#12652)
763f9b0 
## Summary of the Pull Request
This makes it so that the settings.json backups are no longer created when the user saves their settings via the Settings UI.

Closes #11703

(cherry picked from commit 91f5648)
@ghost
Copy link

ghost commented Mar 25, 2022

🎉Windows Terminal v1.12.1073 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Mar 25, 2022
Closed
@ghost
Copy link

ghost commented Mar 25, 2022

🎉Windows Terminal Preview v1.13.1073 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@lhecker lhecker lhecker approved these changes

@DHowett DHowett DHowett approved these changes

Assignees
No one assigned
Labels
Area-SettingsUI Anything specific to the SUI AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. zStable-Service-Queued-1.12 A floating label that tracks the current Stable version for servicing purposes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Backups of settings.json?
4 participants
@carlos-zamora @DHowett @lhecker @zadjii-msft