Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backups of settings.json? #11703

Closed
vefatica opened this issue Nov 7, 2021 · 3 comments · Fixed by #12652
Closed

Backups of settings.json? #11703

vefatica opened this issue Nov 7, 2021 · 3 comments · Fixed by #12652
Assignees
@lhecker
Labels
Area-SettingsUI Anything specific to the SUI Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.14

Comments

@vefatica
Copy link

vefatica commented Nov 7, 2021

I have 164 backups of settings.json going back to settings.json.2021-02-15T13-38-38.backup. Is there no limit? Thanks!
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Nov 7, 2021
@zadjii-msft
Copy link
Member

zadjii-msft commented Nov 8, 2021 •
edited
Loading

Huh. No, there's no limit, but we might not need to be keeping those anymore. Those were more of a safety valve in the first few releases of the SUI, to make sure we didn't lose anything.

Apparently, we didn't have a issue open to track getting rid of those, so here it is.

@zadjii-msft zadjii-msft added Area-SettingsUI Anything specific to the SUI Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. labels Nov 8, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Nov 8, 2021
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Nov 8, 2021
@zadjii-msft zadjii-msft added Needs-Discussion Something that requires a team discussion before we can proceed Needs-Tag-Fix Doesn't match tag requirements labels Nov 8, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Nov 8, 2021
@lhecker lhecker self-assigned this Nov 8, 2021
@zadjii-msft zadjii-msft removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Discussion Something that requires a team discussion before we can proceed labels Nov 8, 2021
@zadjii-msft zadjii-msft modified the milestones: Terminal v2.0, 22H1 Jan 4, 2022
@zadjii-msft zadjii-msft modified the milestones: 22H1, Terminal v1.14 Feb 2, 2022
@carlos-zamora carlos-zamora mentioned this issue Mar 9, 2022
Merged
@ghost ghost added the In-PR This issue has a related PR label Mar 9, 2022
@ghost ghost closed this as completed in #12652 Mar 9, 2022
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Mar 9, 2022
ghost pushed a commit that referenced this issue Mar 9, 2022
@carlos-zamora
Stop making settings.json backups (#12652)
91f5648 
## Summary of the Pull Request
This makes it so that the settings.json backups are no longer created when the user saves their settings via the Settings UI.

Closes #11703
DHowett pushed a commit that referenced this issue Mar 10, 2022
@carlos-zamora @DHowett
Stop making settings.json backups (#12652)
4a73d47 
## Summary of the Pull Request
This makes it so that the settings.json backups are no longer created when the user saves their settings via the Settings UI.

Closes #11703

(cherry picked from commit 91f5648)
DHowett pushed a commit that referenced this issue Mar 10, 2022
@carlos-zamora @DHowett
Stop making settings.json backups (#12652)
763f9b0 
## Summary of the Pull Request
This makes it so that the settings.json backups are no longer created when the user saves their settings via the Settings UI.

Closes #11703

(cherry picked from commit 91f5648)
@ghost
Copy link

ghost commented Mar 25, 2022

🎉This issue was addressed in #12652, which has now been successfully released as Windows Terminal v1.12.1073.:tada:

Handy links:

@ghost
Copy link

ghost commented Mar 25, 2022

🎉This issue was addressed in #12652, which has now been successfully released as Windows Terminal Preview v1.13.1073.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lhecker lhecker

Labels
Area-SettingsUI Anything specific to the SUI Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.14
Development

Successfully merging a pull request may close this issue.

Stop making settings.json backups microsoft/terminal
3 participants
@lhecker @zadjii-msft @vefatica