Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update light theme tab background for greater contrast. #12529

Merged
1 commit merged into from
Feb 24, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/cascadia/TerminalApp/App.xaml
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,16 @@

<ResourceDictionary x:Key="Light">
<!-- Define resources for Light mode here -->

<!--
The Dark mode BG uses
DHowett marked this conversation as resolved.
Show resolved Hide resolved
ApplicationPageBackgroundThemeBrush, but we're
manually setting the Light BG to e8e8e8 here, at the
guidance of the WinUI team. Otherwise, there's just
not enough contrast in light mode. GH #12398
-->
<SolidColorBrush x:Key="TabViewBackground"
Color="#F3F3F3" />
Color="#E8E8E8" />

<StaticResource x:Key="UnfocusedBorderBrush"
ResourceKey="ApplicationPageBackgroundThemeBrush" />
Expand Down