Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update light theme tab background for greater contrast. #12529

Merged
1 commit merged into from
Feb 24, 2022
Merged

Update light theme tab background for greater contrast. #12529

1 commit merged into from
Feb 24, 2022

Conversation

zadjii-msft
Copy link
Member

Changes the tab view BG to #e8e8e8, as discussed in mail thread.

Closes #12398

@zadjii-msft
Update light theme tab background for greater contrast.
71aa17d 
Changes the tab view BG to `#e8e8e8`, as discussed in mail thread.

Closes #12398
@ghost ghost added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Feb 18, 2022
@DHowett DHowett added the zStable-Service-Queued-1.12 A floating label that tracks the current Stable version for servicing purposes. label Feb 18, 2022
@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Feb 24, 2022
@ghost
Copy link

ghost commented Feb 24, 2022

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@DHowett DHowett added zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. and removed zStable-Service-Queued-1.12 A floating label that tracks the current Stable version for servicing purposes. labels Feb 24, 2022
@ghost ghost merged commit c62705e into main Feb 24, 2022
@ghost ghost deleted the dev/migrie/b/12398-tab-colors branch February 24, 2022 18:41
zadjii-msft added a commit that referenced this pull request Mar 3, 2022
@zadjii-msft
Update light theme tab background for greater contrast. (#12529)
cf26d27 
Changes the tab view BG to `#e8e8e8`, as discussed in mail thread.

Closes #12398
DHowett pushed a commit that referenced this pull request Mar 10, 2022
@zadjii-msft @DHowett
Update light theme tab background for greater contrast. (#12529)
4f2bce1 
Changes the tab view BG to `#e8e8e8`, as discussed in mail thread.

Closes #12398

(cherry picked from commit c62705e)
@zadjii-msft zadjii-msft mentioned this pull request Mar 15, 2022
Merged
@ghost
Copy link

ghost commented Mar 25, 2022

🎉Windows Terminal Preview v1.13.1073 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Mar 25, 2022
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@miniksa miniksa miniksa approved these changes

Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update changed tab colors so I can no longer figure out which one is active 🤬
3 participants
@zadjii-msft @DHowett @miniksa