Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace TrayIcon with NotificationIcon #11219

Merged
4 commits merged into from
Sep 14, 2021
Merged

Replace TrayIcon with NotificationIcon #11219

4 commits merged into from
Sep 14, 2021

Conversation

leonMSFT
Copy link
Contributor

@leonMSFT leonMSFT commented Sep 13, 2021 •
edited by DHowett
Loading

This PR simply replaces all uses of "TrayIcon" and "Tray" with "NotificationIcon" and "NotificationArea" to be more accurate. Originally I kinda wanted to only replace all occurrences of it in settings and user facing things, but I figured I might as well make it consistent throughout all of our code.

Closes #11101.

@leonMSFT leonMSFT added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. labels Sep 13, 2021
@leonMSFT leonMSFT added this to the Terminal v1.12 milestone Sep 13, 2021
DHowett
DHowett approved these changes Sep 14, 2021
View reviewed changes
Copy link
Member

@DHowett DHowett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this!

@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Sep 14, 2021
@ghost
Copy link

ghost commented Sep 14, 2021

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@DHowett DHowett removed the AutoMerge Marked for automatic merge by the bot when requirements are met label Sep 14, 2021
@ghost ghost merged commit 844d46a into main Sep 14, 2021
@ghost ghost deleted the dev/lelian/notifyicon/rename branch September 14, 2021 16:12
@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Sep 14, 2021
@ghost ghost added Area-Settings Issues related to settings and customizability, for console or terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Sep 14, 2021
@zadjii-msft zadjii-msft mentioned this pull request Sep 15, 2021
Open
@zadjii-msft zadjii-msft mentioned this pull request Sep 22, 2021
Closed
@miniksa miniksa added the zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. label Sep 27, 2021
miniksa pushed a commit that referenced this pull request Sep 27, 2021
@leonMSFT @miniksa
Replace TrayIcon with NotificationIcon (#11219)
4fa0dc7 
This PR simply replaces all uses of "TrayIcon" and "Tray" with "NotificationIcon" and "NotificationArea" to be more accurate. Originally I kinda wanted to only replace all occurrences of it in settings and user facing things, but I figured I might as well make it consistent throughout all of our code.
@ghost
Copy link

ghost commented Oct 4, 2021

🎉Windows Terminal Preview v1.11.2731.0 has been released which incorporates this pull request.:tada:

Handy links:

@Beej126
Copy link

Beej126 commented Oct 4, 2021

i've started seeing references that Win11 has renamed the "Notifications Area" to "Taskbar Corner Overflow".
e.g. https://www.thewindowsclub.com/how-to-reset-taskbar-corner-overflow-icons

@miniksa
Copy link
Member

miniksa commented Oct 6, 2021

i've started seeing references that Win11 has renamed the "Notifications Area" to "Taskbar Corner Overflow". e.g. thewindowsclub.com/how-to-reset-taskbar-corner-overflow-icons

Yeah funfortunately we found that out after committing this PR. We'll revisit that in the future.

@DHowett DHowett removed the zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. label Oct 11, 2021
@ghost
Copy link

ghost commented Oct 20, 2021

🎉Windows Terminal Preview v1.12.2922.0 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

Assignees
No one assigned
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Area-User Interface Issues pertaining to the user interface of the Console or Terminal AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v1.12
Development

Successfully merging this pull request may close these issues.

Settings should refer to Notification Area by correct name (not ‘tray’)
5 participants
@leonMSFT @Beej126 @miniksa @DHowett @zadjii-msft