Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings should refer to Notification Area by correct name (not ‘tray’) #11101

Closed
idg10 opened this issue Sep 1, 2021 · 6 comments · Fixed by #11219
Closed

Settings should refer to Notification Area by correct name (not ‘tray’) #11101

idg10 opened this issue Sep 1, 2021 · 6 comments · Fixed by #11219
Assignees
@leonMSFT
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.12

Comments

@idg10
Copy link

idg10 commented Sep 1, 2021

Description of the new feature/enhancement

Settings that use the word 'tray' to refer to the notification area of the Windows taskbar should use the correct name (i.e. 'notification area'.)

As Raymond Chen pointed out almost 2 decades ago:

One of the most common errors is to refer to the Taskbar Notification Area as the “tray” or the “system tray”. This has never been correct. If you find any documentation that refers to it as the “tray” then you found a bug.

See his blog for details:
https://devblogs.microsoft.com/oldnewthing/20030910-00/?p=42583

Proposed technical implementation details (optional)

Preview 1.11 has introduced new settings called minimizeToTray and alwaysShowTrayIcon. These should be renamed to minimizeToNotificationArea and alwaysShowNotificationIcon respectively before this feature ships. Documentation for related features should replace all mention of the 'tray' with the correct term: 'notification area'.
@idg10 idg10 added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Sep 1, 2021
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Sep 1, 2021
@zadjii-msft
Copy link
Member

You're technically correct, the best kind of correct. That being said, the time for this comment was before we shipped the setting. We can't really change the name of the setting without breaking folks now. Fortunately, the way it's been exposed in the Settings UI (see https://github.com/microsoft/terminal/pull/11070/files#diff-8dc8472b6467fd19c90a98b3a80ef6d300516ebcb09c43ad38a8ddfc3da74aaf) has already been updated to say "Notification Area"

@zadjii-msft zadjii-msft added Area-Settings Issues related to settings and customizability, for console or terminal Product-Terminal The new Windows Terminal. Resolution-Won't-Fix We're just really obstinate about this. There's probably a good reason. labels Sep 1, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Sep 1, 2021
@idg10
Copy link
Author

idg10 commented Sep 7, 2021

the time for this comment was before we shipped the setting

I posted this comment 1 day after Preview 1.11 was announced. Just how short is your window between announcing a preview the relevant feature shipping?

Or are these settings not as new as the blog at https://devblogs.microsoft.com/commandline/windows-terminal-preview-1-11-release/ suggested?

@DHowett
Copy link
Member

DHowett commented Sep 7, 2021

Just how short is your window...

There's a 6-week delay (usually) between features shipping in preview and them showing up in stable. In this case, I do believe that there's no need for setting portability between stable and preview... especially because the notification area icon is gated to be in preview only.

That having been said, letting slip a colloquialism once in a while hasn't always killed a project. 😄

@DHowett DHowett reopened this Sep 7, 2021
@zadjii-msft zadjii-msft added the Needs-Discussion Something that requires a team discussion before we can proceed label Sep 7, 2021
@zadjii-msft zadjii-msft added this to the Terminal v1.12 milestone Sep 8, 2021
@zadjii-msft zadjii-msft added zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. and removed Needs-Discussion Something that requires a team discussion before we can proceed labels Sep 8, 2021
@leonMSFT leonMSFT self-assigned this Sep 8, 2021
@DHowett DHowett mentioned this issue Sep 14, 2021
Merged
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label Sep 14, 2021
@zadjii-msft
Copy link
Member

This was merged in #11219, but the bot decided not to close it?

@miniksa miniksa removed zPreview-Service-Queued-1.13 A floating label that tracks the current Preview version for servicing purposes. Resolution-Won't-Fix We're just really obstinate about this. There's probably a good reason. labels Sep 27, 2021
@ghost
Copy link

ghost commented Oct 4, 2021

🎉This issue was addressed in #11219, which has now been successfully released as Windows Terminal Preview v1.11.2731.0.:tada:

Handy links:

@zadjii-msft zadjii-msft mentioned this issue Oct 5, 2021
Open
15 tasks
@ghost
Copy link

ghost commented Oct 20, 2021

🎉This issue was addressed in #11219, which has now been successfully released as Windows Terminal Preview v1.12.2922.0.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leonMSFT leonMSFT

Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.12
Development

Successfully merging a pull request may close this issue.

Replace TrayIcon with NotificationIcon microsoft/terminal
5 participants
@DHowett @idg10 @miniksa @zadjii-msft @leonMSFT