Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change settings content frame transition to drill in #10934

Merged
1 commit merged into from
Aug 12, 2021
Merged

Change settings content frame transition to drill in #10934

1 commit merged into from
Aug 12, 2021

Conversation

Don-Vito
Copy link
Contributor

PR Checklist

@ghost ghost added Area-Settings UI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Aug 12, 2021
@Don-Vito
Copy link
Contributor Author

@carlos-zamora - this changes the default transition for all scenarios (both for internal navigation and when switching tabs). Hope it makes sense. At least for me it feels better 😊

@carlos-zamora
Copy link
Member

From #10632:
DrillIn

carlos-zamora
carlos-zamora approved these changes Aug 12, 2021
View reviewed changes
Copy link
Member

@carlos-zamora carlos-zamora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! Thanks!

@carlos-zamora carlos-zamora added the Needs-Second It's a PR that needs another sign-off label Aug 12, 2021
@DHowett
Copy link
Member

DHowett commented Aug 12, 2021

So, it doesn't fix the issue but it sure does make it less jarring. Let's see how it does!

@DHowett
Copy link
Member

DHowett commented Aug 12, 2021

How does it look when you're scrolled down somewhere in the page, leave and come back? How does it feel when you move between pages?

@Don-Vito
Copy link
Contributor Author

DrillIn2

@Don-Vito
Copy link
Contributor Author

So, it doesn't fix the issue but it sure does make it less jarring. Let's see how it does!

Theoretically, we can override the transition (e.g., by suppression) after the settings tab is open the first time. However, I actually quite love this experience.

miniksa
miniksa approved these changes Aug 12, 2021
View reviewed changes
Copy link
Member

@miniksa miniksa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it

@DHowett
Copy link
Member

DHowett commented Aug 12, 2021

I love it

ME TOO

@DHowett DHowett added the AutoMerge Marked for automatic merge by the bot when requirements are met label Aug 12, 2021
@ghost
Copy link

ghost commented Aug 12, 2021

Hello @DHowett!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours, a condition that will be fulfilled in about 5 hours 27 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@DHowett
Copy link
Member

DHowett commented Aug 12, 2021

@msftbot merge this in 1 minutes

@ghost
Copy link

ghost commented Aug 12, 2021

Hello @DHowett!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Thu, 12 Aug 2021 22:11:52 GMT, which is in 1 minute

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost merged commit 70560a7 into microsoft:main Aug 12, 2021
DHowett pushed a commit that referenced this pull request Aug 25, 2021
@Don-Vito @DHowett
Change settings content frame transition to drill in (#10934)
62814f8 
## PR Checklist
* [x] Closes #10632
* [x] CLA signed. 
* [ ] Tests added/passed
* [ ] Documentation updated.
* [ ] Schema updated.
* [ ] I've discussed this with core contributors already.
@ghost
Copy link

ghost commented Aug 31, 2021

🎉Windows Terminal Preview v1.10.2383.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request Aug 31, 2021
Closed
@ghost
Copy link

ghost commented Aug 31, 2021

🎉Windows Terminal Preview v1.11.2421.0 has been released which incorporates this pull request.:tada:

Handy links:

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-zamora carlos-zamora carlos-zamora approved these changes

@miniksa miniksa miniksa approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

@DHowett DHowett Awaiting requested review from DHowett

@leonMSFT leonMSFT Awaiting requested review from leonMSFT

@PankajBhojwani PankajBhojwani Awaiting requested review from PankajBhojwani

@lhecker lhecker Awaiting requested review from lhecker

Assignees
No one assigned
Labels
Area-Settings UI Anything specific to the SUI AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Second It's a PR that needs another sign-off Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Settings Page Animation Restarts When Switching To Settings Tab
5 participants
@Don-Vito @carlos-zamora @DHowett @miniksa @zadjii-msft