Settings Page Animation Restarts When Switching To Settings Tab

[ghost]

When you have a setting tab already open and switch back and forth between the Settings tab and any other tab, the animation of the page (where the page content appears vertically centered and moves upward - which is a bit of an odd animation itself) will restart again, even though this isn't the first time opening the page.

It might have been intended, but I find it a little.... odd.

Proposed technical implementation details (optional)

A different animation might make this appear less odd. Like fade, or any number of animations.

2021-07-12.09-30-48.mp4

[DHowett]

I wonder if this is because of us doing a Navigate to the root content view when the settings page comes visible. Perhaps there's something we can do to bind the root content such that it doesn't animate at all on first / subsequent launches. @carlos-zamora this might be related to the view model stuff we were talking about (since doing the navigation in the "code behind" versus as an intrinsic part of the page state may be to blame).

[DHowett]

(Thanks for filing this!)

[carlos-zamora]

I wonder if this is because of us doing a Navigate to the root content view when the settings page comes visible. Perhaps there's something we can do to bind the root content such that it doesn't animate at all on first / subsequent launches. @carlos-zamora this might be related to the view model stuff we were talking about (since doing the navigation in the "code behind" versus as an intrinsic part of the page state may be to blame).

I did a trace because I was curious. Looks something like this:

• TerminalPage::_OpenSettingsUI(): select the settings tab and update content
• MainPage::SettingsNav_Loaded():
  • if (SettingsNav().SelectedItem() == nullptr) --> false
  • nothing happens. Surprisingly, _Navigate() is not called!

So yeah, looks like XAML is just doing it for us.

Playing with the XAML controls gallery, I agree that perhaps a DrillIn or Suppress may work best. Definitely odd!

[Don-Vito]

@carlos-zamora - do you have a preference between Drill in or Surpress? 😊

[carlos-zamora]

@carlos-zamora - do you have a preference between Drill in or Surpress? 😊

Let's try DrillIn!

[Don-Vito]

[Don-Vito]

@carlos-zamora - WDYT?

[Don-Vito]

OK. Committing :)

[ghost]

🎉This issue was addressed in #10934, which has now been successfully released as Windows Terminal Preview v1.10.2383.0.:tada:

Handy links:

• Release Notes
• Store Download

[ghost]

🎉This issue was addressed in #10934, which has now been successfully released as Windows Terminal Preview v1.11.2421.0.:tada:

Handy links:

• Release Notes
• Store Download