Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix profile selection upon discarding changes in SUI #10147

Merged
merged 1 commit into from
May 21, 2021
Merged

Fix profile selection upon discarding changes in SUI #10147

merged 1 commit into from
May 21, 2021

Conversation

Don-Vito
Copy link
Contributor

PR Checklist

Detailed Description of the Pull Request / Additional comments

  • Preserve profile GUID upon item Tag creation.
  • Use this GUID rather than the current profile GUID to select an item
    upon settings update.

So even if the profile was renamed and the GUID has changed,
the GUID in the tag remains unchanged and can be found
upon discarding.

@ghost ghost added Area-Settings UI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. labels May 21, 2021
@zadjii-msft
Copy link
Member

@msftbot make sure @carlos-zamora signs off on this

(he's out for the week, but I believe he'll be back Monday)

@ghost ghost added the AutoMerge Marked for automatic merge by the bot when requirements are met label May 21, 2021
@ghost
Copy link

ghost commented May 21, 2021

Hello @zadjii-msft!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I'll only merge this pull request if it's approved by @carlos-zamora

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

zadjii-msft
zadjii-msft approved these changes May 21, 2021
View reviewed changes
Copy link
Member

@zadjii-msft zadjii-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Does this still work if you rename a profile, then hit "Save"?
    • yes it does, cool

@DHowett
Copy link
Member

DHowett commented May 21, 2021

I'm fine with this in Carlos' absence. @carlos-zamora if this troubles you, feel free to stage a revert. Thanks!

@DHowett DHowett merged commit ee86799 into microsoft:main May 21, 2021
@ghost
Copy link

ghost commented May 25, 2021

🎉Windows Terminal Preview v1.9.1445.0 has been released which incorporates this pull request.:tada:

Handy links:

@ghost ghost mentioned this pull request May 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@zadjii-msft zadjii-msft zadjii-msft approved these changes

Assignees
No one assigned
Labels
Area-Settings UI Anything specific to the SUI AutoMerge Marked for automatic merge by the bot when requirements are met Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Don-Vito @zadjii-msft @DHowett