Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot find renamed profile #8881

Closed
carlos-zamora opened this issue Jan 25, 2021 · 1 comment
Closed

Cannot find renamed profile #8881

carlos-zamora opened this issue Jan 25, 2021 · 1 comment
Assignees
@carlos-zamora
Labels
Area-Settings UI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.10

Comments

@carlos-zamora
Copy link
Member

Environment

In a world where #8844 and #8837 are both merged.

Steps to reproduce

  1. Open Settings UI
  2. Navigate to a custom profile
  3. Rename the profile
  4. Invoke "discard changes" button

Expected behavior

After the changes are discarded, the same profile should still be selected. (If after #8844, the correct pivot should be selected too).

Actual behavior

The profile is not found, and "Startup" page is selected instead.

Additional Comments

Unless a guid is explicitly set for a profile (i.e. in-box profiles), the guid is automatically generated as a function of the profile name and source. Thus, renaming a profile results in changing the guid. Since we use the guid as a unique identifier to find the profile, we can no longer find that profile.
@carlos-zamora carlos-zamora added Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Priority-2 A description (P2) Area-Settings UI Anything specific to the SUI labels Jan 25, 2021
@carlos-zamora carlos-zamora added this to the Terminal v1.7 milestone Jan 25, 2021
@ghost ghost added the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jan 25, 2021
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Jan 26, 2021
@carlos-zamora carlos-zamora self-assigned this Mar 10, 2021
@Don-Vito Don-Vito mentioned this issue May 21, 2021
Merged
6 tasks
@ghost ghost added In-PR This issue has a related PR and removed In-PR This issue has a related PR labels May 21, 2021
@ghost ghost added the Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. label May 21, 2021
@ghost
Copy link

ghost commented May 25, 2021

🎉This issue was addressed in #10147, which has now been successfully released as Windows Terminal Preview v1.9.1445.0.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlos-zamora carlos-zamora

Labels
Area-Settings UI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-2 A description (P2) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.10
Development

No branches or pull requests
4 participants
@DHowett @carlos-zamora @zadjii-msft @cinnamon-msft