Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings dialog: Not possible to switch radio buttons with the keyboard #9566

Closed
MarcoZehe opened this issue Mar 21, 2021 · 7 comments · Fixed by #12833
Closed

Settings dialog: Not possible to switch radio buttons with the keyboard #9566

MarcoZehe opened this issue Mar 21, 2021 · 7 comments · Fixed by #12833
Labels
Area-SettingsUI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Tracking-External This bug isn't resolved, but it's following an external workitem.
Milestone
Backlog

Comments

@MarcoZehe
Copy link

Windows Terminal version (or Windows build number)

Windows Terminal Preview Version: 1.7.572.0

Other Software

No response

Steps to reproduce

  1. Open Terminal.
  2. Open Settings by pressing CTRL+,.
  3. Tab to the radio buttons for the start mode. This is set to "Default" by default, but has options such as "Maximized" etc.
  4. Try to switch between the set of five radio buttons using the keyboard, up and down arrows, or left and right arrows.

Expected Behavior

Focus should switch to the other radio buttons, and the selection/check mark moves with it.

Actual Behavior

Nothing happens.

Using arrow keys is the standard way to interact with a set of radio buttons.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 21, 2021
@skyline75489 skyline75489 added the Area-SettingsUI Anything specific to the SUI label Mar 21, 2021
@zadjii-msft
Copy link
Member

Huh, that's weird. Those should work, because they definitely work in the XAML Controls Gallery. Thanks!

@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Mar 22, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Mar 22, 2021
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Mar 22, 2021
@MarcoZehe
Copy link
Author

Yes, I know other XAML-based apps where this works, so it is a problem specific to the way this XAML is marked up. I also reported another issue where the radio buttons aren't associated with a true group element. Perhaps these two are related.

@zadjii-msft
Copy link
Member

Oh jeez, this is microsoft/microsoft-ui-xaml#3156

@zadjii-msft zadjii-msft added Tracking-External This bug isn't resolved, but it's following an external workitem. and removed Help Wanted We encourage anyone to jump in on these. labels Mar 22, 2021
@DHowett DHowett mentioned this issue Mar 22, 2021
Open
@carlos-zamora
Copy link
Member

carlos-zamora commented Mar 23, 2021 •
edited
Loading

@DHowett and @cinnamon-msft Here's a thought: should we replace any instance of RadioButtons in Windows Terminal with ComboBox? ComboBox doesn't have this issue.

@DHowett
Copy link
Member

DHowett commented Mar 23, 2021

I don't hate that. We still can't provide a tooltip for each entry ... but maybe we could display some tiny subtitle text underneath it explaining what happens (like this:)

image

@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Mar 26, 2021
@zadjii-msft zadjii-msft mentioned this issue Sep 14, 2021
Closed
@zadjii-msft zadjii-msft modified the milestones: Terminal Backlog, Backlog Jan 4, 2022
@zadjii-msft zadjii-msft mentioned this issue Apr 5, 2022
Merged
5 tasks
@ghost ghost added the In-PR This issue has a related PR label Apr 5, 2022
@ghost ghost closed this as completed in #12833 Apr 6, 2022
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Apr 6, 2022
ghost pushed a commit that referenced this issue Apr 6, 2022
@zadjii-msft
Replace RadioButton expanders with ComboBoxes (#12833)
9e03800 
Replaces all the `RadioButton` expanders with `ComboBox`es, which can have the options inline, as opposed to in the expander content. For example, here's a single commit with the changes for a single one of these settings: 745c77d

### Checklist
* [x] Closes #12648
* [x] Actually closes #9566 as well (by just removing all radio buttons)
* [x] I work here
* [x] Tested manually
* [x] I'd love @carlos-zamora to have an a11y pass at this, just to see if it's egregious or not.

### Before, after:

![image](https://user-images.githubusercontent.com/18356694/161822068-939ff875-00ff-454a-8b58-cb843ba801f4.png)
carlos-zamora pushed a commit that referenced this issue May 12, 2022
@zadjii-msft @carlos-zamora
Replace RadioButton expanders with ComboBoxes (#12833)
8b02fcf 
Replaces all the `RadioButton` expanders with `ComboBox`es, which can have the options inline, as opposed to in the expander content. For example, here's a single commit with the changes for a single one of these settings: 745c77d

### Checklist
* [x] Closes #12648
* [x] Actually closes #9566 as well (by just removing all radio buttons)
* [x] I work here
* [x] Tested manually
* [x] I'd love @carlos-zamora to have an a11y pass at this, just to see if it's egregious or not.

### Before, after:

![image](https://user-images.githubusercontent.com/18356694/161822068-939ff875-00ff-454a-8b58-cb843ba801f4.png)

(cherry picked from commit 9e03800)
Service-Card-Id: 81744877
Service-Version: 1.13
@ghost
Copy link

ghost commented May 24, 2022

🎉This issue was addressed in #12833, which has now been successfully released as Windows Terminal v1.13.1143.:tada:

Handy links:

@ghost
Copy link

ghost commented May 24, 2022

🎉This issue was addressed in #12833, which has now been successfully released as Windows Terminal Preview v1.14.143.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-SettingsUI Anything specific to the SUI Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Tracking-External This bug isn't resolved, but it's following an external workitem.
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Replace RadioButton expanders with ComboBoxes microsoft/terminal
5 participants
@DHowett @MarcoZehe @skyline75489 @carlos-zamora @zadjii-msft