Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change radio button options in settings to listbox options #12648

Closed
Lo0oG opened this issue Mar 9, 2022 · 4 comments · Fixed by #12833
Closed

Change radio button options in settings to listbox options #12648

Lo0oG opened this issue Mar 9, 2022 · 4 comments · Fixed by #12833
Labels
Area-SettingsUI Anything specific to the SUI Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v1.14

Comments

@Lo0oG
Copy link

Lo0oG commented Mar 9, 2022 •
edited
Loading

Description of the new feature/enhancement

Since the settings area changed over to the Windows 11 style, extra navigation is needed to the any settings that use radio buttons to display the options.

image

An example below is the theme setting.

image

If these radio options were changed into listbox options (similar to the language option) then the currently set value would be visible immediatly and could be changed easier without the need for extra navigation to expand the box.
@Lo0oG Lo0oG added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Mar 9, 2022
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 9, 2022
@zadjii-msft
Copy link
Member

Yep, this is something we're planning on doing, just haven't had the chance to do yet.

image

https://github.com/microsoft/terminal/compare/dev/migrie/b/12648-radio-to-combobox has a super simple proof of concept of how easy this should be to do. I haven't validated a11y properties on that though, which I think was our biggest concern? But this is super easy so we may want to pull in for 1.14. @PankajBhojwani for thoughts. He may remember why we hadn't done this before.

@zadjii-msft zadjii-msft added Area-SettingsUI Anything specific to the SUI Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. and removed Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. labels Mar 10, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Mar 10, 2022
@zadjii-msft zadjii-msft added this to the Terminal v1.14 milestone Mar 10, 2022
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Mar 10, 2022
@DHowett
Copy link
Member

DHowett commented Mar 10, 2022

i love it

@zadjii-msft zadjii-msft mentioned this issue Apr 5, 2022
Merged
5 tasks
@ghost ghost added the In-PR This issue has a related PR label Apr 5, 2022
@ghost ghost closed this as completed in #12833 Apr 6, 2022
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Apr 6, 2022
ghost pushed a commit that referenced this issue Apr 6, 2022
@zadjii-msft
Replace RadioButton expanders with ComboBoxes (#12833)
9e03800 
Replaces all the `RadioButton` expanders with `ComboBox`es, which can have the options inline, as opposed to in the expander content. For example, here's a single commit with the changes for a single one of these settings: 745c77d

### Checklist
* [x] Closes #12648
* [x] Actually closes #9566 as well (by just removing all radio buttons)
* [x] I work here
* [x] Tested manually
* [x] I'd love @carlos-zamora to have an a11y pass at this, just to see if it's egregious or not.

### Before, after:

![image](https://user-images.githubusercontent.com/18356694/161822068-939ff875-00ff-454a-8b58-cb843ba801f4.png)
carlos-zamora pushed a commit that referenced this issue May 12, 2022
@zadjii-msft @carlos-zamora
Replace RadioButton expanders with ComboBoxes (#12833)
8b02fcf 
Replaces all the `RadioButton` expanders with `ComboBox`es, which can have the options inline, as opposed to in the expander content. For example, here's a single commit with the changes for a single one of these settings: 745c77d

### Checklist
* [x] Closes #12648
* [x] Actually closes #9566 as well (by just removing all radio buttons)
* [x] I work here
* [x] Tested manually
* [x] I'd love @carlos-zamora to have an a11y pass at this, just to see if it's egregious or not.

### Before, after:

![image](https://user-images.githubusercontent.com/18356694/161822068-939ff875-00ff-454a-8b58-cb843ba801f4.png)

(cherry picked from commit 9e03800)
Service-Card-Id: 81744877
Service-Version: 1.13
@ghost
Copy link

ghost commented May 24, 2022

🎉This issue was addressed in #12833, which has now been successfully released as Windows Terminal v1.13.1143.:tada:

Handy links:

@ghost
Copy link

ghost commented May 24, 2022

🎉This issue was addressed in #12833, which has now been successfully released as Windows Terminal Preview v1.14.143.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-SettingsUI Anything specific to the SUI Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v1.14
Development

Successfully merging a pull request may close this issue.

Replace RadioButton expanders with ComboBoxes microsoft/terminal
3 participants
@DHowett @zadjii-msft @Lo0oG