Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vintage cursor height in SUI does not clamp values to 1-100 #9357

Closed
zadjii-msft opened this issue Mar 3, 2021 · 2 comments · Fixed by #9370
Closed

Vintage cursor height in SUI does not clamp values to 1-100 #9357

zadjii-msft opened this issue Mar 3, 2021 · 2 comments · Fixed by #9370
Labels
Area-Settings UI Anything specific to the SUI good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Terminal v2.0

Comments

@zadjii-msft
Copy link
Member

vintage

Windows Terminal Preview v1.7.572.0

allowed input range may be too large

Originally posted by @maggch97 in #9175 (comment)
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 3, 2021
@zadjii-msft zadjii-msft added Area-Settings UI Anything specific to the SUI good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. labels Mar 3, 2021
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Mar 3, 2021
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone Mar 3, 2021
@eugenesmlv eugenesmlv mentioned this issue Mar 3, 2021
Merged
2 tasks
@ghost ghost added the In-PR This issue has a related PR label Mar 3, 2021
@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Mar 3, 2021
@ghost ghost closed this as completed in #9370 Mar 4, 2021
ghost pushed a commit that referenced this issue Mar 4, 2021
@eugenesmlv
[Settings UI] Clamp vintage cursor height and history size (#9370)
ac3fecb 
## Summary of the Pull Request
Add `Minimum` and `Maximum` for the cursor height numberbox in the SUI.
Add `Minimum` for the history size numberbox in the SUI.

## PR Checklist
* [x] Closes #9357, Closes #9175
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA

## Validation Steps Performed
Manual validation
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels Mar 4, 2021
DHowett pushed a commit that referenced this issue Apr 13, 2021
@eugenesmlv @DHowett
[Settings UI] Clamp vintage cursor height and history size (#9370)
f67db39 
## Summary of the Pull Request
Add `Minimum` and `Maximum` for the cursor height numberbox in the SUI.
Add `Minimum` for the history size numberbox in the SUI.

## PR Checklist
* [x] Closes #9357, Closes #9175
* [x] CLA signed. If not, go over [here](https://cla.opensource.microsoft.com/microsoft/Terminal) and sign the CLA

## Validation Steps Performed
Manual validation

(cherry picked from commit ac3fecb)
@ghost
Copy link

ghost commented Apr 14, 2021

🎉This issue was addressed in #9370, which has now been successfully released as Windows Terminal v1.7.1033.0.:tada:

Handy links:

@ghost
Copy link

ghost commented Apr 14, 2021

🎉This issue was addressed in #9370, which has now been successfully released as Windows Terminal Preview v1.8.1032.0.:tada:

Handy links:

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Settings UI Anything specific to the SUI good first issue This is a fix that might be easier for someone to do as a first contribution Help Wanted We encourage anyone to jump in on these. Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Terminal v2.0
Development

Successfully merging a pull request may close this issue.

[Settings UI] Clamp vintage cursor height and history size eugenesmlv/terminal
1 participant
@zadjii-msft